[Bug 39492] New: Web Usability Accessibility Audit - Browse Shelf Links on 'Publications' Page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Bug ID: 39492 Summary: Web Usability Accessibility Audit - Browse Shelf Links on 'Publications' Page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: alexander.blanchard@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org The accessibility audit highlighted that on the accessibility page there are repeated 'Browse Shelf' links. The report indicates that these need additional context to be clear without relying on surrounding context. The suggested solution is to add extra context using aria-label or aria-labelledby -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexander.blanchard@openfif |ity.org |th.co.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 --- Comment #1 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Created attachment 180412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180412&action=edit Bug 39492: Browse Shelf Links on 'Publications' Pg An accessibility audit has highlighted that the Browse Shelf link on the Publicaitons page does not provide enough context for visually impaired users. The suggested solution was to add aria-labels to provide context. To test: 1) Ensure that you have at least one item with a call number. 2) Navigate to the item's page and scroll down to the table. 3) Right click and choose inspect on the 'Browse Shelf' link and note that there is not an aria label. 4) Apply patch. 5) Repeat the steps above. 6) Notice that there is an aria-label that adds context to the Browse Shelf link by including the title of the record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180412|0 |1 is obsolete| | --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 180524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180524&action=edit Bug 39492: Browse Shelf Links on 'Publications' Pg An accessibility audit has highlighted that the Browse Shelf link on the Publicaitons page does not provide enough context for visually impaired users. The suggested solution was to add aria-labels to provide context. To test: 1) Ensure that you have at least one item with a call number. 2) Navigate to the item's page and scroll down to the table. 3) Right click and choose inspect on the 'Browse Shelf' link and note that there is not an aria label. 4) Apply patch. 5) Repeat the steps above. 6) Notice that there is an aria-label that adds context to the Browse Shelf link by including the title of the record. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Hey Alexander, -A couple minor issues here. It looks like some how a `???` got added to the Browse shelf link. -Fliters are missing here: - aria-label="Browse Shelf for [% title %]" + aria-label="Browse Shelf for [% title | html %]" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 --- Comment #4 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Created attachment 181501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181501&action=edit Bug 39492: Browse Shelf Links on Publications Pg An accessibility audit has highlighted that the Browse Shelf link on the Publicaitons page does not provide enough context for visually impaired users. The suggested solution was to add aria-labels to provide context. This follow up patch addresses the missing html filter. To test: 1) Ensure that you have at least one item with a call number. 2) Navigate to the item's page and scroll down to the table. 3) Right click and choose inspect on the 'Browse Shelf' link and note that there is not an aria label. 4) Apply patch. 5) Repeat the steps above. 6) Notice that there is an aria-label that adds context to the Browse Shelf link by including the title of the record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181501|0 |1 is obsolete| | --- Comment #5 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Created attachment 181502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181502&action=edit Bug 39492: Browse Shelf Links on Publications Pg An accessibility audit has highlighted that the Browse Shelf link on the Publicaitons page does not provide enough context for visually impaired users. The suggested solution was to add aria-labels to provide context. This follow up patch addresses the missing html filter. To test: 1) Ensure that you have at least one item with a call number. 2) Navigate to the item's page and scroll down to the table. 3) Right click and choose inspect on the 'Browse Shelf' link and note that there is not an aria label. 4) Apply patch. 5) Repeat the steps above. 6) Notice that there is an aria-label that adds context to the Browse Shelf link by including the title of the record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 --- Comment #6 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- (In reply to Lucas Gass (lukeg) from comment #3)
Hey Alexander,
-A couple minor issues here. It looks like some how a `???` got added to the Browse shelf link. -Fliters are missing here:
- aria-label="Browse Shelf for [% title %]" + aria-label="Browse Shelf for [% title | html %]"
Thanks Lucas, addressed these issues and resubmitted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #180524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180524|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 181572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181572&action=edit Bug 39492: Accessibility - add aria label to the OPAC browse shelf link An accessibility audit highlighted that the browse shelf link on a record's holding page does not provide enough context for visually impaired users. The suggested solution was to add aria labels to provide context. Test plan: 1. Ensure that you have at least one item with a call number. 2. Navigate to the records's page and scroll down to the holdings table. 3. Right click and choose inspect on the 'Browse shelf' link and note that there is not an aria label. 4. Apply the patch. 5. Refresh the page and repeat step 3. 6. Note that there is now an aria label that adds context to the browse shelf link - it now includes the title of the record, for example: ...aria-label="Browse Shelf for Programming Perl /"... Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 181573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181573&action=edit Bug 39492: (follow-up) Add missing HTML filters Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181502|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Web Usability Accessibility |Web usability accessibility |Audit - Browse Shelf Links |audit: missing aria label |on 'Publications' Page |on the OPAC holdings table | |browse shelf link Text to go in the| |This enhancement adds an release notes| |aria label to the browse | |shelf link in the OPAC | |holdings table. This | |provides more information | |about what the link does | |for those using assistive | |technology, such as screen | |readers. --- Comment #9 from David Nind <david@davidnind.com> --- I've amended the commit messages to be a bit more in line with the commit message guidelines (https://wiki.koha-community.org/wiki/Commit_messages) - particularly for the follow-up patch, as there is no need to repeat what is in the other patches. I confess to not fully understanding aria labels, however would better wording for the aria label be "Browse the shelf for items near XXXXX"? (Where XXXXX is the title for the item.) To me, that would give more context to what the link does. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- *** Bug 39471 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- (In reply to David Nind from comment #9)
I've amended the commit messages to be a bit more in line with the commit message guidelines (https://wiki.koha-community.org/wiki/Commit_messages) - particularly for the follow-up patch, as there is no need to repeat what is in the other patches.
I confess to not fully understanding aria labels, however would better wording for the aria label be "Browse the shelf for items near XXXXX"? (Where XXXXX is the title for the item.)
To me, that would give more context to what the link does.
I like this suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181572|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182414&action=edit Bug 39492: Accessibility - add aria label to the OPAC browse shelf link An accessibility audit highlighted that the browse shelf link on a record's holding page does not provide enough context for visually impaired users. The suggested solution was to add aria labels to provide context. Test plan: 1. Ensure that you have at least one item with a call number. 2. Navigate to the records's page and scroll down to the holdings table. 3. Right click and choose inspect on the 'Browse shelf' link and note that there is not an aria label. 4. Apply the patch. 5. Refresh the page and repeat step 3. 6. Note that there is now an aria label that adds context to the browse shelf link - it now includes the title of the record, for example: ...aria-label="Browse Shelf for Programming Perl /"... Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181573|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182415&action=edit Bug 39492: (follow-up) Add missing HTML filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182416&action=edit Bug 39492: (QA follow-up) Update wording with suggested text This patch updates the wording for the aria-label to that suggested by David. It clarifies context. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Lots of eyes, including QA people... QA scripts passing, accessibility tools passing. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Web usability accessibility |Add missing aria label on |audit: missing aria label |the OPAC holdings table |on the OPAC holdings table |browse shelf link |browse shelf link | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Shortened the bug title a little as it will appear in the "accessibility" section on the release notes - thanks for taking care! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixing this author line in the first patch to read "Alexander Blanchard", especially since we have a mailmap for mapping john.doe to Kyle, which would be wrong here: From: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Hard to apply on 24.11.x since tidy, I skip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39492 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #20 from David Nind <david@davidnind.com> --- No changes to the manual required (fixes underlying HTML code for accessibility improvements, but no visual changes). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org