http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #1 from Amit <amitddng135@gmail.com> --- Created attachment 21890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21890&action=edit Adding new category in authorized values If not fill any field it save blank record To Test: 1) Go to Authorized values. 2) Create New Category. 3) If you not fill the Category field it will not save the record. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21890|0 |1 is obsolete| | CC| |paola.rossi@cineca.it --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 21899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21899&action=edit Adding new category in authorized values I sign off the patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Why not use the validation method offered by the plugin introduced in Bug 6209? Is there a server-side check that can be added to the JavaScript-based one? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21899|0 |1 is obsolete| | --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 22096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22096&action=edit Bug 11019 Prevent adding new empty category in authorized values Test plan: * Go to Koha > admin > authorised values > New category > save without entering a category value * You'll get a message saying "this field is required" * signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |paul.poulain@biblibre.com Severity|major |normal --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- need signoff again, as I've rewritten the patch. Lowering severity, if the librarian takes care and enters a category, as he's supposed to do, no problem. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22096|0 |1 is obsolete| | Attachment #22097|0 |1 is obsolete| | --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 22110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22110&action=edit Bug 11019 follow-up : reindenting While working on bug 11019, I saw many tabs & silly indenting. This patch fixes both Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10363 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Considering Jonathan's patch is a large improvement, I set this one "in discussion", until the bug 10363 has been pushed -- You are receiving this mail because: You are watching all bug changes.