[Bug 26397] New: opac.scss & opac.css does call non existant image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Bug ID: 26397 Summary: opac.scss & opac.css does call non existant image Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: cornejo.alvaro@gmail.com QA Contact: testopia@bugs.koha-community.org Hi /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/css/src/opac.scss /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/css/opac.css Are calling non existant image logo-koha.png -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opac.scss & opac.css does |opac.scss calls |call non existant image |non-existent image -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |20.05 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Valid in 20.05.x Owen, could you have a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's coming from bug 10309, but it has never been copied from ccsr. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 114101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114101&action=edit Bug 26397: opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Patch no longer applies 8-( Applying: Bug 26397: opac.scss calls non-existent image Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss A koha-tmpl/opac-tmpl/bootstrap/css/src/right-to-left.scss Falling back to patching base and 3-way merge... CONFLICT (modify/delete): koha-tmpl/opac-tmpl/bootstrap/css/src/right-to-left.scss deleted in HEAD and modified in Bug 26397: opac.scss calls non-existent image. Version Bug 26397: opac.scss calls non-existent image of koha-tmpl/opac-tmpl/bootstrap/css/src/right-to-left.scss left in tree. Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114101|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 114304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114304&action=edit Bug 26397: [20.05.x] opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. This patch is specifically for Koha 20.05.x. The bug does not appear in master. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #4)
Patch no longer applies 8-(
Sorry I should have made it more clear, so I've modified the commit message: The patch is specifically for 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114304|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 114397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114397&action=edit Bug 26397: [20.05.x] opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. This patch is specifically for Koha 20.05.x. The bug does not appear in master. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114397|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114572&action=edit Bug 26397: [20.05.x] opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. This patch is specifically for Koha 20.05.x. The bug does not appear in master. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch removes some release notes| |obsolete CSS from the OPAC | |which calls a non-existent | |image. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sending to 20.05 RM queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)| |20.05.08 released in| | CC| |andrew@bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org