https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37008 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 168207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168207&action=edit Bug 37008: Make "Help" link in vue modules translatable The "Help" link in the upper right corner was not translatable in the newer vue modules like ERM and Preservation. To test in koha-testing-docker: * Install any language: sudo koha-translate --install de-DE --dev kohadev * Activate the language in the language system preference * Activate the ERMModule system preference * Go to the ERM module, verify translation works in general, but Help remains in English * Apply patch * Run: yarn build * Run: gulp po:update * Verify the string "Help" now appears in misc/translator/po/de-DE-messages-js.po * Translate it * Run: sudo koha-translate --update de-DE --dev kohadev * Verify "Help" is now translated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #3)

@Katrin should this be "Needs Sign-off"?

It definitely should be, thanks Pedro. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37008 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168208|0 |1 is obsolete| | --- Comment #6 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 168321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168321&action=edit Bug 37008: Make "Help" link in vue modules translatable The "Help" link in the upper right corner was not translatable in the newer vue modules like ERM and Preservation. To test in koha-testing-docker: * Install any language: sudo koha-translate --install de-DE --dev kohadev * Activate the language in the language system preference * Activate the ERMModule system preference * Go to the ERM module, verify translation works in general, but Help remains in English * Apply patch * Run: yarn build * Run: gulp po:update * Verify the string "Help" now appears in misc/translator/po/de-DE-messages-js.po * Translate it * Run: sudo koha-translate --update de-DE --dev kohadev * Verify "Help" is now translated Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37008 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #8 from Jake Deery <jake.deery@ptfs-europe.com> --- Looks great to me, confirmed it as working following the test plan -- initially, added a translation string manually to misc/translator/po/es-ES-messages-js.po: 3617 #: koha-tmpl/intranet-tmpl/prog/js/vue/components/Help.vue:9 3618 msgid "Help" 3619 msgstr "Ayuda" <-- was just "" I would suspect this was because the string isn't in Weblate, yet. Nonetheless, when I added Ayuda and switched to Spanish, I could see the string correctly translated. Might want a second opinion on whether this is correct at the QA stage, but am happy to sign off as I feel the behaviour is accurate (I'm new to Koha dev, see!) Signed off with thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37008 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37008 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 23.11.x ? -- You are receiving this mail because: You are watching all bug changes.