https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #23)

...

+if(typeof autobarcodetype == 'undefined') { + var autobarcodetype = "$autoBarcodeType"; + var attempt = -1; +} => This does not look good either? Why are we conditionally declaring vars here?

@Marcel I did not address this point, tell me if you see a clean solution for this dirty code :)

Thats quite hard. This area needs a major refactoring imo. The solution here does not address more fundamental issues, but looks like a workaround that increases technical debt? -- You are receiving this mail because: You are watching all bug changes.