https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42277 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42277 [Bug 42277] JS error when viewing a subscription -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196803&action=edit Bug 42293: Tidy all script tags - serials In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the serials module. The 3 main changes are in the following files: * routing.tt * serials-search.tt * subscription-detail.tt Changes are trivial. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 [Bug 41653] Stores for permissions and sysprefs should be under the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 197176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197176&action=edit Bug 42293: Tidy all script tags - serials In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the serials module. The 3 main changes are in the following files: * routing.tt * serials-search.tt * subscription-detail.tt Changes are trivial. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |bibliothek@th-wildau.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 --- Comment #5 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200202&action=edit Bug 42293: Tidy all script tags - serials In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the serials module. The 3 main changes are in the following files: * routing.tt * serials-search.tt * subscription-detail.tt Changes are trivial. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42293 --- Comment #7 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200204&action=edit Bug 42293: (QA follow-up) Fix hiding of additiona fields in serials-search This fixes the hiding of additional fields in mana search by generating an array of additional field ids instead of calling To.json(additional_fields_for_subscription) which led to an Template process error. -- You are receiving this mail because: You are watching all bug changes.