[Bug 22544] New: Move C4:.NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Bug ID: 22544 Summary: Move C4:.NewsChannels to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22318 Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 [Bug 22318] Extend Koha news feature to include other content areas -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86772&action=edit Bug 22544: Move get_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86773&action=edit Bug 22544: Move get_opac_news to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86774&action=edit Bug 22544: Move del_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86775&action=edit Bug 22544: Move upd_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86776&action=edit Bug 22544: Move add_opac_item to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86777&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86780&action=edit Bug 22544: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86781&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Bug 22544 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hayleymapley@catalyst.net.n | |z --- Comment #9 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Hi, patch doesn't apply: Applying: Bug 22544: Move get_opac_new to Koha namespace Applying: Bug 22544: Move get_opac_news to Koha namespace Applying: Bug 22544: Move del_opac_new to Koha namespace Applying: Bug 22544: Move upd_opac_new to Koha namespace Applying: Bug 22544: Move add_opac_item to Koha namespace Applying: Bug 22544: Move GetNewsToDisplay to Koha namespace error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt). error: could not build fake ancestor Patch failed at 0001 Bug 22544: Move GetNewsToDisplay to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86772|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 90103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90103&action=edit Bug 22544: Move get_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86773|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 90104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90104&action=edit Bug 22544: Move get_opac_news to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86774|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 90105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90105&action=edit Bug 22544: Move del_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86775|0 |1 is obsolete| | --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 90106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90106&action=edit Bug 22544: Move upd_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86776|0 |1 is obsolete| | --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 90107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90107&action=edit Bug 22544: Move add_opac_item to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86777|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 90108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90108&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86780|0 |1 is obsolete| | --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 90109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90109&action=edit Bug 22544: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86781|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 90110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90110&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Hi Josef, Everything looks good for the test plan, except that when I get to run the test I get this error: t/db_dependent/Koha/News.t .. 4/5 # Failed test 'Active and not expired news' # at t/db_dependent/Koha/News.t line 235. # got: '0' # expected: '4' # Looks like you planned 12 tests but ran 1. # Looks like you failed 1 test of 1 run. t/db_dependent/Koha/News.t .. 5/5 # Failed test '->search_for_display' # at t/db_dependent/Koha/News.t line 270. Can't call method "number" on an undefined value at t/db_dependent/Koha/News.t line 236. # Looks like your test exited with 255 just after 5. t/db_dependent/Koha/News.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/5 subtests Test Summary Report ------------------- t/db_dependent/Koha/News.t (Wstat: 65280 Tests: 5 Failed: 1) Failed test: 5 Non-zero exit status: 255 Files=1, Tests=5, 6 wallclock secs ( 0.03 usr 0.01 sys + 3.92 cusr 0.82 csys = 4.78 CPU) Result: FAIL Please let me know if there's something I may have missed here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Bug 22544 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Bug 22544 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90103|0 |1 is obsolete| | Attachment #90104|0 |1 is obsolete| | Attachment #90105|0 |1 is obsolete| | Attachment #90106|0 |1 is obsolete| | Attachment #90107|0 |1 is obsolete| | Attachment #90108|0 |1 is obsolete| | Attachment #90109|0 |1 is obsolete| | Attachment #90110|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92005&action=edit Bug 22544: Move get_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92006&action=edit Bug 22544: Move get_opac_news to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92007&action=edit Bug 22544: Move del_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92008&action=edit Bug 22544: Move upd_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92009&action=edit Bug 22544: Move add_opac_item to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92010&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92011&action=edit Bug 22544: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92012&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23430 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #28 from David Nind <david@davidnind.com> --- Tested posting news items to librarian interface and the OPAC - can add news items without entering a position (before the patch was applied the news items just 'disappeared'). However, the news items don't display where they should - even after a flush_memcached and restart_all. Tested on koha-testing-docker against latest master. Tested on Ubuntu 18.04 with latest Firefox and Google Chrome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92010|0 |1 is obsolete| | Attachment #92011|0 |1 is obsolete| | Attachment #92012|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95613&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95614&action=edit Bug 22544: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95615&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to David Nind from comment #28)
However, the news items don't display where they should - even after a flush_memcached and restart_all.
Can you detail? I see the news on the intranet mainpage. I did see a weird thing: "Lost connection to MySQL server during query" appeared in the logs and the news did not show up. Then I restart_all and everything went fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- OPAC main page, I see: https://snipboard.io/CW4Bep.jpg It does not appear without the patchset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92005|0 |1 is obsolete| | --- Comment #34 from David Nind <david@davidnind.com> --- Created attachment 95627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95627&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92006|0 |1 is obsolete| | --- Comment #35 from David Nind <david@davidnind.com> --- Created attachment 95628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95628&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92007|0 |1 is obsolete| | --- Comment #36 from David Nind <david@davidnind.com> --- Created attachment 95629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95629&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92008|0 |1 is obsolete| | --- Comment #37 from David Nind <david@davidnind.com> --- Created attachment 95630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95630&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92009|0 |1 is obsolete| | --- Comment #38 from David Nind <david@davidnind.com> --- Created attachment 95631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95631&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95613|0 |1 is obsolete| | --- Comment #39 from David Nind <david@davidnind.com> --- Created attachment 95632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95632&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95614|0 |1 is obsolete| | --- Comment #40 from David Nind <david@davidnind.com> --- Created attachment 95633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95633&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95615|0 |1 is obsolete| | --- Comment #41 from David Nind <david@davidnind.com> --- Created attachment 95634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95634&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #42 from David Nind <david@davidnind.com> --- Hi Jonathan. Figured out why the news items weren't displaying - I was picking today's date when adding, and my local machine time was ahead of koha-testing-docker. Changed date to an early one to resolve this. The only thing I noticed was the filter for 'Display location'. If you select the Librarian Interface there are no results. However, this was happening before the patches were applied. I can create a new bug for this. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch no longer applies - please rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95627|0 |1 is obsolete| | --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 99849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99849&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95628|0 |1 is obsolete| | --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 99850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99850&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95629|0 |1 is obsolete| | --- Comment #46 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 99851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99851&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95630|0 |1 is obsolete| | --- Comment #47 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 99852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99852&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95631|0 |1 is obsolete| | --- Comment #48 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 99853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99853&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95632|0 |1 is obsolete| | --- Comment #49 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 99854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99854&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95633|0 |1 is obsolete| | --- Comment #50 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 99855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99855&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95634|0 |1 is obsolete| | --- Comment #51 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 99856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99856&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #52 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 99857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99857&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #53 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Katrin Fischer from comment #43)
Patch no longer applies - please rebase!
Rebased on master. Thanks Katrin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24742 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move C4:.NewsChannels to |Move C4:NewsChannels to |Koha namespace |Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99849|0 |1 is obsolete| | --- Comment #54 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 104176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104176&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99850|0 |1 is obsolete| | --- Comment #55 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 104177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104177&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99851|0 |1 is obsolete| | --- Comment #56 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 104178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104178&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99852|0 |1 is obsolete| | --- Comment #57 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 104179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104179&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99853|0 |1 is obsolete| | --- Comment #58 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 104180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104180&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99854|0 |1 is obsolete| | --- Comment #59 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 104181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104181&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99855|0 |1 is obsolete| | --- Comment #60 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 104182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104182&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99856|0 |1 is obsolete| | --- Comment #61 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 104183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104183&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99857|0 |1 is obsolete| | --- Comment #62 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 104184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104184&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #63 from Josef Moravec <josef.moravec@gmail.com> --- Rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #64 from David Nind <david@davidnind.com> --- Changed status backed to signed off - patch now applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've looked at this a fair bit the past couple of days, and it certainly does move us from C4 to Koha.. and does an amount of tidying.. However, I'm torn as I feel we could afford to go a fair bit further. The field names are out right confusing and the logic is somewhat weird. Are you intending on treating this as a first step Josef or was this as far as you intended going? I think we've missed 20.05 now I'm afraid, but as we're moving lots of preferences over to this area perhaps it's time to focus on it more and further clean and improve both the db structure and logic early next release.? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #65)
I've looked at this a fair bit the past couple of days, and it certainly does move us from C4 to Koha.. and does an amount of tidying..
However, I'm torn as I feel we could afford to go a fair bit further. The field names are out right confusing and the logic is somewhat weird.
Are you intending on treating this as a first step Josef or was this as far as you intended going?
I think we've missed 20.05 now I'm afraid, but as we're moving lots of preferences over to this area perhaps it's time to focus on it more and further clean and improve both the db structure and logic early next release.?
Setting to Failed QA to trigger a comment from Josef :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104176|0 |1 is obsolete| | --- Comment #67 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111012&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104177|0 |1 is obsolete| | --- Comment #68 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111013&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104178|0 |1 is obsolete| | --- Comment #69 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111014&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104179|0 |1 is obsolete| | --- Comment #70 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111015&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104180|0 |1 is obsolete| | --- Comment #71 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111016&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104181|0 |1 is obsolete| | --- Comment #72 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111017&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104182|0 |1 is obsolete| | --- Comment #73 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111018&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104183|0 |1 is obsolete| | --- Comment #74 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111019&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104184|0 |1 is obsolete| | --- Comment #75 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111020&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #76 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111021&action=edit Bug 22544: Update to current codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #77 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111022&action=edit Bug 22544: Update search_for_display to be able to take more types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #78 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Martin Renvoize from comment #65)
I've looked at this a fair bit the past couple of days, and it certainly does move us from C4 to Koha.. and does an amount of tidying..
However, I'm torn as I feel we could afford to go a fair bit further. The field names are out right confusing and the logic is somewhat weird.
Are you intending on treating this as a first step Josef or was this as far as you intended going?
I think we've missed 20.05 now I'm afraid, but as we're moving lots of preferences over to this area perhaps it's time to focus on it more and further clean and improve both the db structure and logic early next release.?
I rebased and fixed patchset on top of current master There was a change in db structure that removed timestamp column and added updated_on and published_on columns, which is definitely great move... The main problem now is the weird logic on 'lang' column... it is also used for location and language combinations... I would like to change this and add the new 'location' column - this could simplify the logic of searching for new and add more flexibility (we could differentiate between languages in news for slips based on patrons preferred language in the future... for example) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #79 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111023&action=edit Bug 22544: Fix filtering by location on tools -> news management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target |rel_21_05_candidate --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Anyone interested in getting this into 21.05? I would see it as a very first step to rebuild the "news" thing, and make it what it is now: an editor (and translation tool) for different Koha content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24387 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111012|0 |1 is obsolete| | --- Comment #81 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115135&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111013|0 |1 is obsolete| | --- Comment #82 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115136&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111014|0 |1 is obsolete| | --- Comment #83 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115137&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111015|0 |1 is obsolete| | --- Comment #84 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115138&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111016|0 |1 is obsolete| | --- Comment #85 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115139&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111017|0 |1 is obsolete| | --- Comment #86 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115140&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111018|0 |1 is obsolete| | --- Comment #87 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115141&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111019|0 |1 is obsolete| | --- Comment #88 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115142&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111020|0 |1 is obsolete| | --- Comment #89 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115143&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111021|0 |1 is obsolete| | --- Comment #90 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115144&action=edit Bug 22544: Update to current codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111022|0 |1 is obsolete| | --- Comment #91 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115145&action=edit Bug 22544: Update search_for_display to be able to take more types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111023|0 |1 is obsolete| | --- Comment #92 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115146&action=edit Bug 22544: Fix filtering by location on tools -> news management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #93 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115218&action=edit Bug 22544: Fix NewsItem::author -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27451 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27451 [Bug 27451] Split opac_news.lang into two distinct fields for location and language -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #94 from Josef Moravec <josef.moravec@gmail.com> --- I added bug 27451 for tracking lang field split. I do think we could try to test and merge this, before we can continue on following reports... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Josef, trying to dive into this one here :) Could you please look at the comments before I continue testing? 1) QA Tools show one fail: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL valid_template The type and lang parameters combination is not valid 2) search_for_display Trying to understand the code, I stumbled a bit on the POD for this one: +=head3 search_for_display +You can limit the results by type(lang) and library by optional params I am not sure I follow you here (type(lang)?) - maybe you changed the signature of the method after this was written? + +library_id should be valid branchcode of defined library + +type is one of this: +- slip - for ISSUESLIP notice +- koha - for intranet I think "koha" is not good for intranet, I think useing "intranet" or "staff" instead, would be better. +- opac - for online catalogue +- OpacNavRight - Right column in the online catalogue +- OpacLoginInstructions +- OpacMainUserBlock +- OpacCustomSearch +- opacheader +- opaccredits +lang is language code - it is used only when type is opac or OpacNavRight For future enh: I think once we have an "all languages" selection we should enable lang for the staff interface as well (I filed bug 27459) I guess the other prefs hadn't been migrated yet when this comment was written. 3) koha-news.tt + Librarian interface (koha) I'd like to see the (koha) removed here again - both the OPAC and staff interface are Koha. My suggestion would be to change "Librarian interface" to "Staff interface" as this is the standard terminology we have agreed to. 4) html_helpers.inc I like the use of the patron-title.inc here - maybe we should use it in koha-news.tt too? I am not sure about the hide_patron_infos_if_needed=1. I think we should only apply the NewsAuthorDisplay here, the difference being that these are staff users, not library patrons. - <td>[% opac_new.author_title | html %] [% opac_new.author_firstname | html %] [% opac_new.author_surname | html %]</td> + <td>[% IF ( opac_new.author) %][% INCLUDE 'patron-title.inc' patron=opac_new.author hide_patron_infos_if_needed=1 %][% END %]</td> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Josef Moravec from comment #94)
I added bug 27451 for tracking lang field split. I do think we could try to test and merge this, before we can continue on following reports...
I am with you there, I think we could start with this one and will have an easier time adding more onto it later. @Martin - could you be a bit more specific about the things you were worrying about in comment#65? Would bug 27451 go in the right direction as a next step for you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #97 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Katrin Fischer from comment #95)
Hi Josef,
trying to dive into this one here :) Could you please look at the comments before I continue testing?
1) QA Tools show one fail:
FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL valid_template The type and lang parameters combination is not valid
I'll fix it
2) search_for_display
Trying to understand the code, I stumbled a bit on the POD for this one:
+=head3 search_for_display +You can limit the results by type(lang) and library by optional params
I am not sure I follow you here (type(lang)?) - maybe you changed the signature of the method after this was written?
I will polish the pod in follow-up patch
+ +library_id should be valid branchcode of defined library + +type is one of this: +- slip - for ISSUESLIP notice +- koha - for intranet
I think "koha" is not good for intranet, I think useing "intranet" or "staff" instead, would be better.
I will do that on (or after) bug 27451, 'koha' string is saved in BD, so it makes sense to change it in DB not only in UI (in it would be easier)
+- opac - for online catalogue +- OpacNavRight - Right column in the online catalogue +- OpacLoginInstructions +- OpacMainUserBlock +- OpacCustomSearch +- opacheader +- opaccredits
+lang is language code - it is used only when type is opac or OpacNavRight
For future enh: I think once we have an "all languages" selection we should enable lang for the staff interface as well (I filed bug 27459)
Absolutely agree
I guess the other prefs hadn't been migrated yet when this comment was written.
True, I'll fix pod
3) koha-news.tt
+ Librarian interface (koha)
I'd like to see the (koha) removed here again - both the OPAC and staff interface are Koha. My suggestion would be to change "Librarian interface" to "Staff interface" as this is the standard terminology we have agreed to.
Will do after/on bug 27451
4) html_helpers.inc
I like the use of the patron-title.inc here - maybe we should use it in koha-news.tt too? I am not sure about the hide_patron_infos_if_needed=1. I think we should only apply the NewsAuthorDisplay here, the difference being that these are staff users, not library patrons.
- <td>[% opac_new.author_title | html %] [% opac_new.author_firstname | html %] [% opac_new.author_surname | html %]</td> + <td>[% IF ( opac_new.author) %][% INCLUDE 'patron-title.inc' patron=opac_new.author hide_patron_infos_if_needed=1 %][% END %]</td>
Does make sense, I'll change it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #98 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115296&action=edit Bug 22544: Clarify documentation and change param 'type' to 'location' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #99 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115297&action=edit Bug 22544: Enhance exception description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #100 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115298&action=edit Bug 22544: Add default language value to KohaNews template plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #101 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 115299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115299&action=edit Bug 22544: Use template plugin for news author display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #102 from Josef Moravec <josef.moravec@gmail.com> --- I think it is ready for next round -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #103 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #33)
OPAC main page, I see: https://snipboard.io/CW4Bep.jpg
It does not appear without the patchset.
This is still valid. Worst, the header search is missing: https://snipboard.io/P4XI0L.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #104 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. cf last comment 2. - $_->{'timestamp'} = $_->{'newdate'}; you are loosing the ability to use "timestamp" in the the letter 3. + my $all = $n->unblessed_all_relateds; you should not use unblessed_all_relateds. Here we need the attributes of the news and the patron's info. We could built it easily before passing it to the letter. 4. + $search_params->{published_on} = { '<=' => \'NOW()' }; + $search_params->{-or} = [ expirationdate => { '>=' => \'NOW()' }, use dt_from_string instead of NOW 5. sub author { my ( $self ) = @_; - return Koha::Patron->_new_from_dbic($self->_result->borrowernumber); + my $author_rs = $self->_result->borrowernumber; + return unless $author_rs; + return Koha::Patron->_new_from_dbic( $author_rs ); } This is actually a bugfix that could go on its own bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27334 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|josef.moravec@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27714 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27714 [Bug 27714] Koha::NewsItem->author explodes if the author has been removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #105 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116933&action=edit Bug 22544: TT plugin should return hashref only if news exist It restore the header and fix the RSS feeds (see comment 103) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #106 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116934&action=edit Bug 22544: Fix OpacLoginInstructions Moved recently -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #107 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116935&action=edit Bug 22544: Restore newdate and timestamp for slip notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #108 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #104)
1. cf last comment
Done.
2. - $_->{'timestamp'} = $_->{'newdate'}; you are loosing the ability to use "timestamp" in the the letter
Done.
3. + my $all = $n->unblessed_all_relateds; you should not use unblessed_all_relateds. Here we need the attributes of the news and the patron's info. We could built it easily before passing it to the letter.
Done.
4. + $search_params->{published_on} = { '<=' => \'NOW()' }; + $search_params->{-or} = [ expirationdate => { '>=' => \'NOW()' },
use dt_from_string instead of NOW
Not done, this was not valid, we can use NOW.
5. sub author { my ( $self ) = @_; - return Koha::Patron->_new_from_dbic($self->_result->borrowernumber); + my $author_rs = $self->_result->borrowernumber; + return unless $author_rs; + return Koha::Patron->_new_from_dbic( $author_rs ); }
This is actually a bugfix that could go on its own bug report.
Done, see bug 27714. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115135|0 |1 is obsolete| | Attachment #115136|0 |1 is obsolete| | Attachment #115137|0 |1 is obsolete| | Attachment #115138|0 |1 is obsolete| | Attachment #115139|0 |1 is obsolete| | Attachment #115140|0 |1 is obsolete| | Attachment #115141|0 |1 is obsolete| | Attachment #115142|0 |1 is obsolete| | Attachment #115143|0 |1 is obsolete| | Attachment #115144|0 |1 is obsolete| | Attachment #115145|0 |1 is obsolete| | Attachment #115146|0 |1 is obsolete| | Attachment #115218|0 |1 is obsolete| | Attachment #115296|0 |1 is obsolete| | Attachment #115297|0 |1 is obsolete| | Attachment #115298|0 |1 is obsolete| | Attachment #115299|0 |1 is obsolete| | Attachment #116933|0 |1 is obsolete| | Attachment #116934|0 |1 is obsolete| | Attachment #116935|0 |1 is obsolete| | --- Comment #109 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117479&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #110 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117480&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #111 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117481&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #112 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117482&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #113 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117483&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #114 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117484&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #115 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117485&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #116 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117486&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #117 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117487&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #118 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117488&action=edit Bug 22544: Update to current codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #119 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117489&action=edit Bug 22544: Update search_for_display to be able to take more types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #120 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117490&action=edit Bug 22544: Fix filtering by location on tools -> news management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #121 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117491&action=edit Bug 22544: Clarify documentation and change param 'type' to 'location' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #122 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117492&action=edit Bug 22544: Enhance exception description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #123 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117493&action=edit Bug 22544: Add default language value to KohaNews template plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #124 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117494&action=edit Bug 22544: Use template plugin for news author display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #125 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117495&action=edit Bug 22544: TT plugin should return hashref only if news exist It restore the header and fix the RSS feeds (see comment 103) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #126 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117496&action=edit Bug 22544: Fix OpacLoginInstructions Moved recently -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #127 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117497&action=edit Bug 22544: Restore newdate and timestamp for slip notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry.. needs another rebase :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117479|0 |1 is obsolete| | Attachment #117480|0 |1 is obsolete| | Attachment #117481|0 |1 is obsolete| | Attachment #117482|0 |1 is obsolete| | Attachment #117483|0 |1 is obsolete| | Attachment #117484|0 |1 is obsolete| | Attachment #117485|0 |1 is obsolete| | Attachment #117486|0 |1 is obsolete| | Attachment #117487|0 |1 is obsolete| | Attachment #117488|0 |1 is obsolete| | Attachment #117489|0 |1 is obsolete| | Attachment #117490|0 |1 is obsolete| | Attachment #117491|0 |1 is obsolete| | Attachment #117492|0 |1 is obsolete| | Attachment #117493|0 |1 is obsolete| | Attachment #117494|0 |1 is obsolete| | Attachment #117495|0 |1 is obsolete| | Attachment #117496|0 |1 is obsolete| | Attachment #117497|0 |1 is obsolete| | --- Comment #129 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118054&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #130 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118055&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #131 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118056&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #132 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118057&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #133 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118058&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #134 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118059&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #135 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118060&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #136 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118061&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #137 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118062&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #138 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118063&action=edit Bug 22544: Update to current codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #139 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118064&action=edit Bug 22544: Update search_for_display to be able to take more types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #140 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118065&action=edit Bug 22544: Fix filtering by location on tools -> news management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #141 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118066&action=edit Bug 22544: Clarify documentation and change param 'type' to 'location' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #142 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118067&action=edit Bug 22544: Enhance exception description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #143 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118068&action=edit Bug 22544: Add default language value to KohaNews template plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #144 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118069&action=edit Bug 22544: Use template plugin for news author display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #145 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118070&action=edit Bug 22544: TT plugin should return hashref only if news exist It restore the header and fix the RSS feeds (see comment 103) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #146 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118071&action=edit Bug 22544: Fix OpacLoginInstructions Moved recently -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #147 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118072&action=edit Bug 22544: Restore newdate and timestamp for slip notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #148 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118073&action=edit Bug 22544: fix count call - to squash -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118054|0 |1 is obsolete| | --- Comment #149 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118087&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118055|0 |1 is obsolete| | --- Comment #150 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118088&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118056|0 |1 is obsolete| | --- Comment #151 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118089&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118057|0 |1 is obsolete| | --- Comment #152 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118090&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118058|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118091&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118059|0 |1 is obsolete| | --- Comment #154 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118092&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118060|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118093&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118061|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118094&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118062|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118095&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118063|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118096&action=edit Bug 22544: Update to current codebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118064|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118097&action=edit Bug 22544: Update search_for_display to be able to take more types Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118065|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118098&action=edit Bug 22544: Fix filtering by location on tools -> news management Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118066|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118099&action=edit Bug 22544: Clarify documentation and change param 'type' to 'location' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118067|0 |1 is obsolete| | --- Comment #162 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118100&action=edit Bug 22544: Enhance exception description Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118068|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118101&action=edit Bug 22544: Add default language value to KohaNews template plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118069|0 |1 is obsolete| | --- Comment #164 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118102&action=edit Bug 22544: Use template plugin for news author display Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118070|0 |1 is obsolete| | --- Comment #165 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118103&action=edit Bug 22544: TT plugin should return hashref only if news exist It restore the header and fix the RSS feeds (see comment 103) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118071|0 |1 is obsolete| | --- Comment #166 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118104&action=edit Bug 22544: Fix OpacLoginInstructions Moved recently Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118072|0 |1 is obsolete| | --- Comment #167 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118105&action=edit Bug 22544: Restore newdate and timestamp for slip notices Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118073|0 |1 is obsolete| | --- Comment #168 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118106&action=edit Bug 22544: fix count call - to squash Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #169 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This all appears to work as I expect.. I've tried a number of different blocks in a few different translations. I think it's a good start... signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Bug 22544 depends on bug 27714, which changed state. Bug 27714 Summary: Koha::NewsItem->author explodes if the author has been removed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27714 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24387 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24387 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Patch doesn't apply QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #170 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we please have a rebase? Apply? [(y)es, (n)o, (i)nteractive] < Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22544: Move get_opac_new to Koha namespace Applying: Bug 22544: Move get_opac_news to Koha namespace Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate, |rel_21_11_candidate |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118087|0 |1 is obsolete| | Attachment #118088|0 |1 is obsolete| | Attachment #118089|0 |1 is obsolete| | Attachment #118090|0 |1 is obsolete| | Attachment #118091|0 |1 is obsolete| | Attachment #118092|0 |1 is obsolete| | Attachment #118093|0 |1 is obsolete| | Attachment #118094|0 |1 is obsolete| | Attachment #118095|0 |1 is obsolete| | Attachment #118096|0 |1 is obsolete| | Attachment #118097|0 |1 is obsolete| | Attachment #118098|0 |1 is obsolete| | Attachment #118099|0 |1 is obsolete| | Attachment #118100|0 |1 is obsolete| | Attachment #118101|0 |1 is obsolete| | Attachment #118102|0 |1 is obsolete| | Attachment #118103|0 |1 is obsolete| | Attachment #118104|0 |1 is obsolete| | Attachment #118105|0 |1 is obsolete| | Attachment #118106|0 |1 is obsolete| | --- Comment #171 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120377&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #172 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120378&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #173 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120379&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #174 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120380&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #175 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120381&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #176 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120382&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #177 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120383&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #178 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120384&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #179 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120385&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #180 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120386&action=edit Bug 22544: Update to current codebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #181 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120387&action=edit Bug 22544: Update search_for_display to be able to take more types Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #182 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120388&action=edit Bug 22544: Fix filtering by location on tools -> news management Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #183 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120389&action=edit Bug 22544: Clarify documentation and change param 'type' to 'location' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #184 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120390&action=edit Bug 22544: Enhance exception description Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #185 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120391&action=edit Bug 22544: Add default language value to KohaNews template plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #186 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120392&action=edit Bug 22544: Use template plugin for news author display Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #187 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120393&action=edit Bug 22544: TT plugin should return hashref only if news exist It restore the header and fix the RSS feeds (see comment 103) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #188 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120394&action=edit Bug 22544: Fix OpacLoginInstructions Moved recently Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #189 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120395&action=edit Bug 22544: Restore newdate and timestamp for slip notices Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #190 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120396&action=edit Bug 22544: fix count call - to squash Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #191 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #192 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + <td data-order="[% opac_new.timestamp | html %]">[% opac_new.timestamp | $KohaDates %]</td> We removed timestamp from opac_news on bug 21066. Familiar author? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #193 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Subject: [PATCH 18/20] Bug 22544: Fix OpacLoginInstructions What does this patch actually fix ? - [% IF ( OpacLoginInstructions ) %] + [% IF OpacLoginInstructions %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #194 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + my $published_on_dt = output_pref({ dt => dt_from_string( $all->{pubished_on} ), dateonly => 1 }); Will amend the patch now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120377|0 |1 is obsolete| | --- Comment #195 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122396&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120378|0 |1 is obsolete| | --- Comment #196 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122397&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120379|0 |1 is obsolete| | --- Comment #197 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122398&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120380|0 |1 is obsolete| | --- Comment #198 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122399&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120381|0 |1 is obsolete| | --- Comment #199 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122400&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120382|0 |1 is obsolete| | --- Comment #200 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122401&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120383|0 |1 is obsolete| | --- Comment #201 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122402&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120384|0 |1 is obsolete| | --- Comment #202 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122403&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120385|0 |1 is obsolete| | --- Comment #203 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122404&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120386|0 |1 is obsolete| | --- Comment #204 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122405&action=edit Bug 22544: Update to current codebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120387|0 |1 is obsolete| | --- Comment #205 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122406&action=edit Bug 22544: Update search_for_display to be able to take more types Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120388|0 |1 is obsolete| | --- Comment #206 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122407&action=edit Bug 22544: Fix filtering by location on tools -> news management Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120389|0 |1 is obsolete| | --- Comment #207 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122408&action=edit Bug 22544: Clarify documentation and change param 'type' to 'location' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120390|0 |1 is obsolete| | --- Comment #208 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122409&action=edit Bug 22544: Enhance exception description Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120391|0 |1 is obsolete| | --- Comment #209 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122410&action=edit Bug 22544: Add default language value to KohaNews template plugin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120392|0 |1 is obsolete| | --- Comment #210 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122411&action=edit Bug 22544: Use template plugin for news author display Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120393|0 |1 is obsolete| | --- Comment #211 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122412&action=edit Bug 22544: TT plugin should return hashref only if news exist It restore the header and fix the RSS feeds (see comment 103) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120394|0 |1 is obsolete| | --- Comment #212 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122413&action=edit Bug 22544: Fix OpacLoginInstructions Moved recently Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120395|0 |1 is obsolete| | --- Comment #213 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122414&action=edit Bug 22544: Restore newdate and timestamp for slip notices Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Fixed typo pubished_on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120396|0 |1 is obsolete| | --- Comment #214 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122415&action=edit Bug 22544: fix count call - to squash Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #215 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Great work ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #216 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #193)
Subject: [PATCH 18/20] Bug 22544: Fix OpacLoginInstructions
What does this patch actually fix ?
- [% IF ( OpacLoginInstructions ) %] + [% IF OpacLoginInstructions %]
Nothing, it should be skipped. It has been fixed in the meanwhile by commit c45d15e231efd11d5f19f3a1186013daef19d300 Bug 28193: (follow-up) Correct OpacLoginInstructions in login modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #217 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Marcel. Quite happy to see this one move forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #218 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #219 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 [Bug 28698] News for all displays in all locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28717 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 [Bug 28717] NewsLog doesn't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Blocks|28717 | --- Comment #220 from Lucas Gass <lucas@bywatersolutions.com> --- I think this patch set may have inadvertently broke logging of news items which was add in Bug 26205. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 [Bug 28717] NewsLog doesn't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28717 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 [Bug 28717] NewsLog doesn't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718 [Bug 28718] Can't delete multiple news items at once -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12167 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28698 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 [Bug 28698] News for all displays in all locations -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org