[Bug 31773] New: Add 'page-section' to marc modification templates pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Bug ID: 31773 Summary: Add 'page-section' to marc modification templates pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, koha-bugs@lists.koha-community.org, lucas@bywatersolutions.com, oleonard@myacpl.org, testopia@bugs.koha-community.org Depends on: 30952 Blocks: 31757 We need the page-section div adding to the marc modification template page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141843&action=edit Bug 31773: Add page-section class to Manage staged MARC records page To test: 1. Apply patch 2. Have some MARC records and stage them for import. It will be nessesary to add more than 1 3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added. Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141843|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 141846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141846&action=edit Bug 31773: Add page-section class to Manage staged MARC records page To test: 1. Apply patch 2. Have some MARC records and stage them for import. It will be nessesary to add more than 1 3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added. Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 'page-section' to marc |Add 'page-section' to |modification templates |manage MARC import page |pages | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this changed a different page - adjusting description to manage marc import and refiled MARC modification templates as bug 31811. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141846|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141918&action=edit Bug 31773: Add page-section class to Manage staged MARC records page To test: 1. Apply patch 2. Have some MARC records and stage them for import. It will be nessesary to add more than 1 3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added. Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This does what it says, but also the table has a line on top of the header line, which is inconsistent with other pages... do we have a bug for those yet? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I spotted a table inconsistency like that somewhere else yesterday.. can't for the life of me remember where. I didn't submit a big for it yet, got distracted, but we probably should report such bugs as and when we spot them.. I imagine it's yet another small inconsistency with our markup which should be fixed rather than further targeted class rules being added. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #6)
I spotted a table inconsistency like that somewhere else yesterday.. can't for the life of me remember where. I didn't submit a big for it yet, got distracted, but we probably should report such bugs as and when we spot them.. I imagine it's yet another small inconsistency with our markup which should be fixed rather than further targeted class rules being added.
I've created an omnibus with a first linked bug for this one: Bug 31833 - [Omnibus] Fix table inconsistencies Bug 31834 - Inconsistent table formatting for list of MARC imports -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773 Bug 31773 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org