[Bug 39634] New: Other holdings table paging numbers not correct initially
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 Bug ID: 39634 Summary: Other holdings table paging numbers not correct initially Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Turn on SeparateHoldings 2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL. 3. Logged in as CPL go to the record in normal view. 4. Click on the 'Other holdings' tab, which should have 50+ items 5. Notice you only see the number 1 in the paging tools. 6. Click 'Next', the paging numbers correct themselves. This problem only happens when you initially tab over to the other holdings table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180945&action=edit Bug 39634: Correct paging number on initial load of other_holdings table To test: 1. Turn on SeparateHoldings 2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL. 3. Logged in as CPL go to the record in normal view. 4. Click on the 'Other holdings' tab, which should have 50+ items 5. Notice you only see the number 1 in the paging tools. 6. Click 'Next', the paging numbers correct themselves. 7. APPLY PATCH 8. Try again, this time the paging numbers should be correct initially. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180945|0 |1 is obsolete| | --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180946&action=edit Bug 39634: Correct paging number on initial load of other_holdings table To test: 1. Turn on SeparateHoldings 2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL. 3. Logged in as CPL go to the record in normal view. 4. Click on the 'Other holdings' tab, which should have 50+ items 5. Notice you only see the number 1 in the paging tools. 6. Click 'Next', the paging numbers correct themselves. 7. APPLY PATCH 8. Try again, this time the paging numbers should be correct initially. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 --- Comment #3 from George Williams (NEKLS) <george@nekls.org> --- I tried to sign off at https://staff-tabs.sandboxes.ptfs-europe.co.uk but after I applied the patch there was no content on both #holdings_table and #otherholdings_table. I tried restarting services but the tables wouldn't load at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180946|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 180990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180990&action=edit Bug 39634: Correct paging number on initial load of other_holdings table To test: 1. Turn on SeparateHoldings 2. Have an item with many items at another branch, so 'Other holdings' table is large. I added 50 items to FPL. 3. Logged in as CPL go to the record in normal view. 4. Click on the 'Other holdings' tab, which should have 50+ items 5. Notice you only see the number 1 in the paging tools. 6. Click 'Next', the paging numbers correct themselves. 7. APPLY PATCH 8. Try again, this time the paging numbers should be correct initially. Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from George Williams (NEKLS) <george@nekls.org> --- Worked on second try. Thanks for the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Not sure why but I am seeing the damaged_on column, I am expecting it to be hidden by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Hum, cannot we achieve that without a redraw? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- I don't understand why this is happening, can you provide more detail, Lucas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- I downloaded the new version of DataTables: https://datatables.net/download/#dt/jszip-3.10.1/pdfmake-0.2.7/dt-2.1.8/b-3.... And the problem is fixed. But we have local customization, so it's not that easy to update. The problem is either coming from our version of DataTables, or our local customization. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39634 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9)
I downloaded the new version of DataTables: https://datatables.net/download/#dt/jszip-3.10.1/pdfmake-0.2.7/dt-2.1.8/b-3. 1.2/b-colvis-3.1.2/b-html5-3.1.2/b-print-3.1.2/fh-4.0.1/r-3.0.3/rg-1.5.0/rr- 1.5.0
And the problem is fixed.
But we have local customization, so it's not that easy to update.
The problem is either coming from our version of DataTables, or our local customization.
Closing this based on Jonathan's comment. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org