[Bug 6769] New: Getting rid of some RIS format export errors and warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 Bug #: 6769 Summary: Getting rid of some RIS format export errors and warnings Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: minor Priority: PATCH-Sent Component: OPAC AssignedTo: m.de.rooy@rijksmuseum.nl ReportedBy: m.de.rooy@rijksmuseum.nl QAContact: koha-bugs@lists.koha-community.org Removing unnecessary warnings like below. Some were based on errors in the script. Others are removed by adding debug flag and disabling debugging mode by default. [Wed Aug 24 13:33:01 2011] [error] [client 66.249.72.167] [Wed Aug 24 13:33:01 2011] opac-export.pl: no type found - assume BOOK at /usr/share/koha/prodclone/C4/Ris.pm line 355. [Wed Aug 24 13:33:01 2011] [error] [client 66.249.72.167] [Wed Aug 24 13:33:01 2011] opac-export.pl: empty series title field at /usr/share/koha/prodclone/C4/Ris.pm line 521. [Wed Aug 24 13:33:01 2011] [error] [client 66.249.72.167] [Wed Aug 24 13:33:01 2011] opac-export.pl: no isbn found at /usr/share/koha/prodclone/C4/Ris.pm line 552. [Wed Aug 24 13:33:01 2011] [error] [client 66.249.72.167] [Wed Aug 24 13:33:01 2011] opac-export.pl: no issn found at /usr/share/koha/prodclone/C4/Ris.pm line 574. [Wed Aug 24 13:33:01 2011] [error] [client 66.249.72.167] [Wed Aug 24 13:33:01 2011] opac-export.pl: no LOC call number found at /usr/share/koha/prodclone/C4/Ris.pm line 596. [Wed Aug 24 15:52:36 2011] [error] [client 82.173.53.17] [Wed Aug 24 15:52:36 2011] opac-export.pl: no Dewey number found at /usr/share/koha/prodclone/C4/Ris.pm line 611. [Wed Aug 24 15:44:51 2011] [error] [client 82.173.53.17] [Wed Aug 24 15:44:51 2011] opac-export.pl: name >>Cantor, Mircea<< in direct order - leave as is at /usr/share/koha/prodclone/C4/Ris.pm line 382. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-24 14:24:30 UTC --- Created attachment 5115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5115 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-24 14:26:59 UTC --- Test it with: http://yourserver.com/cgi-bin/koha/opac-export.pl?bib=yourbibnumber&format=ris&op=export Replace your server and biblionumber! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-24 14:36:53 UTC --- Forgot to mention: Adding CRs (carriage returns) before LF (linefeed) for Windows users, downloading this format. Assume that CR does not hurt the Linux downloader. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-08-24 14:52:28 UTC --- I'm curious whether you're getting valid RIS exports? The patch seems to work--I'm not getting errors in the log after applying it. But with our without the patch my RIS exports are almost completely empty: TY - BOOK ER - -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-24 14:54:23 UTC --- I have something like: TY - BOOK AU - Manca, Angelo TI - Vermeer: pingo ergo sum T2 - Collezione MercatorSN - 8872552575 PY - 2005/// CY - Firenze PB - Firenze Atheneum KW - schilderijen KW - Vermeer, Johannes, KW - geometrie en kunst ER - -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-24 14:59:57 UTC --- Will send a revision for the missing newline after T2 (as in the above example). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5115|0 |1 is obsolete| | --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-24 15:06:06 UTC --- Created attachment 5116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5116 Revised patch Fixing two missing newlines also.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6822 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5116|0 |1 is obsolete| | --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> 2011-08-30 18:53:59 UTC --- Created attachment 5231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5231 signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> 2011-08-30 19:20:20 UTC --- Also received a user report to the effect that RIS output with this patch installed is being successfully parsed by Reference Manager. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5780 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 14:21:08 UTC --- Created attachment 5740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5740 6769 Getting rid of some RIS errors/warnings Removing unnecessary warnings. Some were based on errors in the script. Others are removed by adding debug flag and disabling debugging mode by default. Adding carriage returns for Windows users, assuming that it does not hurt the Linux users. (Perhaps a future option?) Test it with: http://yourserver.com/cgi-bin/koha/opac-export.pl?bib=yourbibnumber&format=ris&op=export [replace server and biblionumber] Revision of Aug 24: Fixed two missing newlines too. Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> (removed comment "240811 marcelr during QA" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5231|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 14:22:59 UTC --- QA comment * description & test plan clear * cosmetic (remove warnings) patch * I just removed a "240811 marcelr", that is something we should not have in code, as it's in git repo marking passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-07 01:03:03 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6769 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org