[Bug 15207] New: Error on upgrade from 3.20.5 to 3.22 beta
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Bug ID: 15207 Summary: Error on upgrade from 3.20.5 to 3.22 beta Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: z.tajoli@cineca.it QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #1 from Zeno Tajoli <z.tajoli@cineca.it> --- Hi, I try to do an update from 3.20.5 to master (3.22 beta at db level). I have done a standard marc21 english install using all sql files, mandatory and optional. I receive two errors: updatedatabase.pl: DBD::mysql::db do failed: Can't create table 'koha.#sql-3a4_7f' (errno: 121) [for Statement " updatedatabase.pl: ALTER IGNORE TABLE course_reserves updatedatabase.pl: add CONSTRAINT course_reserves_ibfk_2 updatedatabase.pl: FOREIGN KEY (ci_id) REFERENCES course_items (ci_id) updatedatabase.pl: ON DELETE CASCADE ON UPDATE CASCADE updatedatabase.pl: "] at /production/koha/install/bug14960/installer/data/mysql/updatedatabase.pl line 10804. updatedatabase.pl: DBD::mysql::db do failed: Duplicate entry '1-self_checkout' for key 'PRIMARY' [for Statement " updatedatabase.pl: INSERT INTO permissions (module_bit, code, description) updatedatabase.pl: VALUES (1, 'self_checkout', 'Perform self checkout at the OPAC. It should be used for the patron matching the AutoSelfCheckID') updatedatabase.pl: "] at /production/koha/install/bug14960/installer/data/mysql/updatedatabase.pl line 10871. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #2 from Zeno Tajoli <z.tajoli@cineca.it> --- The first problem (about change in table course_reserves, bug 14205) is not a real problem for y test situation. Course Reserve is not active and the new costraint, course_reserves_ibfk_2, it was added without problems -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #3 from Zeno Tajoli <z.tajoli@cineca.it> --- The second error is present because the update 3.21.00.027 starts so: dbh->do(q| INSERT INTO permissions (module_bit, code, description) VALUES (1, 'self_checkout', 'Perform self checkout at the OPAC. It should be used for the patron matching the AutoSelfCheckID') |); But in 3.20.5 in file installer/data/mysql/en/mandatory/userpermissions.sql I see: INSERT INTO permissions (module_bit, code, description) VALUES [...] ( 1, 'self_checkout', 'Perform self checkout at the OPAC. It should be used for the patron matching the AutoSelfCheckID'), So in 3.20.x the code 'self_checkout' could be present. I don't know if it is better to 'INSERT IGNORE' or other statement. A discussion on the topic here: http://stackoverflow.com/questions/548541/insert-ignore-vs-insert-on-duplica... Tecnaly speaking also this error is not blocking, the code 'self_checkout' is present in the table permissions with a correct value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |z.tajoli@cineca.it |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #4 from Zeno Tajoli <z.tajoli@cineca.it> --- About the first error: The motivation of the error is that in 3.20.5 the second constraint on the table course_reserves is present in its version onf kohastructure.sql: `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE in http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mys... We can see here: http://stackoverflow.com/questions/12623651/error-error-1005-cant-create-tab... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #5 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 44960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44960&action=edit patch for fix update -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gmcharlt@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 44970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44970&action=edit Warnings after patch Got rid of second error, but just pushed the first down a few lines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 44960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44960 patch for fix update Review of attachment 44960: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15207&attachment=44960) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +10816,5 @@
+ add CONSTRAINT course_reserves_ibfk_2 + FOREIGN KEY (ci_id) REFERENCES course_items (ci_id) + ON DELETE CASCADE ON UPDATE CASCADE + }); + };
What if someone created it incorrectly? Why not leave the do logic as it was, but insert a delete foreign key if the count>0? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #8 from Zeno Tajoli <z.tajoli@cineca.it> --- (In reply to Nick Clemens from comment #6)
Created attachment 44970 [details] Warnings after patch
Got rid of second error, but just pushed the first down a few lines
Nick, can you try to understand why in your set up those instructions: my $count_course_reserves_ibfk_2 = $dbh->selectrow_arrayref(q| + SELECT COUNT(*) + FROM information_schema.table_constraints + WHERE table_schema = schema() + AND table_name = 'course_reserves' + AND CONSTRAINT_NAME = 'course_reserves_ibfk_2' + |); did not retreive the presence of FK "course_reserves_ibfk_2" ? Because I don't have idea how to repoduce your situation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Sure, my test plan on kohadevbox: 1 - Checkout 3.20.x 2 - drop db, create db, 3 - run web installer (upgrade) 4 - checkout master 5 - run webinstaller 6 - got errors described 7 - checkout 3.20.x 8 - drop db, create db 9 - run web installer 10- - checkout master 11 - apply patch 12 - run websintaller (upgrade) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #10 from Zeno Tajoli <z.tajoli@cineca.it> --- Nick, can you tell us your version of MySQL ? Or do you use MariaBD ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44960|0 |1 is obsolete| | --- Comment #11 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 45021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45021&action=edit New version of patch for fix update -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- On Debian Jessie: mysql Ver 14.14 Distrib 5.5.46, for debian-linux-gnu (x86_64) using readline 6.3 Perl 5.020002 Server version: Apache/2.4.10 (Debian) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #13 from Zeno Tajoli <z.tajoli@cineca.it> --- Exactly my enviroment (Debian, MySQL and Apache versions). Try the new version !! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45021|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 45029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45029&action=edit [SIGNED-OFF] Bug 15207: To not show errors on update from 3.20.x to 3.22.x Two update of db, 3.21.00.027 and 3.21.00.022, are partialy done also on 3.20.x. This patch modify updatedatabase.pl to cover those partial changes in db done in 3.20.x To test: 1)Install a 3.20.4 or more 2)Dump the db 2)Update to master and see the error 3)Installe the patch 4)Reload the db 5)Update to master and see no more error 6)Check the coerence at sql structure level More check: a)Reload the db b)Change db to delete the effect of those two commit in 3.20: bug 14205: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=c158f9e27e9e2835... bug 14298: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=e0c926e0104e3fb7... c)Redone update d)With patch no errors http://bugs.koha-community.org/show_bug.cgi?id=15207 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Update now Ok finish with 'Everything went OK, update done.' No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 45032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45032&action=edit Bug 15207: (followup) add collate info to sound alerts table Only missing bit is some collate info in sound alerts table. To test: 1) With previous patch applied, do an upgrade (3.20 -> 3.22) 2) Dump database structure (mysqldump -d) save 3) Do a clean install (3.22), dump db structure, compare (diff) Note collate info missing in sound alerts table 4) With patch applied do again an upgrade, dump db struct, compare again Now sound alerts table have collate info Don't know if this is relevant. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think it doesn't work for me. I created a brand new database on a branch running 3.20.5. Then I switched back to master, applied the patches and ran the database update. This is the result: [Fri Nov 20 19:22:16 2015] updatedatabase.pl: DBD::mysql::db do failed: Can't create table 'koha.#sql-5b5_3f2' (errno: 121) [for Statement " [Fri Nov 20 19:22:16 2015] updatedatabase.pl: ALTER IGNORE TABLE course_reserves [Fri Nov 20 19:22:16 2015] updatedatabase.pl: add CONSTRAINT course_reserves_ibfk_2 [Fri Nov 20 19:22:16 2015] updatedatabase.pl: FOREIGN KEY (ci_id) REFERENCES course_items (ci_id) [Fri Nov 20 19:22:16 2015] updatedatabase.pl: ON DELETE CASCADE ON UPDATE CASCADE [Fri Nov 20 19:22:16 2015] updatedatabase.pl: "] at /home/katrin/kohaclone/installer/data/mysql/updatedatabase.pl line 10814. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is my 'before' course_reserves table copied from the mysqldump: DROP TABLE IF EXISTS `course_reserves`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `course_reserves` ( `cr_id` int(11) NOT NULL AUTO_INCREMENT, `course_id` int(11) NOT NULL, `ci_id` int(11) NOT NULL, `staff_note` mediumtext COLLATE utf8_unicode_ci, `public_note` mediumtext COLLATE utf8_unicode_ci, `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, PRIMARY KEY (`cr_id`), UNIQUE KEY `pseudo_key` (`course_id`,`ci_id`), KEY `course_id` (`course_id`), KEY `course_reserves_ibfk_2` (`ci_id`), CONSTRAINT `course_reserves_ibfk_1` FOREIGN KEY (`course_id`) REFERENCES `courses` (`course_id`), CONSTRAINT `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could something like this here work? 4234 sub stocknumber_checker { #code reused later on 4235 my @row; 4236 #drop the obsolete itemSStocknumber idx if it exists 4237 @row = $dbh->selectrow_array("SHOW INDEXES FROM items WHERE key_name='itemsstocknumberidx'"); 4238 $dbh->do("ALTER TABLE `items` DROP INDEX `itemsstocknumberidx`;") if @row; 4239 4240 #check itemstocknumber idx; remove it if it is unique 4241 @row = $dbh->selectrow_array("SHOW INDEXES FROM items WHERE key_name='itemstocknumberidx' AND non_unique=0"); 4242 $dbh->do("ALTER TABLE `items` DROP INDEX `itemstocknumberidx`;") if @row; 4243 4244 #add itemstocknumber index non-unique IF it still not exists 4245 @row = $dbh->selectrow_array("SHOW INDEXES FROM items WHERE key_name='itemstocknumberidx'"); 4246 $dbh->do("ALTER TABLE items ADD INDEX itemstocknumberidx (stocknumber);") unless @row; 4247 } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Trying it out now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45066&action=edit Bug 15207: Follow-up - change check for existing index -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have attached a follow-up - with this patch no errors show for me. But can someone please double-check? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45029|0 |1 is obsolete| | Attachment #45032|0 |1 is obsolete| | Attachment #45066|0 |1 is obsolete| | --- Comment #22 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 45067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45067&action=edit Not show errors on update from 3.20 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #23 from Zeno Tajoli <z.tajoli@cineca.it> --- Hi to all, I cherry-pick the code of Katrin and Bernardo and I write a new version of the patch. Now the check is based on presence of index, not on FK in the INFORMATION_SCHEMA of mysql. So probalby it is more robust. New cycle of sign-off/QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Zeno, thx for your work on this. We usually try to keep authorship of code. The other option here would be to sign off the 2 follow-ups from Bernardo and me - and move this to signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #25 from Zeno Tajoli <z.tajoli@cineca.it> --- Hi Katrin, Infact I'outsite my standard pc and so I need to rewrite the patch from scratch. I think the second option is the more easy to do. Clearly we need that others person do sign-off and QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45067|0 |1 is obsolete| | --- Comment #26 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 45068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45068&action=edit Not show errors on update from 3.20 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #27 from Zeno Tajoli <z.tajoli@cineca.it> --- I upload a new version of the patch more correct about authorship of the code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd be happier with the 3 separate patches from before - I had tested them all together with my changes and they seemed to work really well now. I also think no additional changes are included in the new unified patch - so there should be no difference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- No problem for my part about authorship, we need to solve this :) What we do: 3 patches or one? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #30 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 45113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45113&action=edit To not show errors on update from 3.20.x to 3.22.x Two update of db, 3.21.00.027 and 3.21.00.022, are partialy done also on 3.20.x. This patch modify updatedatabase.pl to cover those partial changes in db done in 3.20.x To test: 1)Install a 3.20.4 or more 2)Dump the db 2)Update to master and see the error 3)Installe the patch 4)Reload the db 5)Update to master and see no more error 6)Check the coerence at sql structure level More check: a)Reload the db b)Change db to delete the effect of those two commit in 3.20: bug 14205: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=c158f9e27e9e2835... bug 14298: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=e0c926e0104e3fb7... c)Redone update d)With patch no errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Added COLLATE to audio_alerts Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Insert check based on INDEX instead of FK http://bugs.koha-community.org/show_bug.cgi?id=15207 Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Bernardo and Brendan, I will try to retest this tomorrow for QA - but not sad at all if someone beats me to it :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|z.tajoli@cineca.it |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |ASSIGNED --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I will provide a counter patch to simplify this change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11431 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Follow-up added on bug 11431 comment 163. There is no need to specify the collate for the columns. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14298 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Zeno Tajoli from comment #3)
The second error is present because the update 3.21.00.027 starts so:
dbh->do(q| INSERT INTO permissions (module_bit, code, description) VALUES (1, 'self_checkout', 'Perform self checkout at the OPAC. It should be used for the patron matching the AutoSelfCheckID') |);
But in 3.20.5 in file installer/data/mysql/en/mandatory/userpermissions.sql I see:
INSERT INTO permissions (module_bit, code, description) VALUES [...] ( 1, 'self_checkout', 'Perform self checkout at the OPAC. It should be used for the patron matching the AutoSelfCheckID'),
So in 3.20.x the code 'self_checkout' could be present.
Follow-up added on bug 14298. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45068|0 |1 is obsolete| | Attachment #45113|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45138&action=edit Bug 15207: Avoid warnings when adding constraint course_reserves_ibfk_2 Bug 14205 added a new foreign key on the course_reserve table. As this dbrev has been backported to the stable version (3.20.x), the next dbrev should take care of this existing constraint to avoid warnings. Test plan: 1/ replace the modified dbrev with 3.21.00.XXX to make sure it will be executed 2/ Make sure you have the KEY and the FK on the course_reserves table: sql> alter table course_reserves add CONSTRAINT `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE; sql> alter table course_reserves ADD KEY `course_reserves_ibfk_2` (`ci_id`); 3/ SHOW CREATE TABLE course_reserves should show that the table is not in sync with the kohastructure.sql file 4/ Execute the dbrev 5/ SHOW CREATE TABLE course_reserves should show that the table is in sync with the kohastructure.sql file Repeat 4 and 5, confirm you don't get any error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14205 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 [Bug 14205] Deleting an Item/Record does not remove link to course reserve -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45138|0 |1 is obsolete| | --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 45140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45140&action=edit Bug 15207: Avoid warnings when adding constraint course_reserves_ibfk_2 Bug 14205 added a new foreign key on the course_reserve table. As this dbrev has been backported to the stable version (3.20.x), the next dbrev should take care of this existing constraint to avoid warnings. Test plan: 1/ replace the modified dbrev with 3.21.00.XXX to make sure it will be executed 2/ Make sure you have the KEY and the FK on the course_reserves table: sql> alter table course_reserves add CONSTRAINT `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE; sql> alter table course_reserves ADD KEY `course_reserves_ibfk_2` (`ci_id`); 3/ SHOW CREATE TABLE course_reserves should show that the table is not in sync with the kohastructure.sql file 4/ Execute the dbrev 5/ SHOW CREATE TABLE course_reserves should show that the table is in sync with the kohastructure.sql file Repeat 4 and 5, confirm you don't get any error. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45140|0 |1 is obsolete| | --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45142&action=edit [PASSED QA] Bug 15207: Avoid warnings when adding constraint course_reserves_ibfk_2 Bug 14205 added a new foreign key on the course_reserve table. As this dbrev has been backported to the stable version (3.20.x), the next dbrev should take care of this existing constraint to avoid warnings. Test plan: 1/ replace the modified dbrev with 3.21.00.XXX to make sure it will be executed 2/ Make sure you have the KEY and the FK on the course_reserves table: sql> alter table course_reserves add CONSTRAINT `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE; sql> alter table course_reserves ADD KEY `course_reserves_ibfk_2` (`ci_id`); 3/ SHOW CREATE TABLE course_reserves should show that the table is not in sync with the kohastructure.sql file 4/ Execute the dbrev 5/ SHOW CREATE TABLE course_reserves should show that the table is in sync with the kohastructure.sql file Repeat 4 and 5, confirm you don't get any error. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Zeno, Bernardo, Katrin and Jonathan :-D -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org