[Bug 41360] New: Transport cost matrix assumes all transfers are disabled upon first use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Bug ID: 41360 Summary: Transport cost matrix assumes all transfers are disabled upon first use Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com On a system not using transport cost matrix enable the preference UseTransportCostMatrix (if your test system has a matrix setup, back it up then DELETE FROM transport_cost;) and then go to Administration->Transport Cost Matrix (almost) All squares are red Click on one, enable and enter a cost Save In the DB: SELECT * FROM transport_cost; Note that all transfers are now forbidden. It should be possible to set the matrix without defaulting to no transfers allowed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 190121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190121&action=edit Bug 41360: Add toolbar of buttons for batch modifications to transport cost matrix We can add a toolbar of buttons to A) batch enable all cells B) batch populate empty cells with a value C) batch disable empty cells Test plan: 1) Apply this patch 2) Visit the TCM editor 3) Try out the 3 new buttons, verify they behave correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I've not used the transport cost matrix before, so am reluctant to sign off - it appears to work as expected: the new actions work, I can add values, and can also edit individually. One thing I noted is that there is the text above the table saying "Red cells signify no transfer allowed.", which is still correct. However, the transfer for the same library (for example, Centerville to Centerville) is either white or grey, where previously it was red. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Enable the UseTransportCostMatrix system preference. 2. Go to Administration > Patrons and circulation > Transport cost matrix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 --- Comment #4 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 190204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190204&action=edit Pre-patch editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190204|Screenshot 2025-12-05 at |Screenshot 2025-12-05 at filename|7.15.05â¯AM.png |7.15.05â¯AM.png Attachment #190204|Pre-patch editor |Post-patch editor description| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 190205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190205&action=edit Pre-patch editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- (In reply to David Nind from comment #2)
I've not used the transport cost matrix before, so am reluctant to sign off - it appears to work as expected: the new actions work, I can add values, and can also edit individually.
One thing I noted is that there is the text above the table saying "Red cells signify no transfer allowed.", which is still correct.
However, the transfer for the same library (for example, Centerville to Centerville) is either white or grey, where previously it was red.
I'm not sure I'm seeing what you are seeing. Can you have a look at the two screenshots I've added and let me know if I'm looking in the wrong place? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190121|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 190259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190259&action=edit Bug 41360: Add toolbar of buttons for batch modifications to transport cost matrix We can add a toolbar of buttons to A) batch enable all cells B) batch populate empty cells with a value C) batch disable empty cells Test plan: 1) Apply this patch 2) Visit the TCM editor 3) Try out the 3 new buttons, verify they behave correctly Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Kyle M Hall (khall) from comment #6)
(In reply to David Nind from comment #2)
I've not used the transport cost matrix before, so am reluctant to sign off - it appears to work as expected: the new actions work, I can add values, and can also edit individually.
One thing I noted is that there is the text above the table saying "Red cells signify no transfer allowed.", which is still correct.
However, the transfer for the same library (for example, Centerville to Centerville) is either white or grey, where previously it was red.
I'm not sure I'm seeing what you are seeing. Can you have a look at the two screenshots I've added and let me know if I'm looking in the wrong place?
Thanks!
I'm not sure now what I was thinking/seeing - I don't see it now, so must have been imaging it! Apologies for creating extra work 8-(... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds three new toolbar release notes| |buttons to make batch | |modifications to the | |transport cost matrix table | |easier (when | |UseTransportCostMatrix is | |enabeld): | | | |* Enable all cells | |* Disable empty cells | |* Populate empty cells, | |with selectable values from | |0 to 100 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190259|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 193514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193514&action=edit Bug 41360: Add toolbar of buttons for batch modifications to transport cost matrix We can add a toolbar of buttons to A) batch enable all cells B) batch populate empty cells with a value C) batch disable empty cells Test plan: 1) Apply this patch 2) Visit the TCM editor 3) Try out the 3 new buttons, verify they behave correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 --- Comment #11 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.04 |26.05.00,25.11.04,25.05.11 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Correction: this was pushed for 25.05.11. --LE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41360 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to oldstable |Needs documenting --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Enhancement not backported to 24.11 LTS -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org