[Bug 20977] New: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Bug ID: 20977 Summary: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The naming mismatch can cause javascript errors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76238&action=edit Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc The naming mismatch can cause javascript errors. Test Plan: 1) Confirm the string vars used in catalog.js match the ones in catalog-strings.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17893 Status|NEW |Needs Signoff Component|Architecture, internals, |Templates |and plumbing | CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 [Bug 17893] Move JavaScript to the footer on staff client catalog pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 [Bug 20979] Error message when deleting bib attached to order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76238|0 |1 is obsolete| | --- Comment #2 from Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> --- Created attachment 76582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76582&action=edit Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc The naming mismatch can cause javascript errors. Test Plan: 1) Confirm the string vars used in catalog.js match the ones in catalog-strings.inc Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-luc.lapointe@inLibro | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76582|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76607&action=edit Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc The naming mismatch can cause javascript errors. Test Plan: 1) Confirm the string vars used in catalog.js match the ones in catalog-strings.inc Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 17893 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #7 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Fridolin SOMERS from comment #6)
Depends on Bug 17893 not in 17.11.x
This *is* broken in 17.11.x, do we need a separate patch for that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Barton Chittenden from comment #7)
(In reply to Fridolin SOMERS from comment #6)
Depends on Bug 17893 not in 17.11.x
This *is* broken in 17.11.x, do we need a separate patch for that?
Ok sorry, I will try to rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #6)
Depends on Bug 17893 not in 17.11.x
Ahhhh my mistake, Bug 17893 is in 17.11.x. Patch pushed to 17.11.x for v17.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 17893 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org