https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 --- Comment #1 from jwayway@hotmail.com --- Created attachment 70599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70599&action=edit Bug-19960: FIXME $available is not needed Test plan: 1. Open opac-discharge.pl 2. Check that $available doesn't exist -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70599|0 |1 is obsolete| | --- Comment #2 from Maksim Sen <maksim.sen@inlibro.com> --- Created attachment 71864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71864&action=edit Bug-19960: FIXME $available is not needed Test plan: 1. Open opac-discharge.pl 2. Check that $available doesn't exist https://bugs.koha-community.org/show_bug.cgi?id=19990 Signed-off-by: Maksim Sen <maksim@inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I am seeing this in the template: [% ELSIF available %] <a href="/cgi-bin/koha/opac-discharge.pl?op=get">Get your discharge</a></li> I think available is in use or patch is incomplete. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #4)

I see $available means discharge is validated by a librarian in staff interface, different from $pending.

Oh I think I get it now : FIXME means 'available' template param could directly be Koha::Patron::Discharge::is_discharged({borrowernumber => $loggedinuser}). Because Koha::Patron::Discharge::is_discharged() looks if discharge is validated. Is it correct ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is a duplicate of another bug in PQA (please reset if I am wrong: Bug 20953 - Discharge can be requested several times on OPAC

Patch reoganised the code so that the following FIXME is obsolete : 'FIXME looks like $available is not needed' Patch also replaces 'op' arg test to also check undef : input->param("op") // ''

*** This bug has been marked as a duplicate of bug 20953 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.