[Bug 9648] New: Replace YUI buttons on authorized values administration page with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9648 Bug ID: 9648 Summary: Replace YUI buttons on authorized values administration page with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/authorised_values.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The toolbar buttons on the authorized values administration page are constructed using YUI. They should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9648 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15432&action=edit Bug 9648 - Replace YUI buttons on authorized values administration page with Bootstrap This patch converts the toolbar on the authorised values administration page to to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the authorised values administration page and confirm that the "New authorized value..." and "New cateogry" buttons look correct and works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9648 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15432|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15433&action=edit [SIGNED-OFF] Bug 9648 - Replace YUI buttons on authorized values administration page with Bootstrap This patch converts the toolbar on the authorised values administration page to to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the authorised values administration page and confirm that the "New authorized value..." and "New cateogry" buttons look correct and works correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Both buttons works and look correctly. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9648 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15433|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15473&action=edit [PASSED QA] Bug 9648 - Replace YUI buttons on authorized values administration page with Bootstrap This patch converts the toolbar on the authorised values administration page to to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the authorised values administration page and confirm that the "New authorized value..." and "New cateogry" buttons look correct and works correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Both buttons works and look correctly. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder, if the buttons should be showing the plus icon? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9648 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org