[Bug 9616] New: Replace YUI menu on patrons page with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Bug ID: 9616 Summary: Replace YUI menu on patrons page with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/members-home.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The "new patron" menu on the patrons page is constructed using YUI. It should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15362&action=edit Bug 9616 - Replace YUI menu on patrons page with Bootstrap This patch converts the toolbar include file used to create the "New patron" menu to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page which uses patron-toolbar.inc (members-home.pl or circulation.pl after searching for a non-existent patron). Button and menu should look correct and work correctly with the AddPatronLists preference in both states. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Bug 9420 has been pushed to master. Why this patch removes conflicting lines from that bug? -<<<<<<< HEAD ... -======= ... ->>>>>>> Bug 9420 [Revised] Work on Bootstrap for Koha -<<<<<<< HEAD ... ->>>>>>> Bug 9420 [Revised] Work on Bootstrap for Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15368&action=edit Bug 9616 - Replace YUI menu on patrons page with Bootstrap This patch converts the toolbar include file used to create the "New patron" menu to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page which uses patron-toolbar.inc (members-home.pl or circulation.pl after searching for a non-existent patron). Button and menu should look correct and work correctly with the AddPatronLists preference in both states. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Sorry for the bad merge errors in the previous patch! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15368|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15370&action=edit Bug 9616 - Replace YUI menu on patrons page with Bootstrap This patch converts the toolbar include file used to create the "New patron" menu to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page which uses patron-toolbar.inc (members-home.pl or circulation.pl after searching for a non-existent patron). Button and menu should look correct and work correctly with the AddPatronLists preference in both states. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Looks very good! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15370|Bug 9616 - Replace YUI menu |[SIGNED-OFF] Bug 9616 - description|on patrons page with |Replace YUI menu on patrons |Bootstrap |page with Bootstrap -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15370|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15452&action=edit [PASSED QA] Bug 9616 - Replace YUI menu on patrons page with Bootstrap This patch converts the toolbar include file used to create the "New patron" menu to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page which uses patron-toolbar.inc (members-home.pl or circulation.pl after searching for a non-existent patron). Button and menu should look correct and work correctly with the AddPatronLists preference in both states. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Looks very good! Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9616 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org