https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124717&action=edit Bug 28986: Remove (All) notation to correctly select rule for editing This patch updates the JS comparison code to remove the '(All)' hint before comparing to the current value To test: 1 - Go to Administration -> Item types 2 - Edit a type to have a parent of another type 3 - Go to Administration -> Circulation and fines rules 4 - Add a rule for all categories for the child itemtype 5 - Add a rule for all categories for the parent itemtype 6 - Click edit on child type, note itemtype dropdown in editor correctly selected 7 - Click edit on parent type - note itemtype dropdown menu refers to 'All' itemtypes 8 - Apply patch 9 - Reload page and edit parent type rule 10 - Itemtype dropdown is correctly populated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124717|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 124718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124718&action=edit Bug 28986: Remove (All) notation to correctly select rule for editing This patch updates the JS comparison code to remove the '(All)' hint before comparing to the current value To test: 1 - Go to Administration -> Item types 2 - Edit a type to have a parent of another type 3 - Go to Administration -> Circulation and fines rules 4 - Add a rule for all categories for the child itemtype 5 - Add a rule for all categories for the parent itemtype 6 - Click edit on child type, note itemtype dropdown in editor correctly selected 7 - Click edit on parent type - note itemtype dropdown menu refers to 'All' itemtypes 8 - Apply patch 9 - Reload page and edit parent type rule 10 - Itemtype dropdown is correctly populated Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | --- Comment #4 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Without refactoring the table logic here totally this looks like it is the best least-effort-fix we can do right now. I wonder at what state the new GUI for managing these circ rules is, the code here is very hacky and we cannot forever do this sort of one off fixes. Anyway passing QA since as I said, this is seemingly the best we can do right now without having the new editing page for circ rules or doing total refactoring. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.