[Bug 37004] New: Staff search results: Add a HTML class ( branchcode ) to each li item in the *_loop_items list.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Bug ID: 37004 Summary: Staff search results: Add a HTML class ( branchcode ) to each li item in the *_loop_items list. Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I would like to add the proper branchcode as an HTML class to each <li> item in the staff search results. There are three possible <ul>'s here: -onloan_items_loop_items -available_items_loop_items -other_items_loop_items Having the correct branch code here will make it much easier to write CSS/JS customization for a particular branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167317&action=edit Bug 37004: Add branchcode as HTML class to each grouped result in search results To test: 1. Apply patch and restart_all 2. Do a catalog search that returns results. 3. Using the browsers dev tools inscpet the page and look for the 'available_items_loop_items' class in the 'Location column'. 4. Each child <li> element should have a class that is the branchcode. 5. Make sure that branchcode is correct. 6. Change the StaffSearchResultsDisplayBranch system preference. Make sure that each branchcode is still correct. 7. Change the system preference 'noItemTypeImages' to 'Dont show'. 8. Make sure the branchcode is still correct. 9. Checkout an item that would show up in these search results. 10. Do steps 3-8 again excpet this time look for the HTML element 'onloan_items_loop_items'. 11. Put some items in transfer that would show up in these search resultss. 12. Do steps 3-8 again excpet this time look for the HTML element 'other_items_loop_items'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37005 [Bug 37005] Holdings table will not load when noItemTypeImages is set to 'Don't show' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37006 [Bug 37006] Highlight items available at my loggedinlibrary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167317|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167322&action=edit Bug 37004: Add branchcode as HTML class to each grouped result in search results To test: 1. Apply patch and restart_all 2. Do a catalog search that returns results. 3. Using the browsers dev tools inscpet the page and look for the 'available_items_loop_items' class in the 'Location column'. 4. Each child <li> element should have a class that is the branchcode. 5. Make sure that branchcode is correct. 6. Change the StaffSearchResultsDisplayBranch system preference. Make sure that each branchcode is still correct. 7. Change the system preference 'noItemTypeImages' to 'Dont show'. 8. Make sure the branchcode is still correct. 9. Checkout an item that would show up in these search results. 10. Do steps 3-8 again excpet this time look for the HTML element 'onloan_items_loop_items'. 11. Put some items in transfer that would show up in these search resultss. 12. Do steps 3-8 again excpet this time look for the HTML element 'other_items_loop_items'. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Bug 37004 depends on bug 37005, which changed state. Bug 37005 Summary: Holdings table will not load when noItemTypeImages is set to 'Don't show' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37005 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Summary|Staff search results: Add a |Staff search results: Add a |HTML class ( branchcode ) |HTML class ( branchcode ) |to each li item in the |to each item entry in the |*_loop_items list. |results list --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA'd by RM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |Adds a the branchcode as an release notes| |HTML class to each item | |entry in the staff results | |list. This makes it easier | |to adds CSS/JS | |customization per branch to | |the search results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37004 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Adds a the branchcode as an |This enhancement to staff release notes|HTML class to each item |interface search results |entry in the staff results |adds the library code as an |list. This makes it easier |HTML class to each item |to adds CSS/JS |entry in the location |customization per branch to |column. This makes it |the search results. |easier to add custom | |CSS/JavaScript for | |libraries to the search | |results. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org