[Bug 38429] New: Ambigiuos patron category when adding a new guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Bug ID: 38429 Summary: Ambigiuos patron category when adding a new guarantee Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Have multiple patron categories that are set to 'Can be guarantee'. 2. Go to a patron record and click '+ Add guarantee' 3. Look at how the patron category is set. 4. It defaults to the first one alphabetically, by code. In step 2, I think we need a dropdown that would prompt staff to choose the correct category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174440&action=edit Bug 38429: Add dropdown to Add gaurantee button if multiple categories are allowed To test: 1. Have multiple patron categories that are set to 'Can be guarantee'. 2. Go to a patron record and click '+ Add guarantee' 3. Look at how the patron category is set. 4. It defaults to the first one alphabetically, by code. 5. APPLY PATCH 6. Try steps 1 -2 again, this time you should get a dropdown to pick which category of guarantee you want. 7. Add some patron categories that can be gaurantees with library limitations. Make sure they only show for the correct libraries. 8. Set only patron category to be a gaurantee. The dropdown should now be a button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ambigiuos patron category |Ambiguous patron category |when adding a new guarantee |when adding a new guarantee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174440|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 174812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174812&action=edit Bug 38429: Add dropdown to Add gaurantee button if multiple categories are allowed To test: 1. Have multiple patron categories that are set to 'Can be guarantee'. 2. Go to a patron record and click '+ Add guarantee' 3. Look at how the patron category is set. 4. It defaults to the first one alphabetically, by code. 5. APPLY PATCH 6. Try steps 1 -2 again, this time you should get a dropdown to pick which category of guarantee you want. 7. Add some patron categories that can be gaurantees with library limitations. Make sure they only show for the correct libraries. 8. Set only patron category to be a gaurantee. The dropdown should now be a button. Signed-off-by: Laura ONeil <laura@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175374&action=edit Bug 38429: Add dropdown to Add guarantee button if multiple categories are allowed To test: 1. Have multiple patron categories that are set to 'Can be guarantee'. 2. Go to a patron record and click '+ Add guarantee' 3. Look at how the patron category is set. 4. It defaults to the first one alphabetically, by code. 5. APPLY PATCH 6. Try steps 1 -2 again, this time you should get a dropdown to pick which category of guarantee you want. 7. Add some patron categories that can be gaurantees with library limitations. Make sure they only show for the correct libraries. 8. Set only patron category to be a gaurantee. The dropdown should now be a button. Signed-off-by: Laura ONeil <laura@bywatersolutions.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174812|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Passing QA, and looks like other ways to create patron by selecting category, so it makes sense to make this improvement. Shouldn't we try and create an include for such a kind of button, which open a form to create a patron by pre-selecting the category ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This improves adding a release notes| |guarantee for a patron (+ | |Add guarantee). Where there | |is more than one patron | |category that can be a | |guarantee, the add | |guarantee button now | |includes a dropdown list of | |the categories. This | |removes the need to | |manually select the patron | |category on the patron add | |form (if not changed, the | |first patron category in | |the list was chosen). CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org --- Comment #6 from Juliet Heltibridle <jheltibridle@rcplib.org> --- Will this be backported? I would love to see it as soon as possible, as it would clean up a lot of errors we see during child registrations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate, | |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This improves adding a |This improves adding a release notes|guarantee for a patron (+ |guarantee for a patron (+ |Add guarantee). Where there |Add guarantee). Where there |is more than one patron |is more than one patron |category that can be a |category that can be a |guarantee, the add |guarantee, the add |guarantee button now |guarantee button now |includes a dropdown list of |includes a dropdown list of |the categories. This |the categories. This |removes the need to |removes the need to |manually select the patron |manually select the patron |category on the patron add |category on the patron add |form (if not changed, the |form - previously, if not |first patron category in |changed, the first patron |the list was chosen). |category in the list was | |selected by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi, When applying this patch to the 24.05 branch it breaks the '+ Add guarantee' button on a patron record. When you click this button, with the patch applied, nothing happens. Can somebody please fix it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Alex Buckley from comment #8)
Hi,
When applying this patch to the 24.05 branch it breaks the '+ Add guarantee' button on a patron record.
When you click this button, with the patch applied, nothing happens.
Can somebody please fix it?
Hi Lucas, Would you mind please taking a look at fixing the problem we noted above when we apply this patchset on 24.05.x branch? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39244 [Bug 39244] Duplicate and change password buttons missing if no borrowerRelationship defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #10 from Jesse Maseto <jesse@bywatersolutions.com> --- I still see the same behavior. After applying the patch and then clicking on Add guarantee on a patron account page - The +Add guarantee button is not functional. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38429 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x (or 23.XX) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org