[Bug 38596] New: DataTable - Previous order sequence behaviour not restored at the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Bug ID: 38596 Summary: DataTable - Previous order sequence behaviour not restored at the OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 36640 See commit e76c5c0145f1575254603ba507fbea339cfb4e82 Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Thu Oct 31 10:50:20 2024 +0100 Bug 36640: Restore previous order sequence behaviour Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175050&action=edit Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC See commit e76c5c0145f1575254603ba507fbea339cfb4e82 Bug 36640: Restore previous order sequence behaviour Test plan: Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1 Click on the header to modify the order, click again, then again. It should always be asc or desc, and you should see the corresponding arrows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175050|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175180&action=edit Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC See commit e76c5c0145f1575254603ba507fbea339cfb4e82 Bug 36640: Restore previous order sequence behaviour Test plan: Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1 Click on the header to modify the order, click again, then again. It should always be asc or desc, and you should see the corresponding arrows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 [Bug 38255] Do not use dataTable constructor directly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175180|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 175211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175211&action=edit Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC See commit e76c5c0145f1575254603ba507fbea339cfb4e82 Bug 36640: Restore previous order sequence behaviour Test plan: Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1 Click on the header to modify the order, click again, then again. It should always be asc or desc, and you should see the corresponding arrows. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |the ordering arrows in OPAC | |table heading rows so that | |the sort options are | |ascending (the down arrow), | |and descending (the up | |arrow). It removes an | |incorrect intermediate | |stage where no arrows were | |highlighted. (This is | |related to the upgrade to | |DataTables 2.x in Koha | |24.11.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175211|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 175443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175443&action=edit Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC See commit e76c5c0145f1575254603ba507fbea339cfb4e82 Bug 36640: Restore previous order sequence behaviour Test plan: Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1 Click on the header to modify the order, click again, then again. It should always be asc or desc, and you should see the corresponding arrows. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DataTable - Previous order |DataTable Previous order |sequence behaviour not |sequence behaviour not |restored at the OPAC |restored at the OPAC Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DataTable Previous order |DataTable - previous order |sequence behaviour not |sequence behaviour not |restored at the OPAC |restored at the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- not backporting to 24.05.x unless requested - dependency not in 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Bug 38596 depends on bug 36640, which changed state. Bug 36640 Summary: Upgrade DataTables from 1.13.6 to 2.x https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38596 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org