[Bug 18930] New: Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Bug ID: 18930 Summary: Move lost item refund rules to circulation_rules table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org This patch will move the list item refund rules from a dedicated table to the circulation_rules table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65243&action=edit Bug 18930 - Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Kyle After running updatedatabase.pl successfully when I try to load Koha it throws this load error. This also persists after dropping and recreating the db and going through the web installer: Software error: Can't locate Koha/CirculationRule.pm in @INC (you may need to install the Koha::CirculationRule module) (@INC contains: /home/vagrant/kohaclone /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /home/vagrant/kohaclone/Koha/RefundLostItemFeeRules.pm line 25. BEGIN failed--compilation aborted at /home/vagrant/kohaclone/Koha/RefundLostItemFeeRules.pm line 25. Compilation failed in require at /home/vagrant/kohaclone/C4/Circulation.pm line 54. BEGIN failed--compilation aborted at /home/vagrant/kohaclone/C4/Circulation.pm line 54. Compilation failed in require at /home/vagrant/kohaclone/C4/Overdues.pm line 31. BEGIN failed--compilation aborted at /home/vagrant/kohaclone/C4/Overdues.pm line 31. Compilation failed in require at /home/vagrant/kohaclone/C4/Members.pm line 30. BEGIN failed--compilation aborted at /home/vagrant/kohaclone/C4/Members.pm line 30. Compilation failed in require at /home/vagrant/kohaclone/installer/onboarding.pl line 25. BEGIN failed--compilation aborted at /home/vagrant/kohaclone/installer/onboarding.pl line 25. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Actually one of the dependencies further down the stream (this patch depends on 18928, and that in turn depends on 18925, and that in turn depends on 18887) of this patch is bug 18887 and when applying that it would not apply successfully. So until that is rebased against master then testing this patch will not be possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65243|0 |1 is obsolete| | --- Comment #4 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71007&action=edit Bug 18930 - Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Who should this be assigned to? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71007|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81101&action=edit Bug 18930: Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- The updatedatabase.pl fails when there are records in the lost item refund rules table. See below updatedatabase.pl output: DEV atomic update: bug_18930.perl DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`circulation_rules`, CONSTRAINT `circ_rules_ibfk_1` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement " INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) SELECT NULL, branchcode, NULL, 'refund', refund FROM refund_lost_item_fee_rules "] at (eval 1209) line 4. Upgrade to XXX done (Bug 18930 - Move lost item refund rules to circulation_rules table) kohadev-koha@kohadevbox:/home/vagrant/kohaclone/installer/data/mysql$ exit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81148&action=edit Bug 18930: Do not insert '*' in circulation_rules We must insert NULL instead, otherwise the FK constraint will fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81101|0 |1 is obsolete| | Attachment #81148|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82937&action=edit Bug 18930: Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82938&action=edit Bug 18930: Do not insert '*' in circulation_rules We must insert NULL instead, otherwise the FK constraint will fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82937|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85492&action=edit Bug 18930: Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82938|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85493&action=edit Bug 18930: Do not insert '*' in circulation_rules We must insert NULL instead, otherwise the FK constraint will fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85493|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86169&action=edit Bug 18930: Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86170&action=edit Bug 18930: Do not insert '*' in circulation_rules We must insert NULL instead, otherwise the FK constraint will fail Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86171&action=edit Bug 18930: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #16 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89404&action=edit Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters in smart-rules.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #17 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89405&action=edit Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #18 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89406&action=edit Bug 18930: (follow-up) Change variable used in refund select for default options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io --- Comment #19 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Agustín Moyano from comment #16)
Created attachment 89404 [details] [review] Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters in smart-rules.pl
Added this patch because since RefundLostItemFeeRules is based on CirculationRules, find parameters should not have '*' as branchcode, and a rule_name must be specified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #20 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Agustín Moyano from comment #17)
Created attachment 89405 [details] [review] Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule
This patch was because branchcode was '*', which for CirculationRules should be undef to find default values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #21 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Agustín Moyano from comment #18)
Created attachment 89406 [details] [review] Bug 18930: (follow-up) Change variable used in refund select for default options
This change was because when default rules where undefined, select value always showed 'No' option, while 'use default' options of specific branches showed 'Use default (yes)' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m --- Comment #22 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Hi :) I'm not sure I understood how to test this, here is my test plan. 1. Set "Refund lost item fee" to "no" for all libraries 2. And for a particular library 3. Apply this patch and (as suggested by git BZ) it's dependency bug 18930 4. Run updatedatabase.pl [1] 5. Check that "Refund lost item fee" is still "no" for all libraries and the particular one [1] koha@koha-master:~$ ~/src/installer/data/mysql/updatedatabase.pl DEV atomic update: bug_18928.perl Upgrade to XXX done (Bug 18928 - Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules) DEV atomic update: bug_18930.perl Upgrade to XXX done (Bug 18930 - Move lost item refund rules to circulation_rules table) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14048 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes Victor, you can also test that the behavior is correct. You will find the test plan of the feature on bug 14048. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 89404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89404 Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters in smart-rules.pl We should not need this patch. If the rule_name param is needed to make it works, something else is broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89404|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89405|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #25 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90280&action=edit Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #26 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90281&action=edit Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #27 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90282&action=edit Bug 18930: (follow-up) Change variable used in refund select for default options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90282|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #28 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90283&action=edit Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #29 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90284&action=edit Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #30 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90285&action=edit Bug 18930: (follow-up) Change variable used in refund select for default options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #31 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #24)
Comment on attachment 89404 [details] [review] Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters in smart-rules.pl
We should not need this patch. If the rule_name param is needed to make it works, something else is broken.
Hello Jonathan, I agree with you, so I patched Koha::RefundLostItemFeeRules->find Regards. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Augustin, can you provide tests for the changes you made please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Agustín, can you provide tests for the changes you made please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90284|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90285|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #34 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90541&action=edit Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #35 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90542&action=edit Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #36 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90543&action=edit Bug 18930: (follow-up) Change variable used in refund select for default options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #37 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #33)
Agustín, can you provide tests for the changes you made please?
Hi Jonathan, I just provided tests for find function. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90543|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86171|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #38 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90544&action=edit Bug 18930: Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #39 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90545&action=edit Bug 18930: Do not insert '*' in circulation_rules We must insert NULL instead, otherwise the FK constraint will fail Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #40 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90546&action=edit Bug 18930: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #41 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90547&action=edit Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #42 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90548&action=edit Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #43 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90549&action=edit Bug 18930: (follow-up) Change variable used in refund select for default options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90544|0 |1 is obsolete| | --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91254&action=edit Bug 18930: Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90545|0 |1 is obsolete| | --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91255&action=edit Bug 18930: Do not insert '*' in circulation_rules We must insert NULL instead, otherwise the FK constraint will fail Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90546|0 |1 is obsolete| | --- Comment #46 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91256&action=edit Bug 18930: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90547|0 |1 is obsolete| | --- Comment #47 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91257&action=edit Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90548|0 |1 is obsolete| | --- Comment #48 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91258&action=edit Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90549|0 |1 is obsolete| | --- Comment #49 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91259&action=edit Bug 18930: (follow-up) Change variable used in refund select for default options Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #50 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91260&action=edit Bug 18930: (QA follow-up) Remove debug code Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Status|Signed Off |Passed QA CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23323 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 [Bug 23323] Koha::RefundLostItemFeeRules->find() should require `branchcode`, `categorycode` and `itemtype` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Bug 18930 depends on bug 18928, which changed state. Bug 18928 Summary: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #52 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the| |Reports note: This changes release notes| |the database schema, | |reports referencing the | |`refund_lost_item_fee_rules | |` table will need to be | |updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move lost item refund rules |Move lost item refund rules |to circulation_rules table |into the | |`circulation_rules` table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move lost item refund rules |Move 'refund lost item fee |into the |rules' into the |`circulation_rules` table |`circulation_rules` table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Reports note: This changes |**Reports note**: This release notes|the database schema, |changes the database |reports referencing the |schema, reports referencing |`refund_lost_item_fee_rules |the |` table will need to be |`refund_lost_item_fee_rules |updated |` table will need to be | |updated -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org