[Bug 36392] New: Only 20 vendors in ERM dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Bug ID: 36392 Summary: Only 20 vendors in ERM dropdown Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: caroline.cyr-la-rose@inlibro.com CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com When there are more than 20 vendors in acquisitions, only 20 appear in the New agreement dropdown list. To recreate: 1. Enable the ERMModule system preference 2. In Acquisitions, create more than 20 vendors (see below for an sql insert that I used) 3. Go to E-resource management > Agreements > New agreement 4. Open the vendor dropdown --> It stops at Sierra (or the 20th vendor if you created your own) 5. Type "Tango" or "Zulu" (or one of the names of your 21st+ vendor) --> No results This is what I used to create all the vendors INSERT INTO aqbooksellers (name,active) VALUES ('Alpha','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Bravo','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Charlie','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Delta','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Echo','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Foxtrot','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Golf','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Hotel','1'); INSERT INTO aqbooksellers (name,active) VALUES ('India','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Juliet','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Kilo','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Lima','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Mike','1'); INSERT INTO aqbooksellers (name,active) VALUES ('November','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Oscar','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Papa','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Quebec','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Romeo','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Sierra','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Tango','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Uniform','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Victor','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Whiskey','1'); INSERT INTO aqbooksellers (name,active) VALUES ('X-Ray','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Yankee','1'); INSERT INTO aqbooksellers (name,active) VALUES ('Zulu','1'); Paul D. pointed me to the RESTdefaultPageSize system preference which does affect the dropdown. If I change the syspref to 50, I can see all the vendors in the dropdown. The problem with this is that I'm not sure what else this syspref affects. I have a client with 674 vendors, I don't want to put 1000 in the syspref and then somewhere else something takes forever to load because of this. I'm not sure what is happening here. I found bug 32474 and bug 32468 that seem to deal with this and that are marked as fixed, but I don't see the correct behaviour in ktd with master. I hope someone else can confirm or invalidate this... The client who pointed this out to me (the one with 674 vendors) is on 23.05.05, which already has the patches from bug 32468. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 [Bug 32468] Vendors select only allows selecting from first 20 vendors by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Severity|enhancement |normal Depends on| |34219 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I bisected and found that it was due to bug 34219 which was added to 23.05.04 which makes sense because my client's 23.05.05 has the wrong behaviour. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34219 [Bug 34219] getAll not allowing additional parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163660&action=edit Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM In commit f1078daf8f496e1b4234acf766578c511ca8aad1 Bug 34219: Allow getAll to receive additional URL parameters We needed to call getAll instead of get to fetch all the vendors Test plan: Have more than 20 vendors and create/edit an agreement. Notice that the vendor list contains all the vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163660|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 163671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163671&action=edit Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM In commit f1078daf8f496e1b4234acf766578c511ca8aad1 Bug 34219: Allow getAll to receive additional URL parameters We needed to call getAll instead of get to fetch all the vendors Test plan: Have more than 20 vendors and create/edit an agreement. Notice that the vendor list contains all the vendors Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the listing of release notes| |vendors when adding a new | |agreement in the electronic | |resources (ERM) module. | |Previously only the first | |20 vendors were displayed, | |now all vendors are | |displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.le-gac@inlibro.com Status|Signed Off |Failed QA --- Comment #4 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- I applied the patch to master, checking that I was up to date. I checked that the code had changed. Then I created more than 20 suppliers and when I go to E-resource management > Agreements > New agreement and click on the vendor dropdown. I still only get 20 results. If I change the RESTdefaultPageSize preference as Caroline says, then I can see all the vendors. Did I miss a step because I see that David signed Off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 --- Comment #5 from David Nind <david@davidnind.com> --- Hi Matthias. A 'yarn build' is required after applying the patch for view-related changes (and I normally do a flush_memcached and restart_all) (this was using koha-testing-docker). David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163671|0 |1 is obsolete| | --- Comment #6 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 163741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163741&action=edit Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM In commit f1078daf8f496e1b4234acf766578c511ca8aad1 Bug 34219: Allow getAll to receive additional URL parameters We needed to call getAll instead of get to fetch all the vendors Test plan: Have more than 20 vendors and create/edit an agreement. Notice that the vendor list contains all the vendors Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matthias Le Gac <matthias.le-gac@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 --- Comment #7 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Thanks after I yarn build and reload apache2 all works good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163741|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 163775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163775&action=edit Bug 36392: (bug 34219 follow-up) Fix getAll for vendors - ERM In commit f1078daf8f496e1b4234acf766578c511ca8aad1 Bug 34219: Allow getAll to receive additional URL parameters We needed to call getAll instead of get to fetch all the vendors Test plan: Have more than 20 vendors and create/edit an agreement. Notice that the vendor list contains all the vendors Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matthias Le Gac <matthias.le-gac@inlibro.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36956 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39006 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com --- Comment #12 from Marion Durand <marion.durand@biblibre.com> --- *** Bug 39006 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org