[Bug 30070] New: There are performance issues with edifactmsgs when you have a large number of messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Bug ID: 30070 Summary: There are performance issues with edifactmsgs when you have a large number of messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The edifact messages table can grow to a very large size over time, and the page to display them has issues with this growth as it always loads all messages. We should switch this to an ajax driven datatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30069 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Georgia Newman <g.newman@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |g.newman@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158808&action=edit Bug 30070: Add Koha Objects for EDI Message Files This patch adds the Koha Object based classes assocaited with the edifact_message table. This table actually contains the raw message files which may well each contain multiple edifact messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158809&action=edit Bug 30070: Add fetch endpoint for EDI Files This patch adds a simple EDI Files listing REST endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158810&action=edit Bug 30070: Update edifactmsgs to use the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Adding Tomas and Kyle to CC here. * I'd like your opinions on the locations of the API endpoint and mappings Tomas. * Kyle added as a bit of an EDI guru in the hopes you might test it for me as most people shy away from EDI for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff interface |Acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #5 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Our test server has 10,400 lines in the table and it is taking about 40 seconds to display the page. I don't know how we could set up a sandbox with lots of messages, so perhaps we could see how the change works on our test server. (Our higher specification production server has 11,100 lines but it still takes about 35 seconds to draw the page). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm testing this is some production data and I'm getting 500 errors. I think it's because Koha::Edifact::File presumes every file will have a vendor and basket, but that's not necessarily true. I've patched those two methods but then I get the error: omething went wrong when loading the table. 500: Internal Server Error. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Properties not allowed: basket, deleted, vendor. Can you try testing with an edi message that has a null basket number? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158887&action=edit Bug 30070: (follow-up) Return unless the related object exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for testing Kyle, good call on the relation change. I'll continue here later tonight, be great to see this little enhancement in. Ray, I'll work through the issues Kyle highlighted and then look at it getting it into your test system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ha, I just missed the final addition of the relations in the spec file. I'm out at the minute, but just adding vendor, deleted and basket keys to the edi_file spec should get this going. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158808|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158903&action=edit Bug 30070: Add Koha Objects for EDI Message Files This patch adds the Koha Object based classes assocaited with the edifact_message table. This table actually contains the raw message files which may well each contain multiple edifact messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158809|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158904&action=edit Bug 30070: Add fetch endpoint for EDI Files This patch adds a simple EDI Files listing REST endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158810|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158905&action=edit Bug 30070: Update edifactmsgs to use the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158887|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158906&action=edit Bug 30070: (follow-up) Return unless the related object exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158903|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158907&action=edit Bug 30070: Add Koha Objects for EDI Message Files This patch adds the Koha Object based classes assocaited with the edifact_message table. This table actually contains the raw message files which may well each contain multiple edifact messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158904|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158908&action=edit Bug 30070: Add fetch endpoint for EDI Files This patch adds a simple EDI Files listing REST endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158905|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158909&action=edit Bug 30070: Update edifactmsgs to use the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158906|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158910&action=edit Bug 30070: (follow-up) Return unless the related object exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158907|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158911&action=edit Bug 30070: Add Koha Objects for EDI Message Files This patch adds the Koha Object based classes assocaited with the edifact_message table. This table actually contains the raw message files which may well each contain multiple edifact messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158908|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158912&action=edit Bug 30070: Add fetch endpoint for EDI Files This patch adds a simple EDI Files listing REST endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158909|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158913&action=edit Bug 30070: Update edifactmsgs to use the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158910|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158914&action=edit Bug 30070: (follow-up) Return unless the related object exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158915&action=edit Bug 30070: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158918&action=edit Bug 30070: Add koha_obejct_class(s) to EdifactMessage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158920&action=edit Bug 30070: (follow-up) Fix javascript errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- I fixed some more js issues but there are still a few outstanding issues: * The table is showing all edifact messages including deleted messages. I image some kind of search paramter needs to be added in Koha::REST::V1::Acquisitions::Edifact::Files::list * I get the following error on some but not all datatable pages: DataTables warning: table id=edi_msgs - Requested unknown parameter '4' for row 12, column 4. For more information about this error, please see http://datatables.net/tn/4 datatables_23.0600079.js:514:13 * The bookseller id is missing from the vendor links in the "Vendor" column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158911|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158922&action=edit Bug 30070: Add Koha Objects for EDI Message Files This patch adds the Koha Object based classes assocaited with the edifact_message table. This table actually contains the raw message files which may well each contain multiple edifact messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158912|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158923&action=edit Bug 30070: Add fetch endpoint for EDI Files This patch adds a simple EDI Files listing REST endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158913|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158924&action=edit Bug 30070: Update edifactmsgs to use the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158914|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158925&action=edit Bug 30070: (follow-up) Return unless the related object exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158915|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158926&action=edit Bug 30070: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158918|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158927&action=edit Bug 30070: Add koha_obejct_class(s) to EdifactMessage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158920|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158928&action=edit Bug 30070: (follow-up) Fix javascript errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158929&action=edit Bug 30070: (follow-up) Further javascript fixes This fixes an issue with the datatables when a message file is found to be missing the linked vendor or basket details. This removes the datatables error: DataTables warning: table id=edi_msgs - Requested unknown parameter '4' for row 12, column 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158930&action=edit Bug 30070: (follow-up) Filter out deleted files on the API EDI uses a 'deleted' flag in the table to denote deleted files, we should filter those out of the API response. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158931&action=edit Bug 30070: Improve view message modal display The display had some old specific styling added, we can just use modal-lg from the bootstrap library now to make the display more consistent with other modals. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158932&action=edit Bug 30070: Remove 'Configure' option from datatable This passes 0 for table_settings effectively removing the 'Configure' option from the table. We haven't set up the background logic for table settings for this table and I don't believe there's a real use case for that here at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158922|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158933&action=edit Bug 30070: Add Koha Objects for EDI Message Files This patch adds the Koha Object based classes assocaited with the edifact_message table. This table actually contains the raw message files which may well each contain multiple edifact messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158923|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158934&action=edit Bug 30070: Add fetch endpoint for EDI Files This patch adds a simple EDI Files listing REST endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158924|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158935&action=edit Bug 30070: Update edifactmsgs to use the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158925|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158936&action=edit Bug 30070: (follow-up) Return unless the related object exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158926|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158937&action=edit Bug 30070: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158927|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158938&action=edit Bug 30070: Add koha_obejct_class(s) to EdifactMessage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158928|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158939&action=edit Bug 30070: (follow-up) Fix javascript errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158929|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158940&action=edit Bug 30070: (follow-up) Further javascript fixes This fixes an issue with the datatables when a message file is found to be missing the linked vendor or basket details. This removes the datatables error: DataTables warning: table id=edi_msgs - Requested unknown parameter '4' for row 12, column 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158930|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158941&action=edit Bug 30070: (follow-up) Filter out deleted files on the API EDI uses a 'deleted' flag in the table to denote deleted files, we should filter those out of the API response. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158931|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158942&action=edit Bug 30070: Improve view message modal display The display had some old specific styling added, we can just use modal-lg from the bootstrap library now to make the display more consistent with other modals. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158932|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158943&action=edit Bug 30070: Remove 'Configure' option from datatable This passes 0 for table_settings effectively removing the 'Configure' option from the table. We haven't set up the background logic for table settings for this table and I don't believe there's a real use case for that here at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158933|0 |1 is obsolete| | Attachment #158934|0 |1 is obsolete| | Attachment #158935|0 |1 is obsolete| | Attachment #158936|0 |1 is obsolete| | Attachment #158937|0 |1 is obsolete| | Attachment #158938|0 |1 is obsolete| | Attachment #158939|0 |1 is obsolete| | Attachment #158940|0 |1 is obsolete| | Attachment #158941|0 |1 is obsolete| | Attachment #158942|0 |1 is obsolete| | Attachment #158943|0 |1 is obsolete| | --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158944&action=edit Bug 30070: Add Koha Objects for EDI Message Files This patch adds the Koha Object based classes assocaited with the edifact_message table. This table actually contains the raw message files which may well each contain multiple edifact messages. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158945&action=edit Bug 30070: Add fetch endpoint for EDI Files This patch adds a simple EDI Files listing REST endpoint Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158946&action=edit Bug 30070: Update edifactmsgs to use the API Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158947&action=edit Bug 30070: (follow-up) Return unless the related object exists Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158948&action=edit Bug 30070: Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158949&action=edit Bug 30070: Add koha_obejct_class(s) to EdifactMessage Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158950&action=edit Bug 30070: (follow-up) Fix javascript errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158951&action=edit Bug 30070: (follow-up) Further javascript fixes This fixes an issue with the datatables when a message file is found to be missing the linked vendor or basket details. This removes the datatables error: DataTables warning: table id=edi_msgs - Requested unknown parameter '4' for row 12, column 4. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158952&action=edit Bug 30070: (follow-up) Filter out deleted files on the API EDI uses a 'deleted' flag in the table to denote deleted files, we should filter those out of the API response. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158953&action=edit Bug 30070: Improve view message modal display The display had some old specific styling added, we can just use modal-lg from the bootstrap library now to make the display more consistent with other modals. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158954&action=edit Bug 30070: Remove 'Configure' option from datatable This passes 0 for table_settings effectively removing the 'Configure' option from the table. We haven't set up the background logic for table settings for this table and I don't believe there's a real use case for that here at the moment. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158955&action=edit Bug 30070: (QA follow-up) Make qa script happy Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|There are performance |Performance issues with |issues with edifactmsgs |edifactmsgs when you have a |when you have a large |large number of messages |number of messages | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is now up and running on your test server Ray. Let me know if you spot any issues or if you're happy I can add your signoff here and we can upgrade Kyles to a PQA stamp and get this pushed upstream :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #61 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Had my stopwatch ready to see how much of a reduction from 35-40 seconds I would see, but the EDIFACT messages page appeared almost instantaneously. I can't see any problems- delete action works and navigation to the message and back to other pages is just fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent, thanks for testing Ray :) I'll go ahead and add your signoff line for you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158944|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158963&action=edit Bug 30070: Add Koha Objects for EDI Message Files This patch adds the Koha Object based classes assocaited with the edifact_message table. This table actually contains the raw message files which may well each contain multiple edifact messages. Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158945|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158964&action=edit Bug 30070: Add fetch endpoint for EDI Files This patch adds a simple EDI Files listing REST endpoint Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158946|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158965&action=edit Bug 30070: Update edifactmsgs to use the API Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158947|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158966&action=edit Bug 30070: (follow-up) Return unless the related object exists Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158948|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158967&action=edit Bug 30070: Add unit tests Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158949|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158968&action=edit Bug 30070: Add koha_obejct_class(s) to EdifactMessage Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158950|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158969&action=edit Bug 30070: (follow-up) Fix javascript errors Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158951|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158970&action=edit Bug 30070: (follow-up) Further javascript fixes This fixes an issue with the datatables when a message file is found to be missing the linked vendor or basket details. This removes the datatables error: DataTables warning: table id=edi_msgs - Requested unknown parameter '4' for row 12, column 4. Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158952|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158971&action=edit Bug 30070: (follow-up) Filter out deleted files on the API EDI uses a 'deleted' flag in the table to denote deleted files, we should filter those out of the API response. Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158953|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158972&action=edit Bug 30070: Improve view message modal display The display had some old specific styling added, we can just use modal-lg from the bootstrap library now to make the display more consistent with other modals. Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158954|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158973&action=edit Bug 30070: Remove 'Configure' option from datatable This passes 0 for table_settings effectively removing the 'Configure' option from the table. We haven't set up the background logic for table settings for this table and I don't believe there's a real use case for that here at the moment. Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158955|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158974&action=edit Bug 30070: (QA follow-up) Make qa script happy Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158975&action=edit Bug 30070: (follow-up) Ensure strings are translatable Some strings moved from inline in templates to embedded in JS so we need to wrap them in _() now. Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #76 from Ray Delahunty <r.delahunty@arts.ac.uk> --- My apologies, but one thing I should have noticed in testing was the unexpected order of results delivered. Prior to the patch I believe the sort was on column 2 (Transferred), with newest at the top, but now it appears to be on column 1 (Type). Certainly the ordering for us goes INVOICE > ORDERS > ORDRSP > QUOTE. Within those I don't know what further ordering is based on. Default sorting based on Transferred (newest at the top) would be the preferred option I think- it certainly is mine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158963|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159026&action=edit Bug 30070: Add Koha Objects for EDI Message Files This patch adds the Koha Object based classes assocaited with the edifact_message table. This table actually contains the raw message files which may well each contain multiple edifact messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158964|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159027&action=edit Bug 30070: Add fetch endpoint for EDI Files This patch adds a simple EDI Files listing REST endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158965|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159028&action=edit Bug 30070: Update edifactmsgs to use the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158966|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159029&action=edit Bug 30070: (follow-up) Return unless the related object exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158967|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159030&action=edit Bug 30070: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158968|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159031&action=edit Bug 30070: Add koha_obejct_class(s) to EdifactMessage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158969|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159032&action=edit Bug 30070: (follow-up) Fix javascript errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158970|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159033&action=edit Bug 30070: (follow-up) Further javascript fixes This fixes an issue with the datatables when a message file is found to be missing the linked vendor or basket details. This removes the datatables error: DataTables warning: table id=edi_msgs - Requested unknown parameter '4' for row 12, column 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158971|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159034&action=edit Bug 30070: (follow-up) Filter out deleted files on the API EDI uses a 'deleted' flag in the table to denote deleted files, we should filter those out of the API response. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158972|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159035&action=edit Bug 30070: Improve view message modal display The display had some old specific styling added, we can just use modal-lg from the bootstrap library now to make the display more consistent with other modals. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158973|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159036&action=edit Bug 30070: Remove 'Configure' option from datatable This passes 0 for table_settings effectively removing the 'Configure' option from the table. We haven't set up the background logic for table settings for this table and I don't believe there's a real use case for that here at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #88 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, this no longer applies for me, but could it be we are missing patches? It starts right with a QA follow-up. Can you please check and fix? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30070: (QA follow-up) Make qa script happy error: sha1 information is lacking or useless (Koha/REST/V1/Acquisitions/Vendor/Edifact/Files.pm). error: could not build fake ancestor Patch failed at 0001 Bug 30070: (QA follow-up) Make qa script happy hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-30070-QA-follow-up-Make-qa-script-happy-1cvqbapq.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159026|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160336&action=edit Bug 30070: Add Koha Objects for EDI Message Files This patch adds the Koha Object based classes assocaited with the edifact_message table. This table actually contains the raw message files which may well each contain multiple edifact messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159027|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160337&action=edit Bug 30070: Add fetch endpoint for EDI Files This patch adds a simple EDI Files listing REST endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159028|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160338&action=edit Bug 30070: Update edifactmsgs to use the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159029|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160339&action=edit Bug 30070: (follow-up) Return unless the related object exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159030|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160340&action=edit Bug 30070: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159031|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160341&action=edit Bug 30070: Add koha_obejct_class(s) to EdifactMessage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159032|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160342&action=edit Bug 30070: (follow-up) Fix javascript errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159033|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160343&action=edit Bug 30070: (follow-up) Further javascript fixes This fixes an issue with the datatables when a message file is found to be missing the linked vendor or basket details. This removes the datatables error: DataTables warning: table id=edi_msgs - Requested unknown parameter '4' for row 12, column 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159034|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160344&action=edit Bug 30070: (follow-up) Filter out deleted files on the API EDI uses a 'deleted' flag in the table to denote deleted files, we should filter those out of the API response. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159035|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160345&action=edit Bug 30070: Improve view message modal display The display had some old specific styling added, we can just use modal-lg from the bootstrap library now to make the display more consistent with other modals. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159036|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160346&action=edit Bug 30070: Remove 'Configure' option from datatable This passes 0 for table_settings effectively removing the 'Configure' option from the table. We haven't set up the background logic for table settings for this table and I don't believe there's a real use case for that here at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158974|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160347&action=edit Bug 30070: (QA follow-up) Make qa script happy Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158975|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160348&action=edit Bug 30070: (follow-up) Ensure strings are translatable Some strings moved from inline in templates to embedded in JS so we need to wrap them in _() now. Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #102 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *ping* Still waiting for a rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #103 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #102)
*ping* Still waiting for a rebase.
The patch set is applying to current master cleanly for me! Are you getting conflicts? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #104 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It applies, not sure what went wrong here, testing now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #105 from Nick Clemens <nick@bywatersolutions.com> --- This appears to be pushed to master? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #106 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I messed the bugzilla step or typoed "yes" again - I'll check in the morning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #107 from Fridolin Somers <fridolin.somers@biblibre.com> --- Can this be backported to 23.11.x ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We have it in our local 23.11 branch without causing any issues.. it's a performance enhancement, but I'd be happy to see it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #109 from Ray Delahunty <r.delahunty@arts.ac.uk> --- We have had this running on 22.11.11 since November (see my Comment 76). Some further fixes (QA-related?) appear to have been added since mid-November 2023 and I am not sure if those have been applied to us on 21.11.11 but the backporting at 11/2023 worked fine then and other than the sorting issue I missed in testing (!), the performance improvement is major. We have 12,000 lines and the data apppears instantaneously rather than taking (I recall) 2 minutes or so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Further fixes were backported to your 21.11 Ray ;) For the rest of the PTFS customers, it's only ported back to 22.11.. In both cases, the backport was fairly trivial but for community I think I'd only recommend porting one version back here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #111 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Thanks Martin- nice to know we have had the additional patches applied to our system. But annoyingly I made a typo in my last comment. When I said "I am not sure if those have been applied to us on 21.11.11 [...] I should have said "I am not sure if those have been applied to us on 22.11.11 [...]". We have been on 22.11 since July 2023. Apologies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #112 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement converts release notes| |the edifact messages | |display table to an api | |driven asynchronous | |datatable greatly improving | |the performance of that | |page when large numbers of | |messages exist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement converts |This enhancement converts release notes|the edifact messages |the EDIFACT messages |display table to an api |display table to an API |driven asynchronous |driven asynchronous |datatable greatly improving |datatable greatly improving |the performance of that |the performance of that |page when large numbers of |page when large numbers of |messages exist. |messages exist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 [Bug 36442] Fix typo in EDIFACT list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37340 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 [Bug 37340] Edifact messages should be sortable by 'details' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |phil@chetcolibrary.org --- Comment #113 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to Martin Renvoize (ashimema) from comment #110)
but for community I think I'd only recommend porting one version back here.
Passage of time has put it back one version now, two versions in eight more days, is that far enough back? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #114 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Phil Ringnalda from comment #113)
(In reply to Martin Renvoize (ashimema) from comment #110)
but for community I think I'd only recommend porting one version back here.
Passage of time has put it back one version now, two versions in eight more days, is that far enough back?
This patch is from last cycle, so pushed to main was the correct status. What was missing was the RMaint closing this one off when coming past it. Closing it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38957 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38957 [Bug 38957] EDIFACT messages table should sort by Transferred date descending by default -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org