[Bug 11574] New: Printing Lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Bug ID: 11574 Summary: Printing Lists Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 24474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24474&action=edit Sections that shouldn't print when printing list Would like to see list printing from staff client cleaned up. Right now, the list printing includes buttons and the "Add and item..." section below. These should be omitted to save paper. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 24482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24482&action=edit PDF output of print Christopher, Like this? Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 24483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24483&action=edit Bug 11574 - Clean up lists interface for printing Removes extraneous stuff from prints - toolbars, breadcrumbs, etc. To test: 1. make a list 2. print it to a file, observe wasted paper 3. apply patch 4. print list, compare 5. if you like it, sign off. ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- I should add I suppose, the patch is for the bootstrap theme. If he likes it, I'll do one for prog for backporting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Liz, I think the Bootstrap CSS files require some special magic as they are being generated - see bug 11411. Not sure how to do it yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- There seems to be no print.css in the less folder, so I'm going to assume that his point 2 doesn't apply to this patch (yet). Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|gmcharlt@gmail.com |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24483|0 |1 is obsolete| | --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- Comment on attachment 24483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24483 Bug 11574 - Clean up lists interface for printing contents of patch will need to be put in the less folder, because I have other work out that creates parity between the less and css folders. I'd rather have that patch, so I'll hold off on this one for now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11601 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 25044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25044&action=edit Bug 11574 - Clean up lists interface for printing Removes extraneous stuff from prints - toolbars, breadcrumbs, etc. To test: 1. make a list 2. print it to a file, observe wasted paper 3. apply patch 4. print list, compare 5. if you like it, sign off. ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- This needs an outside of catalyst sign off please -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #9 from Marc Véron <veron@veron.ch> --- Comment #1 talks about staff client, but this bug cleans up printing from OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 25883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25883&action=edit [Signed-off] Bug 11574 - Clean up lists interface for printing Removes extraneous stuff from prints - toolbars, breadcrumbs, etc. To test: 1. make a list 2. print it to a file (from OPAC), observe wasted paper 3. apply patch 4. print list, compare 5. if you like it, sign off. ;) Patch cleans up OPAC list printing as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25044|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, this patch doesn't apply... Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 11574 - Clean up lists interface for printing /home/katrin/kohaclone/.git/rebase-apply/patch:23: space before tab in indent. display : none; fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/css/print.css). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11574 - Clean up lists interface for printing The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- *** Bug 5855 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal --- Comment #13 from Christopher Brannon <cbrannon@cdalibrary.org> --- I'm bumping up the importance of this bug. Since I reported it, list printing has gotten worse. The menu now prints below the first item in the list. Also, printing the list does not print the entire list. If there is more than one page, it will only print what is currently on the page. Also, it is great that the OPAC is being addressed, but my request was specific to the staff client. Preferably, both should be addressed. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #14 from Liz Rea <liz@catalyst.net.nz> --- I think that is a new, separate bug, Christopher - the menu bar one. I've seen that too. Do you want to file it or should I? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Liz Rea from comment #14)
I think that is a new, separate bug, Christopher - the menu bar one. I've seen that too.
Do you want to file it or should I?
I'm not sure. From a user standpoint, it all seems related. I wasn't even sure this was going to be addressed, because I had filed the bug concerning the staff module, but the patch is addressing the OPAC. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Even if I rescued this, the problem is the print() called prints the current page which includes those things, not a different template which would have them hidden. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #17 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to M. Tompsett from comment #16)
Even if I rescued this, the problem is the print() called prints the current page which includes those things, not a different template which would have them hidden.
Well, that's pretty much what this ticket addresses. Sounds like someone needs to setup some print tags and css printing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Christopher Brannon from comment #17)
(In reply to M. Tompsett from comment #16)
Even if I rescued this, the problem is the print() called prints the current page which includes those things, not a different template which would have them hidden.
Well, that's pretty much what this ticket addresses. Sounds like someone needs to setup some print tags and css printing.
Yes, except it doesn't work. print() doesn't load a different page. There's no @media type CSS. I did rescue it, but discovered it failed. I found there's no print.less file 1) Copied print.css to print.less 2) Got lessc installed and working -- steps left as a fun exercise for the reader. 3) edited print.less to have the following at the end ---- BEGIN SNIPPET ---- .navbar, #navigation, .pages, .actions, #toolbar, #selections-toolbar, #remove-selected, .breadcrumb, #members,#opac-main-search,#opac-user-views .ui-tabs-nav,input,h2 span.hint,td.resultscontrol,.pages,.suggestion,.views,#action,#export,#bibliodescriptions .ui-tabs-nav,#addshelf,fieldset.action, .list-actions, .ft, #facetcontainer,.results_summary.actions,.koha_url,.yui-b { display : none; } .row-fluid { margin-top: 30px; } ---- END SNIPPET ---- 4) lessc --compress < ~/kohaclone/koha-tmpl/opac-tmpl/bootstrap/less/print.less
~/kohaclone/koha-tmpl/opac-tmpl/bootstrap/css/print.css
I ignored the warned about --compress being deprecated. That basically fixes the patch, as far as I can tell. 1) Created a list. 2) Logged into the opac 3) Found my list. 4) Clicked 'Print List', but chose 'CutePDF Writer' instead of my printer. 5) Was disappointed in the results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #19 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to M. Tompsett from comment #18)
Yes, except it doesn't work. print() doesn't load a different page. There's no @media type CSS. I did rescue it, but discovered it failed.
Odd that @media isn't working. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25883|0 |1 is obsolete| | --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37499&action=edit Bug 11574 - Clean up Printing Lists Removes extraneous stuff from prints - toolbars, breadcrumbs, etc. To test: 1. make a list 2. print it to a file (from OPAC), observe wasted paper 3. apply patch 4. print list, compare 5. if you like it, sign off. ;) Patch cleans up OPAC list printing as expected. Signed-off-by: Marc Véron <veron@veron.ch> NOTE: Made functional again. Turns out my issues were a result of cached CSS pages. Tested in IE and Firefox successfully. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Printing Lists |Clean up printing of lists | |in OPAC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This report was initially for the staff client, but we got a patch for the OPAC so I think we should file a new report for staff to make it (hopefully) a little less confusing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Cleans up the printout significantly. It would be nice to move things around a bit as the removed navigation leaves a lot of blank space on the left. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37499|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37517&action=edit [PASSED QA] Bug 11574 - Clean up Printing Lists Removes extraneous stuff from prints - toolbars, breadcrumbs, etc. To test: 1. make a list 2. print it to a file (from OPAC), observe wasted paper 3. apply patch 4. print list, compare 5. if you like it, sign off. ;) Patch cleans up OPAC list printing as expected. Signed-off-by: Marc Véron <veron@veron.ch> NOTE: Made functional again. Turns out my issues were a result of cached CSS pages. Tested in IE and Firefox successfully. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #24 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #21)
This report was initially for the staff client, but we got a patch for the OPAC so I think we should file a new report for staff to make it (hopefully) a little less confusing.
Strangely, the obsoleted patches were all for opac, even though you are right it is staff client requested in comment #1. So, because it was opac, that's what I rescued and signed off. Perhaps the description was wrong? After all, staff can create lists in the staff client to use in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #25 from Liz Rea <liz@catalyst.net.nz> --- Sorry to cause confusion, it is for the OPAC but he did ask for Staff all those months ago. Maybe I'll do one for the staff client (on another bug) Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #26 from M. Tompsett <mtompset@hotmail.com> --- When you do, Liz Rea, please add it to the see also for this bug, so I can look at and sign it off. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can someone explain the dependency on 11601 and how it is passed with the other bug ASSIGNED? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11601 | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think comment#18 - Mark created the less file, so I think that obsoleted the dependency to 11601. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #29 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #28)
Hm, I think comment#18 - Mark created the less file, so I think that obsoleted the dependency to 11601.
I agree. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks code cleanup monk! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14211 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #31 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org