http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Assignee|henridamien@koha-fr.org |mark.gavillet@ptfs-europe.c | |om --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Mark, you're the author of the patch, so I've assigned the bug to you. Plus the updated patch is "application/octet-stream", don't you have forgotten to set "patch" to the attachment ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #4)

Created attachment 8635 [details] Replacing previous application/octet-stream patch

Replacing previous application/octet-stream patch

Thanks Mark, note that you could have updated the initial patch: click on "Details" on the right of the patch click on "(edit details)" just after the patch title you'll see a form where you can change patch informations (including obsoleting one without uploading another) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #6)

This says 3.6 does that mean it won't work in 3.8? I haven't tried to test or apply this yet, just wondering about the versioning.

I hope it doesn't. All patches for ENH must be submitted against master. Changing version -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mark, thank you for providing those patches and the documentation! :) I was reading through your patch trying to figure out how it all works and found some small issues: For the new permission to be available on new installations, it has to be added to the sample sql files. There is a test that you can run to make sure you got all necessary files - xt/permissions.t. The new tables have to be added to kohastructure.sql for the same reason. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- Thanks Collin - Again no problem installing the code on master. And everything works great for the examples that you gave. I have since worked on creating an new edi_message to test with a US company Baker and Taylor. It's currently only outgoing and I'm waiting on an example incoming from them. Once I have that I will forward it along to include with this - and hopefully some patches too.. My comment. I had to hard code in the Rebus/EDI.pm to be able to successfully create a outgoing .CEP (to a non-ptfs-europe example)... Which I did and I've forward that onto the vendor. I also notice that it's hardcoded for GBP. So I'm wondering - are those changes that we should make to the code? - so it's not so "hard" coded. Or is that part of the scope that you are developing for and we're going to see some more patches? (Just want an idea on where I should send our development team) Anyways - code works. I can sign off on this as is. But I really want to have a discussion with some more developers, before I sign-off - since this would have to be hard coded for anyone to use it with there choice of vendor - and it doesn't take advantage of information that is readily available through koha (currency, etc. or even the EAN/SAN accounts created in the database). Hope that makes sense. -Brendan -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12398|0 |1 is obsolete| | --- Comment #13 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 12438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12438&action=edit Revised patch This revision add updatedatabase entries for the tables. It also avoids the hardcoded currency code. At the moment Koha does not enforce use of the standard codes so this is a bit kludgie at the moment, but in practice library Acquisition depts are usually using these -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #14)

Errors on apply the patch: error: patch failed: installer/data/mysql/sysprefs.sql:382 error: installer/data/mysql/sysprefs.sql: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:5966 error: installer/data/mysql/updatedatabase.pl: patch does not apply

In fact the problem is trivial: those files (sysprefs.sql and updatedatabase.pl) are changing quite quickly those days

If you use git am -3 you'll be able to resolve the conflict yourself. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> ---

I don't know if it is better to use `key` or to use a different name

Using a keyword is always as field name a bad practise, so I would say use a different name ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |colin.campbell@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Zeno Tajoli <tajoli@cilea.it> --- The test of this patch is failed. The instructions say: 4. Add EANs to your local ordering branches Go to Administration > Additional Parameters > EDI EANs This operation is not possible because the .pl files admin/edi_ean_accounts.pl admin/edi_ean_edit.pl and the connect table 'edifact_ean' are not more present in the patch The .pl files and the definiton of the table were present in the version of the patch dated 2011-06-11 It not clear if are wrong instructions or code. If instructions are correct probably a merge of the two patch is possible. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #22 from Zeno Tajoli <tajoli@cilea.it> --- Ok, but can you rewrite the instructions ? I can do the test but I don't know EDI, so I need instructions to do ti -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8276|0 |1 is obsolete| | --- Comment #24 from Zeno Tajoli <tajoli@cilea.it> --- Created attachment 13071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13071&action=edit Instructions for setting up a test environment for the patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Irma Birchall <irma@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma@calyx.net.au -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12467|0 |1 is obsolete| | --- Comment #26 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 15304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15304&action=edit Bug 7736: EDI Edifact quote and order functionality Rebased for current master. I will be adding unit tests in a follow up patch This is a patch brining together the original work by Mark Gavillet and the subsequent patches by Mark, Martin Renvoize and myself It contains the code as currently runnng in production In addition I've added updatedatebase entries to installer and replaced the hardcoded currency with a currency extraction. As the db currently does not force the standard codes we check if that is 3 uppercase ascii characters before using it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15304|0 |1 is obsolete| | --- Comment #28 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 15729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15729&action=edit Bug 7736: EDI Edifact quote and order functionality This is a patch brining together the original work by Mark Gavillet and the subsequent patches by Mark, Martin Renvoize and myself It contains the code as currently runnng in production In addition I've added updatedatebase entries to installer and replaced the hardcoded currency with a currency extraction. As the db currently does not force the standard codes we check if that is 3 uppercase ascii characters before using it. Elliott Davis: Added unit test for EDI -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #29 from Brendan Gallagher <brendan@bywatersolutions.com> --- Planning on rewriting the testing plan for this. I will also provide an FTP server for testing that portion of the code. I should have this completed Monday March 18th. And then we can test and sign-off that week in time for QA to review before the freeze. Thank you, Brendan -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #31 from Brendan Gallagher <brendan@bywatersolutions.com> --- Test Plan - Koha EDIfact module - PTFS Europe (Updated by Brendan Gallagher - ByWater) Setup and testing ----- 1. Allocate permissions to a staff user Find a staff user and click the Details tab. Select More > Set permissions Expand the Tools options, then check '(edi_manage) Manage EDIFACT transmissions', then click the Set flags button This user should now be able to see an EDIfact messages option in Tools > Additional Tools 2. Set default values for testing the included quote message Add two test branches with the branchcodes 'BRANCH1' and 'BRANCH2' Add two funds with the fundcodes 'FUND1' and 'FUND2' Add three itemtypes with the codes 'BKREF', 'BK1WK', and 'BK4WK' Add three authorised values in the LOC category - 'REFERENCE', 'STORE', and 'SHELVES' 3. Add the test bookseller and EDIfact account details Create a new bookseller with the name 'PTFS-Europe' Go to Administration > Additional Parameters > EDI Accounts Add a new account: Vendor: PTFS-Europe Description: Test EDI FTP account Server hostname: <hostname of your FTP account> **ByWater is offering one for testing - 166.78.149.34 Server username: <user with read and write permissions> **ByWater is offering one for testing - edifact2443 Server password: <password of the above user> **ByWater is offering one for testing - order2443 Server remote directory: <path to the remote directory holding your edi quotes and orders> **Bywater is offering one for testing - /home/edifact2443 Vendor SAN/EAN: 5099876543210 Click save (these details can be edited or removed using the options in Administration > Additional Parameters > EDI Accounts) Upload the supplied quotes file to the Server remote directory on your FTP server (supplied quotes file is in misc/edi_files/ptfs-europe-koha-community.CEQ) ***(Brendan has uploaded that file to ByWater temp FTP and renamed it edifact_test_brendan.CEQ) 5. Import the quote file from the Vendor FTP account Before running the import, ensure that the user running the web server has read/write access to misc/edi_files and the files in it (drw-rw-r-- koha www-data) On the command line cd to misc/cronjobs and run 'perl edifact_order_ftp_transfer.pl ' (ordinarily this would be automated at intervals using the cron) The remote file will be renamed following EDI convention with a .EEQ extension. You can also move the file to another directory (see later details) The last activity date will be updated in the vendor EDI account FTP transactions are logged in misc/edi_files/edi_ftp.logged Any errors in processing the quote will be logged in edi_quote_error.log Downloaded EDI messages are stored in misc/edi_files and also in the edi_messages MySQL table 6. View the EDI message Go to Tools > EDIfact messages Messages are listed in date order descending. You should have a QUOTES type message with a status of processed, and a link to the basket holding the order Click View basket Three items should be in the basket, linked to the correct funds, branches, etc. that you specified earlier When the quote message is imported, existing bib records are checked for a match on ISBN. If a match is found, items are attached to that bib record. If no matches are found, a bib record is created using the detail from the quote message and items are attached to them. The name of the created basket is the same as the originating quote message filename 7. Sending an order message back to the vendor Click the EDIfact order button (this is only shown for vendors with an associated EDI account) If you only have more than one branch with an EAN, you will be prompted to select an ordering branch. If only one branch has an EAN, this is used by default and this step is skipped. The EDI order message is generated and delivered to the vendor FTP site. Filenames take the format 'ediorder_xxx.CEP' (where xxx is the basket number) The edi_messages table is updated with an entry for your edi order message with a status of sent, transactions are logged to misc/edi_files/edi_ftp.log, and the last activity date is updated for the vendor edi account. 8. Sending an order message without a quote Any vendor that has an edi account can accept order messages without a quote. When you have created a basket from scratch, follow the instructions in step 7 to send the order message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #33 from Brendan Gallagher <brendan@bywatersolutions.com> --- Patch applied for me - but would not apply in the sandbox. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #36 from Zeno Tajoli <z.tajoli@cineca.it> --- I found problems on sending order, routine SendEDIOrder in C4/EDI.pm I receive the error: Could not transfer the file /home/test7736/kohaclone/misc/edi_files/ediorder_1.CEP to 166.78.149.34: The problem is in the lines 594-596 if ( !$newerr ) { $newerr = 0; $ftp->put("${edi_files}ediorder_$basketno.CEP") or $newerr = 1; The file ediorder_1.CEP is present in the dir /home/test7736/kohaclone/misc/edi_files With a normal ftp client I don't have problems to upload files in the site 166.78.149.34. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16538|0 |1 is obsolete| | --- Comment #38 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16629&action=edit Bug 7736 - Edifact QUOTE and ORDER functionality Patch rebase 3.11.00.106 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #40 from Zeno Tajoli <z.tajoli@cineca.it> --- The rebase of Fridolyn SOMERS [comment 38] doesn't fix the errors that I describe in comment 39 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16629|0 |1 is obsolete| | --- Comment #42 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 16649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16649&action=edit Bug 7736: EDI Edifact quote and order functionality This is a patch brining together the original work by Mark Gavillet and the subsequent patches by Mark, Martin Renvoize and myself It contains the code as currently runnng in production In addition I've added updatedatebase entries to installer and replaced the hardcoded currency with a currency extraction. As the db currently does not force the standard codes we check if that is 3 uppercase ascii characters before using it. Elliott Davis: Added unit test for EDI Zeno Tajoli: Rebased on last master git tree. I have change only the file installer/data/mysql/sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #44 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 16667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16667&action=edit [Folluw-up] Bug 7736 EDI Edifact quote and order functionality Adding in Passive per Zenos thoughts and comment #39 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #46 from Mark Gavillet <mark.gavillet@ptfs-europe.com> --- Thanks for this Katrin - I really appreciate it. I've been working on an improved version of the EDI code which allows for separate processing modules for booksellers, local customisation of order messages for individual customers, multiple SAN/EANs for different library branches, and other improvements. I'm currently working on adding EDI invoice message processing which is progressing very well. Obviously, I'd feel very reluctant to submit code in the future if I'm not going to be credited for any of the work. (In reply to comment #45)

Hi all, taking a quick look at this before breakfast and I feel like there is another big issue we have to fix before this can go in. Patches have been squashed resulting in the fact, that Mark Gavillet will not get any credit for all the lines of code he wrote here. I think as we can not split up the patches again, we probably need to reinstate Mark as author of the first patch.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #48 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #47)

(In reply to comment #46)

...

Thanks for this Katrin - I really appreciate it.

I've been working on an improved version of the EDI code which allows for separate processing modules for booksellers, local customisation of order messages for individual customers, multiple SAN/EANs for different library branches, and other improvements. I'm currently working on adding EDI invoice message processing which is progressing very well. Obviously, I'd feel very reluctant to submit code in the future if I'm not going to be credited for any of the work.

Hi Mark,

You probably need to have a chat with Colin, as it was he who merge yours, martin and his patches together

http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12398

So maybe since you are all from the same organisation that is ok? If not you might need to work together to split them back out

Once those are split up, we can split out the little bits from Elliott and Zeno too. But those are small changes and easy to split out -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16649|0 |1 is obsolete| | --- Comment #50 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 16732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16732&action=edit Rebase Bug 7736 EDI Edifact quote and order functionality This is a patch brining together the original work by Mark Gavillet and the subsequent patches by Mark, Martin Renvoize and myself It contains the code as currently runnng in production In addition I've added updatedatebase entries to installer and replaced the hardcoded currency with a currency extraction. As the db currently does not force the standard codes we check if that is 3 uppercase ascii characters before using it. Elliott Davis: Added unit test for EDI Zeno Tajoli: Rebased on last master git tree. I have change only the file installer/data/mysql/sysprefs.sql Brendan Gallagher: 2013-03-22 Rebased on current master Changed installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #52 from Zeno Tajoli <z.tajoli@cineca.it> --- With the last follow-up I also sign off this enhacement. In fact to install the patch you need 4 different files. The points to do: 1)Install the big rebase of Brendan 2)Install the first follow-up of Brendan, http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16652 3)Install the second rebase of Brendan, http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16667 4)Install my follow-up, http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16761 For QA: to testi you need to have the dir misc/edi_files/ usable in read/write from the command line user of Koha [standard name: koha] and the apache user [standard name and group in debian: www-data]. A good idea is also to create the file misc/edi_files/edi_ftp_error.log and to give the red/write permissions on it. So, usign the default users: sudo chown koha:www-data edi_files sudo chmod 770 edit_files sudo touch edi_files/edi_ftp_error.log sudo chown koha:www-data edi_files/edi_ftp_error.log sudo chmod 770 edi_files/edi_ftp_error.log -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have received an email from Mark that the first patch should have the authorship: Mark Gavillet [mark.gavillet@ptfs-europe.com] Is this agreeable? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #56 from Brendan Gallagher <brendan@bywatersolutions.com> --- I agree! This is Agreeable! (In reply to comment #54)

I have received an email from Mark that the first patch should have the authorship: Mark Gavillet [mark.gavillet@ptfs-europe.com]

Is this agreeable?

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #58 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: 1- SQL reserved words must be in capital letters (see coding guidelines) 2- MANY tabulation errors: * C4/EDI.pm FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (778) 3- other koha-qa.pl errors: * installer/data/mysql/updatedatabase.pl FAIL valid FAIL Missing right curly or square bracket syntax error installer/data/mysql/updatedatabase.pl had compilation errors. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi-edit.tt FAIL tt_valid FAIL (untested yet, maybe other comments once follow-up provided) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #60 from Brendan Gallagher <brendan@bywatersolutions.com> --- (In reply to comment #58)

QA comments: 1- SQL reserved words must be in capital letters (see coding guidelines) 2- MANY tabulation errors: * C4/EDI.pm FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (778) 3- other koha-qa.pl errors:

* installer/data/mysql/updatedatabase.pl FAIL

valid FAIL Missing right curly or square bracket syntax error installer/data/mysql/updatedatabase.pl had compilation errors. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi-edit.tt FAIL tt_valid FAIL

(untested yet, maybe other comments once follow-up provided)

Paul Are these all from the qa-test-tools git branch? Or did you run something else to test? Just curious - cause I can rerun those and fix these up in the next few months after the 3.12 release. Thanks, Brendan -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #62 from Brendan Gallagher <brendan@bywatersolutions.com> --- (In reply to comment #61)

(In reply to comment #60)

...

Paul Are these all from the qa-test-tools git branch? Yes they are

...

Or did you run something else to test?

nope, that's just the output from koha-qa.pl

AH thank you very much Paul - that was what I meant - I guess I am still speaking and typing in broken English - product of traveling in France - but a good one... Thanks much, Brendan -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16865&action=edit Bug 7736 EDI Edifact quote and order functionality Adding in Passive per Zenos thoughts and comment #39 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16864|0 |1 is obsolete| | Attachment #16865|0 |1 is obsolete| | Attachment #16866|0 |1 is obsolete| | --- Comment #66 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16867&action=edit Bug 7736 - EDI Edifact quote and order functionality This is a patch brining together the original work by Mark Gavillet and the subsequent patches by Mark, Martin Renvoize and myself It contains the code as currently runnng in production In addition I've added updatedatebase entries to installer and replaced the hardcoded currency with a currency extraction. As the db currently does not force the standard codes we check if that is 3 uppercase ascii characters before using it. Elliott Davis: Added unit test for EDI Zeno Tajoli: Rebased on last master git tree. I have change only the file installer/data/mysql/sysprefs.sql Brendan Gallagher: Rebased on current master Changed installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #68 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16869&action=edit Bug 7736 EDI Edifact quote and order functionality Adding in Passive per Zenos thoughts and comment #39 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16867|0 |1 is obsolete| | Attachment #16868|0 |1 is obsolete| | Attachment #16869|0 |1 is obsolete| | Attachment #16870|0 |1 is obsolete| | --- Comment #70 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16871&action=edit Bug 7736 - Edifact QUOTE and ORDER functionality This is a patch brining together the original work by Mark Gavillet and the subsequent patches by Mark, Martin Renvoize and myself It contains the code as currently runnng in production In addition I've added updatedatebase entries to installer and replaced the hardcoded currency with a currency extraction. As the db currently does not force the standard codes we check if that is 3 uppercase ascii characters before using it. Elliott Davis: Added unit test for EDI Zeno Tajoli: Rebased on last master git tree. I have change only the file installer/data/mysql/sysprefs.sql Brendan Gallagher: Rebased on current master Changed installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16873&action=edit Bug 7736 - Edifact QUOTE and ORDER functionality - Followup 2 - Adding in Passive per Zenos thoughts and comment #39 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16871|0 |1 is obsolete| | Attachment #16872|0 |1 is obsolete| | Attachment #16873|0 |1 is obsolete| | Attachment #16874|0 |1 is obsolete| | --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16882&action=edit Bug 7736 - Edifact QUOTE and ORDER functionality This is a patch brining together the original work by Mark Gavillet and the subsequent patches by Mark, Martin Renvoize and myself It contains the code as currently runnng in production In addition I've added updatedatebase entries to installer and replaced the hardcoded currency with a currency extraction. As the db currently does not force the standard codes we check if that is 3 uppercase ascii characters before using it. Elliott Davis: Added unit test for EDI Zeno Tajoli: Rebased on last master git tree. I have change only the file installer/data/mysql/sysprefs.sql Brendan Gallagher: Rebased on current master Changed installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16882|0 |1 is obsolete| | Attachment #16883|0 |1 is obsolete| | --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16884&action=edit Bug 7736 - Edifact QUOTE and ORDER functionality This is a patch brining together the original work by Mark Gavillet and the subsequent patches by Mark, Martin Renvoize and myself It contains the code as currently runnng in production In addition I've added updatedatebase entries to installer and replaced the hardcoded currency with a currency extraction. As the db currently does not force the standard codes we check if that is 3 uppercase ascii characters before using it. Elliott Davis: Added unit test for EDI Zeno Tajoli: Rebased on last master git tree. I have change only the file installer/data/mysql/sysprefs.sql Added missing end tag for tools-home.tt Brendan Gallagher: Rebased on current master Changed installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Bug 7736 - Edifact QUOTE and ORDER functionality - Followup - cordinate this with template tools-home.tt After the writting of the patch, the template tools-home.tt has a little change. I have have tested the ench wit instruction and I confirm that works. Attention on dir misc/edi_files, you need to give permission to koha and to web server user (standard: www-data on debian) Signed-off-by: Zeno Tajoli <tajoli@cilea.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16885|0 |1 is obsolete| | --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16886&action=edit Bug 7736 - Edifact QUOTE and ORDER functionality This is a patch brining together the original work by Mark Gavillet and the subsequent patches by Mark, Martin Renvoize and myself It contains the code as currently runnng in production In addition I've added updatedatebase entries to installer and replaced the hardcoded currency with a currency extraction. As the db currently does not force the standard codes we check if that is 3 uppercase ascii characters before using it. Elliott Davis: Added unit test for EDI Zeno Tajoli: Rebased on last master git tree. I have change only the file installer/data/mysql/sysprefs.sql Added missing end tag for tools-home.tt Brendan Gallagher: Rebased on current master Changed installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Bug 7736 - Edifact QUOTE and ORDER functionality - Followup - cordinate this with template tools-home.tt After the writting of the patch, the template tools-home.tt has a little change. I have have tested the ench wit instruction and I confirm that works. Attention on dir misc/edi_files, you need to give permission to koha and to web server user (standard: www-data on debian) Signed-off-by: Zeno Tajoli <tajoli@cilea.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #80 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 17121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17121&action=edit Bug 7736 - Edifact QUOTE and ORDER functionality - Followup - Fix UI Issues -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17121|0 |1 is obsolete| | --- Comment #82 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20984&action=edit Bug 7736 - Edifact QUOTE and ORDER functionality - Followup - Fix UI Issues -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #84 from Paola Rossi <paola.rossi@cineca.it> --- The field san in vendor_edi_accounts table is varchar(10). In the template, field "Vendor SAN" is longer. In the documentation the length of SAN/EAN is 13. So I don't signed off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master Assignee|mark.gavillet@ptfs-europe.c |colin.campbell@ptfs-europe. |om |com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #86 from Zeno Tajoli <z.tajoli@cineca.it> --- Only a little remark: To test the code we need a test sftp/ftp site. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #89 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Brendan Gallagher from comment #87)

Hello Colin -

I was wondering on the status of this and if you all have had a chance to post some newer code up here soon?

Thanks much, Brendan

(In reply to Colin Campbell from comment #85)

...

I'm working on generating a usable patch set for people to test from this and some custom scripts. The edifact parsing is effectively done (for a very limited number of vendors). It needs to be made into something that fits cleanly with Koha.

In practice for those Koha sites using EDI in the UK the process is largely one of transferring incoming quotes and invoices and sending orders by ftp/sftp. (one gets the impression that the vendors edi side is not very automated).

The impact on Koha's work flow is minimal we need to store vendor edi account details (a vendor may have multiple edi 'accounts' ) and the corresponding library side accounts.

In the normal acq workflow the addition would be an option to send an order_basket by edi if the vendor is edi_enabled Otherwise there need to be batch scripts to handle transferring data from the vendor and loading that into Koha.

I dont know if people are envisioning other workflows, if so please post details against this bug.

Hope to post with tests and documentation as a working beast soon

Should be posting a patch in the next few days -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #91 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Branch edi_master on git@github.com:colinsc/koha.git is the version I've deployed on our customers. I'll be creating a patch to submit against this bug but its available there for interested parties that may want to take a look -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20983|0 |1 is obsolete| | Attachment #20984|0 |1 is obsolete| | Attachment #21475|0 |1 is obsolete| | --- Comment #93 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 33953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33953&action=edit Proposed Patch Patch with basic QUOTES, ORDERS and INVOICES handling. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #95 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 33957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33957&action=edit Some basic documentation A brief description of the parameters required for set up and the work flow for edifact -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #97 from Brendan Gallagher <brendan@bywatersolutions.com> --- Kyle updated the patch so it applies cleanly on master. I am testing this today and should have a signoff if it follows the plans. Testing going on ;) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #99 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Brendan Gallagher from comment #98)

Everything works great.

Questions for Colin or Martin - "EDIfact messages Manage EDIfact transmissions" That is found in the Tools section of koha. But I think you've moved that functionality into ACQ, so I think that can just be ignored and removed now. Answer that question for me and I'll sign-off. I think that a QA follow-up of just removing that from the Koha Tools and we are golden.

Great Job. Thanks

Yes edifact message handling should all be under ACQ now -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34332|0 |1 is obsolete| | --- Comment #100 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 34833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34833&action=edit rebased patch Patch rebased against master also fixes the omission of the shipping budget syspref from updatedatabase and incorporates small change to Koha::EDI so that single copies are added using the same codepath as multiple copies. Fixes a bug raised by Staffs University -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #102 from Zeno Tajoli <z.tajoli@cineca.it> --- I setup acq to test this patch. I use a 'FILE' edi account. When I try to close the basket and create the request I see Software error: Can't call method "branchcode" on an undefined value at /home/koha/test_edi/Koha/Edifact/Order.pm line 374. The link used: http://192.168.216.128:8080/cgi-bin/koha/acqui/basket.pl?basketno=1&op=ediorder&ean=111222&booksellerid=1&confirm=1&basketgroupname=bask1 Generaly speaking I think we need more details on how to do test of this feature. For example: -- EAN/SAN, names for budgets, funds and vendors -- files of different types -- ect. I run those tests, but I think it is not enough to sign-off: prove Ediorder.t: OK prove EdiInvoice.t: OK prove Edifact.t: OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #104 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Zeno Tajoli from comment #102)

I setup acq to test this patch. I use a 'FILE' edi account.

When I try to close the basket and create the request I see

Software error: Can't call method "branchcode" on an undefined value at /home/koha/test_edi/Koha/Edifact/Order.pm line 374.

The link used: http://192.168.216.128:8080/cgi-bin/koha/acqui/basket. pl?basketno=1&op=ediorder&ean=111222&booksellerid=1&confirm=1&basketgroupname =bask1

Generaly speaking I think we need more details on how to do test of this feature. For example: -- EAN/SAN, names for budgets, funds and vendors -- files of different types -- ect.

I run those tests, but I think it is not enough to sign-off:

prove Ediorder.t: OK prove EdiInvoice.t: OK prove Edifact.t: OK

Addeda supplementary patch handling derivation of branch from the basket -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35716|0 |1 is obsolete| | --- Comment #106 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 35717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35717&action=edit Bug 7904: (QA followup) fix tests The package name for SIP wasn't fixed in the tests by the original patches. This patch fixes it. To test: - Run $ prove t/db_dependent/SIP_ILS.t - Tests should pass with the patch. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35717|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #109 from Chris Cormack <chris@bigballofwax.co.nz> ---

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Following test plan this works great. Doesn't break ACQ. There are a few little spots QA can followup with but should go through. Thanks!

Can you let us know what the spots are? To help QA? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #111 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If you spot this while signing off, please note and fail - it will save the time of a QA team member - and easy to sign off on the follow up then. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #113 from Brendan Gallagher <brendan@bywatersolutions.com> --- I'm really itching to get this fixed up and tested this week - while we have everyone hacking. We can get some great testing done here and get you the feedback. Really important for this week. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #115 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Switched status back to needs signoff - issues with old gplv2 licenses causing QA fail are fixed in the patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #117 from Brendan Gallagher <brendan@bywatersolutions.com> --- Any update on this? Now is the time to really get a move on this so we have enough months left to test and fix for getting into 3.22 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #119 from Brendan Gallagher <brendan@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #118)

Would it make sense to work out the remaining patches for the tax rewrite first before we tackle this? I think they will effect this.

That's fine - I still want to see the code though and they are both going to take months of time to work on. The important thing coming up is the KohaNA where we'd like to have librarians testing both (they are having hacking days). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #121 from Colin Campbell <colin.campbell@ptfs-europe.com> --- I've put the latest code up on my github repo git@github.com:colinsc/koha.git as the branch edifact_snapshot_150911 If anyone wants to look at this. I'm hoping to get order responses working end to end then will generate a patch from this -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #122 from Zeno Tajoli <z.tajoli@cineca.it> --- I insert the patch rebasing this branch of Colin [https://github.com/colinsc/koha/tree/edifact_snapshot_150911] with origin/master of today (27/10/2015]. Patch 0001-Rebase-on-master: the main rebase on master done from Colin's work. Patch 0002-Patch-to-update-DBIx: Update DBIX files from Colin's work Patch 0003-Modification-in-Acquisition.t: Update of Acquisition.t with new DB structure. Patch 0004-Fixed-the-definition-of-table-edifact_ean: My proposal to fix problem of defintion in edifact_ean table Patch 0005-EdifactEan_DBIx-update: The update of DBIx file for table edifact_ean Patch 0006-Fix-differences-between-kohastructure.sql-and-edifact.sql: There are same differences between kohastructure.sql and atomicupdate/edifact.sql about the structure of edifact_ean. With this patch I insert also in kohastructure.sql the creation of the coloum ee_id. With all patch installed there are still problem on using edi. I try to add the EAN/SAN to the library using administration/acquisitions/EDI EANs [...:8080/cgi-bin/koha/admin/edi_ean_accounts.pl] The result is: Software error: DBIx::Class::ResultSet::search(): No such relationship branch on EdifactEan at /production/develops/admin/edi_ean_accounts.pl line 93 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #124 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 44080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44080&action=edit 0002-Patch-to-update-DBIx -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #126 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 44082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44082&action=edit 0004-Fixed-the-definition-of-table-edifact_ean -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #128 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 44084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44084&action=edit 0006-Fix-differences-between-kohastructure.sql-and-edifact.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #130 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Paul Poulain from comment #129)

Functionality question: is there an EDIFACT way for a vendor to cancel an order line (ie: the vendor cannot deliver an item that was ordered) ?

Yes its a separate message an Order Response it can cancel an order also report on orders that cannot be immediately fulfilled (e.g. reprinting ) I have the code which reads them I just need to add the resulting updates to the koha files -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #132 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Patch with consolidated modifications including ordrsps (and order cancellation as a result) Will update Zeno's patch to Acquisition.t -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15630 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 [Bug 15630] Make Edifact module pluggable -- You are receiving this mail because: You are watching all bug changes.