http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |tredok.pierre@gmail.com --- Comment #2 from Pierre Angot <tredok.pierre@gmail.com> --- Test on sandbox : Something went wrong ! Applying: Bug 9580 Cover images from Coce, a remote image URL cache Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Auth.pm Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt Failed to merge in the changes. Patch failed at 0001 Bug 9580 Cover images from Coce, a remote image URL cache When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9580 - Cover image from Coce, a remote image URL cache -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15203|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #4 from Pierre Angot <tredok.pierre@gmail.com> --- Web can't test on sandbox. Sorry. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |3.14 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #6 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 9580 Cover images from Coce, a remote image URL cache Using index info to reconstruct a base tree... M C4/Auth.pm M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref M koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc M koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt M koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref Auto-merging C4/Auth.pm Patch failed at 0001 Bug 9580 Cover images from Coce, a remote image URL cache The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-10-27 last check this| | --- Comment #9 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #13 from Frédéric Demians <frederic@tamil.fr> ---

...

+<<<<<<< HEAD

I think a rebase didn't quite work.

It doesn't look good at all! I fix that, and add markup to Bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 nicolas <nicolas.bravais@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nicolas.bravais@gmail.com --- Comment #15 from nicolas <nicolas.bravais@gmail.com> --- All the covers are the same with or without Coce. And the exact same covers are retrieved (no more, no less...) With 'Bootstrap' and 'prog'. At one time there was 2 covers for the same biblios (one slightly bigger than the other one. For example : http://ecx.images-amazon.com/images/I/613QE5KV4YL._SL160_.jpg and http://images.amazon.com/images/P/2700036336.01.TZZZZZZZ.jpg Nevertheless it looks like it's an random accident since I didn't manage to re-create this error... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #17 from nicolas <nicolas.bravais@gmail.com> --- Created attachment 24145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24145&action=edit screenshot with 2 cover screenshot with 2 cover -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- With the dumping of the prog theme, you may wish to split out the prog portion of this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24071|0 |1 is obsolete| | --- Comment #20 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32794&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32794|0 |1 is obsolete| | --- Comment #22 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32795&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32795|0 |1 is obsolete| | --- Comment #24 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32801&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #26 from Frédéric Demians <frederic@tamil.fr> --- (In reply to M. Tompsett from comment #23)

Rather than add more parameters, why not modify the template to have: [%- USE Koha -%] And then use the plugin function to grab it directly. Less modifications are good. :)

I agree. Thanks for the tip. I wasn't aware if this Koha TT extension. I refactored the patch to use it.

::: koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc This is OPAC prog.

Cleaned now. Thanks. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32808|0 |1 is obsolete| | --- Comment #30 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32809&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #32 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Frédéric Demians from comment #31)

(In reply to M. Tompsett from comment #28)

...

If this saves in the systempreferences table, shouldn't there be updatedatabase.pl, systemprefs.sql update too?

I don't think so. No value are required at all. By default, nothing is stored in systempreferences table, and the functionality is just disabled.

http://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_p... I think you do. You are correct that it functions without it, but we should be explicit. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #34 from Frédéric Demians <frederic@tamil.fr> ---

http://wiki.koha-community.org/wiki/ System_Preferences#Adding_a_new_system_preference I think you do. You are correct that it functions without it, but we should be explicit.

I updated the wiki, accordingly with my thought on the subject. Feel free to disagree, and to revert my wiki update. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #36 from M. Tompsett <mtompset@hotmail.com> --- Owen Leonard and Marcel de Rooy agree with my understanding of adding system preferences, as far as I can tell. I'm going to mark this Failed QA. Also, could you give me an ISBN of something that should work with your patch? Or perhaps a Coce server? I'd include that in your test plan. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #43 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Frédéric Demians from comment #42)

I can alternatively propose:

[% IF Koha.Preference('CoceProviders') %] [% SET coce_id = SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn %] [% IF ( coce_id ) %] <span style="block" title="[% SEARCH_RESULT.biblionumber |url %]" class="[% coce_id %]" id="coce-thumbnail[% loop.count %]"></span> [% ELSE %] <span class="no-image">No cover image available</span> [% END %] [% END %]

I think that would work. Though, http://template-toolkit.org/docs/manual/Syntax.html#section_Implicit_Directi... implies that SET is not necessary. Remember, this type of fix is required in more than one location in the code. :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32891|0 |1 is obsolete| | --- Comment #45 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32929&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - Check that Browse Shelf functionnality works properly. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. - You can try with those sysprefs: CoceProviders: aws,gb CoceHost: coce.tamil.fr:8080 and this EAN (or ISBN): 3333297517744 => OPACAmazonCoverImages enabled doesn't display a cover because, it's a DVD => Coce find and display the DVD cover. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #47 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32942&action=edit MARC21 DVD biblio records It's an MARC21 ISO2709 file, containing about 700 biblios describing DVD. The records are roughly converted from Unimarc to Marc21. So I can't guaranty they are perfect. But you will have EAN in 024 ou 020 field, not ISBN. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #49 from M. Tompsett <mtompset@hotmail.com> --- I set up a fresh Unimarc git and used my sample Unimarc data, and I could not get it to work. :( -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #51 from Frédéric Demians <frederic@tamil.fr> --- (In reply to M. Tompsett from comment #50)

(In reply to M. Tompsett from comment #49)

...

I set up a fresh Unimarc git and used my sample Unimarc data, and I could not get it to work. :(

I was attempting to firebug the javascript. For some reason success is never triggered on my VM's, but it is on your server. Also, the coce URL is different. But this is too late to try to make further sense of it.

Does the GoogleBooks functionality works properly on you VM? GoogleBooks and Coce JavaScript code is similar, with JSONP and code injection. Hypothesis: Your Koha is a VM running inside your PC-Windows. For your browser, your JS code is originating from your box, and is trying to get JavaScript from another site (Coce server). This is different from testing from a server on the Internet (my devel box). Two solutions: (1) you modify your security policy (Windows, or Virtualisation level), (2) you test from a Koha on the Internet (sandbox). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #53 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #54 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 33201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33201&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - Check that Browse Shelf functionnality works properly. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. - You can try with those sysprefs: CoceProviders: aws,gb CoceHost: coce.tamil.fr:8080 and this EAN (or ISBN): 3333297517744 => OPACAmazonCoverImages enabled doesn't display a cover because, it's a DVD => Coce find and display the DVD cover. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #56 from Frédéric Demians <frederic@tamil.fr> --- I'd like to thank you, Mark, for your tenacity. Your remarks, critics and guidance make a difference, and help a lot to get a polished result which comply with Koha standard. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |unspecified -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33201|0 |1 is obsolete| | --- Comment #61 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 34678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34678&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - Check that Browse Shelf functionnality works properly. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. - You can try with those sysprefs: CoceProviders: aws,gb CoceHost: http://coce.tamil.fr:8080 and this EAN (or ISBN): 3333297517744 => OPACAmazonCoverImages enabled doesn't display a cover because, it's a DVD => Coce find and display the DVD cover. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #64 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Frédéric Demians from comment #62)

(In reply to Jonathan Druart from comment #60)

...

I tried to host the webservice, and it worked until I got this error:

% node webservice.js

/home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:78 if (err) throw err; ^ Error: metadata API response undefined at ClientRequest.<anonymous> (/home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:37:49) at ClientRequest.g (events.js:180:16) at ClientRequest.emit (events.js:92:17) at Socket.emitTimeout (http.js:1797:10) at Socket.g (events.js:180:16) at Socket.emit (events.js:92:17) at Socket._onTimeout (net.js:326:8) at Timer.unrefTimeout [as ontimeout] (timers.js:418:13)

Did you already get it?

No. To track down this bug, it is required to have the ISBN/EAN which is sent to AWS.

I got it again, but it's completely random (I have got it with the same url I use). I don't know where it can come from. However, it's the only problem I got, the code is clean and all works great. Nice feature! Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I can also confirm this is working well at the koha side, and that although the coce daemon itself presents that error mentioned by Jonathan periodically it doesn't appear to affect it's overall running. Would be nice to see this one making it's way though :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #66 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm willing to push this ASAP. Two questions: - Do you think we could have a "Coce" syspref that could serve as a global switch instead of testing for CoceHost? That would make it consistent with how the rest of the enhanced content services are set in Koha. - Does Coce provide a way to set custom providers? If it doesn't, we don't need a free text syspref, could we make the CoceProviders a 'multiple' type syspref? With fixed values: aws, gb and ol? [1] I can just provide a followup implementing this changes if you want to, I only want your opinion before doing so. [1] With proper descriptions. Check OpacAdvSearchOptions on the .pref file. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #68 from Frédéric Demians <frederic@tamil.fr> ---

I'm willing to push this ASAP. Two questions:

+1

- Do you think we could have a "Coce" syspref that could serve as a global switch instead of testing for CoceHost? That would make it consistent with how the rest of the enhanced content services are set in Koha.

Ok. I do it and send an amended patch.

- Does Coce provide a way to set custom providers? If it doesn't, we don't need a free text syspref, could we make the CoceProviders a 'multiple' type syspref? With fixed values: aws, gb and ol? [1]

For the time being, Coce support only 3 images providers. But the system is designed to be extended, so it can change in the future. I'd recommend not to impose choices in Koha system preference. Forcing choices would prevent using new providers as soon as available. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We could perhaps add a route to lookup available providers on the specified coce server? That would allow koha's syspref to be 'clever' about presenting the available provider for your specific coce server. I say this as for instance in the UK, I'm rather tempted to write a BDS connector for coce.. but BDS is uk only, so our coce instance would support it but others may not. Any thoughts Frederic? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd say, feel free to push as is.. I'll submit a followup to both coce and koha to show what I mean afterwards ;) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Indeed, I had a hunt around the sysprefs code in koha last night after making my suggestion and decided it would be a nightmare to implement at the koha side :( I might add a route to coce (and a pull request) anyway to get the available providers as it would perhaps be useful in the other app we're developing that uses it. I like the idea of a shared 'local image store'.. it's a shame that the OpenLibrary project is slowing as you suspect though :(. Certainly.. I'd pass qa on your followups Tomas, so I'd suggest pushing as is. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7187 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #76 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Frédéric made me aware that this one could be an alternative to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 One thing that's been a problem with cover images is the different caching policies from the providers which is of course unfortunate. Does this patch by any chance implement setting caching on/off per source to handle this? (Sorry if I'm being lazy, but searching for cach* in this thread gives a bit many hits) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #78 from Viktor Sarge <viktor.sarge@regionhalland.se> --- (In reply to Frédéric Demians from comment #77)

Viktor, Coce server is a third-party tool accessed by Koha. Coce-side, for each cover image provider, you can define a cache timeout. Another point to take into account: URL to the images are cached, not the images themselves. This can make a difference from a provider policies point of view.

Interesting! Thanks for the quick feedback. -- You are receiving this mail because: You are watching all bug changes.