[Bug 28202] New: Pickup libraries not sorted by name when placing hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Bug ID: 28202 Summary: Pickup libraries not sorted by name when placing hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When placing hold, the pickup libraries are not sorted by name but by code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120039&action=edit Bug 28202: Pickup libraries must be sorted by name when placing hold When placing hold, the pickup libraries are not sorted by name but by code. You can see in other places : pickup_locations() calls Koha::Libraries->search with { order_by => ['branchname'] } Test plan : 1) Go to staff interface 2) Create a new libary with code 'AAA' and name 'ZZZ'. 2) Select a record 3) Begin placing hold 4) Look at list in "Pickup at:" => Without patch library 'ZZZ' is first => With patch library 'ZZZ' is last -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Test coverage is missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120049&action=edit Bug 28202: Unit test Run prove t/db_dependent/Koha/Biblio.t Note that sort must be case insensitive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120039|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120050&action=edit Bug 28202: Pickup libraries must be sorted by name when placing hold When placing hold, the pickup libraries are not sorted by name but by code. You can see in other places : pickup_locations() calls Koha::Libraries->search with { order_by => ['branchname'] } Test plan : 1) Go to staff interface 2) Create a new libary with code 'AAA' and name 'ZZZ'. 2) Select a record 3) Begin placing hold 4) Look at list in "Pickup at:" => Without patch library 'ZZZ' is first => With patch library 'ZZZ' is last -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120049|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 120142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120142&action=edit Bug 28202: Unit test Run prove t/db_dependent/Koha/Biblio.t Note that sort must be case insensitive. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120050|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 120143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120143&action=edit Bug 28202: Pickup libraries must be sorted by name when placing hold When placing hold, the pickup libraries are not sorted by name but by code. You can see in other places : pickup_locations() calls Koha::Libraries->search with { order_by => ['branchname'] } Test plan : 1) Go to staff interface 2) Create a new libary with code 'AAA' and name 'ZZZ'. 2) Select a record 3) Begin placing hold 4) Look at list in "Pickup at:" => Without patch library 'ZZZ' is first => With patch library 'ZZZ' is last Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (koha-testing-docker): - I initially thought the sort order was working correctly before apply the patch - However, koha-testing-docker sample data is nice and orderly and library codes and library names will display in the correct alphabetical order by either code or library name - For testing I created libraries using code AAA for a library called 'Z Library', for code ZZZ for a library called "A Library" - Then you can see that it is sorting by the library code rather than the library name before the patch is applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This corrects the sort release notes| |order for library names for | |the pickup list when | |placing a hold. The list of | |libraries now sorts by | |library name, instead of | |the library code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120142|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120236&action=edit Bug 28202: Unit test Run prove t/db_dependent/Koha/Biblio.t Note that sort must be case insensitive. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120143|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120237&action=edit Bug 28202: Pickup libraries must be sorted by name when placing hold When placing hold, the pickup libraries are not sorted by name but by code. You can see in other places : pickup_locations() calls Koha::Libraries->search with { order_by => ['branchname'] } Test plan : 1) Go to staff interface 2) Create a new libary with code 'AAA' and name 'ZZZ'. 2) Select a record 3) Begin placing hold 4) Look at list in "Pickup at:" => Without patch library 'ZZZ' is first => With patch library 'ZZZ' is last Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice improvement, thanks Fridolin.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 26925 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org