[Bug 22914] New: Batch Item Delete column misconfigured when using show/hide tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Bug ID: 22914 Summary: Batch Item Delete column misconfigured when using show/hide tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- When using the batch delete tool the show/hide columns checkboxes are misconfigured. Instead of hiding/showing the proper column the column immediately to the right is instead hidden. This effects master and 18.11.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Depends on| |19490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 89785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89785&action=edit Bug 22914: Batch Item Delete column misconfigured when using show/hide tool TEST PLAN: 1. Go to Tools > Batch item deletion and enter at least one barcode. 2. Try to hide a column that is showing 3. Notice it hides the wrong column 4. apply patch 5. repeat steps 1 and 2. 6. Notice the correct column is being hidden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89785|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 89787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89787&action=edit Bug 22914: Batch Item Delete column misconfigured when using show/hide tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- attachment 89787 fixes a bad filter, the test plan remains the same. TEST PLAN: 1. Go to Tools > Batch item deletion and enter at least one barcode. 2. Try to hide a column that is showing 3. Notice it hides the wrong column 4. apply patch 5. repeat steps 1 and 2. 6. Notice the correct column is being hidden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 89788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89788&action=edit Bug 22742: ILS-DI - Fix datetime format returned by RenewLoan Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89788|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 89789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89789&action=edit Bug 22742: ILS-DI - Fix datetime format returned by RenewLoan Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22914 Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89787|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 89790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89790&action=edit Bug 22914: Batch Item Delete column misconfigured when using show/hide tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Attachment #89789|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Applying: Bug 22914: Batch Item Delete column misconfigured when using show/hide tool error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please provide a patch for master, Lucas. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89790|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 89796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89796&action=edit Bug 22914: Batch Item Delete column misconfigured when using show/hide tool TEST PLAN: 1. Go to Tools > Batch item deletion and enter at least one barcode. 2. Try to hide a column that is showing 3. Notice it hides the wrong column 4. apply patch 5. repeat steps 1 and 2. 6. Notice the correct column is being hidden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8132 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Lucas, You are doing much more that what is advertised. A new column is added (the one added by bug 19490). See also bug 8132. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- The changes on 19490 caused this, the two templates share a js file, and the data passed is the same. Adding the column to the template brings things back into alignment, the data is already there, we just show it. We could leave out the whitespace changes, but I think they make it much easier to read Ultimately the item display should be an include used by both templates, but adding the column now seems a better idea than adding logic to the js to act differently in the two pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes Nick, it is exactly why I let this comment. With more info I wouldn't have needed to look after them :) And also why I linked it with bug 8132. People seems to want this info (number of holds) on this page. I was asking to advertise it, like it was a new enhancement, not only a 'misalignment bug'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks Jonathan. I will be more precise with advertisement in the future. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89796|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 89869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89869&action=edit Bug 22914: Batch Item Delete column misconfigured when using show/hide tool Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lucas Gass from comment #13)
Thanks Jonathan. I will be more precise with advertisement in the future. :)
Why in the future when you can start now? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a hard one, because I really want to pass it, but I feel it's not quite right yet. :( As this is a bug report for a specific problem that also appears in 18.11, it is suited for backporting. But as it adds a new column, this is also an enhancement (with translation changes too), so it would not be backported. Also: because this only advertises the bug fix, we would not alert the libraries about the new feature in the release notes. Lucas, would you be willing to please split this into 2 separate bugs? One for the fix and one for the new feature? The heavy reindentation also makes it hard to read, having that in a first patch and the actual fix in a second patch would also make my life easier! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch Item Delete column |Add holds column to batch |misconfigured when using |item delete to fix |show/hide tool |show/hide columns behaviour --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, seeing the discussion now. I still feel this puts us in a little bit of a hard place release notes wise :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90139&action=edit Bug 22914: Add holds column to batch item delete to fix show/hide columns behaviour The changes on 19490 caused a bug, where the show/hide column feature hides the wrong column on the items table. The two templates share a js file, and the data passed is the same. Adding the column to the template brings things back into alignment, the data is already there, we just show it. TEST PLAN: 1. Go to Tools > Batch item deletion and enter at least one barcode. 2. Try to hide a column that is showing 3. Notice it hides the wrong column 4. apply patch 5. repeat steps 1 and 2. 6. Notice the correct column is being hidden 7. Verify the new column for number of holds on the item works correctly for item and record level holds Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I decided to pass this after fixing up the bug title and commit message. Lucas, please always include a description of the problem and the most current test plan in your commit messages! Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.06 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org