http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7980 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9248&action=edit Bug 7980 - Group search results tag input with other actions This patch hides the tag input form in OPAC search results when TagsInputOnList is turned on. An "Add tag" is added to the "Actions" line. Clicking the link un-hides the tag input form. A "Cancel" link hides it again. The patch also moves the display of ratings to the bottom of the list so that existing tags are grouped with the other title details which are prefixed with a label ("Type:", "Availability", etc.). To test, enable the TagsInputOnList system preference. Do a search and try adding tags from the search results list. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7980 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9248|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9417&action=edit Bug 7980: [SIGNED-OFF] Group search results tag input with other actions This patch is more ergonomic for tags in search results. But I think a followup is required: 1/ The 'enter' action reload the page (whereas in the opac detail, this action adds the tag). 2/ Isn't it better to clean the input after submitting ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7980 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #3)

But I think a followup is required: 1/ The 'enter' action reload the page (whereas in the opac detail, this action adds the tag).

I didn't notice this problem, but now that I'm testing I see it's a bug in master too. I'll investigate a fix for it and leave it up to QA to decide whether it should block this patch.

2/ Isn't it better to clean the input after submitting ?

I think so, but I would like to make this change in conjunction with a fix for Bug 5174. Clearing the submitted tag without offering some kind of confirmation of what tags were added seems unfriendly to me. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7980 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9417|0 |1 is obsolete| | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 9779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9779&action=edit [PASSED_QA] Patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7980 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- A valuable ENH ! -- You are receiving this mail because: You are watching all bug changes.