[Bug 30063] New: Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Bug ID: 30063 Summary: Make the main patron search use the /patrons REST API route Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30055 |30094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 [Bug 30094] Rewrite some of the patron searches when requesting an article with the REST API route -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/-/tree/bug_30063 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130608&action=edit Bug 30063: Number of checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130609&action=edit Bug 30063: Overdues count -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130610&action=edit Bug 30063: Make the main patron search use the REST API To test: * Length menu (PatronsPerPage) * Query description * Highlight of the current library * sticky header - Does not work (?) If the table does not show when you submit the filter form, make sure you regenerated the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130611&action=edit Bug 30063: Remove svc/members/search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130612&action=edit Bug 30063: Remove occurrences of C4::Utils::DataTables::Members -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130613&action=edit Bug 30063: Fix address format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130614&action=edit Bug 30063: Add kind of POD for the include file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130615&action=edit Bug 30063: Display search description for main search only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |oleonard@myacpl.org, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130608|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130609|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130610|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130611|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130613|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130615|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please use the remote branch for testing, it contains all the tree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30098 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Merge conflict on koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Because of Bug 29136 pushed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- In patrons search page /cgi-bin/koha/members/members-home.pl it removes : Browse by last name: A B C D ... And when searching I get no results table o_O I see the API call in network tought. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #10)
Merge conflict on koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Because of Bug 29136 pushed
Remote branch rebased. (In reply to Fridolin Somers from comment #11)
In patrons search page /cgi-bin/koha/members/members-home.pl it removes : Browse by last name: A B C D ...
I am seeing it.
And when searching I get no results table o_O I see the API call in network tought.
See the commit message: "If the table does not show when you submit the filter form, make sure you regenerated the compiled CSS." You need to `yarn build css` and refresh your browser's cache. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ahhh thanks, it works. Looks great :D Some feedbacks : 1) When arriving in patrons home page without searching : /cgi-bin/koha/members/members-home.pl We see the header with 'Select all' 'Clear all' ... This fells odd. We may hide it like in current master. 2) Why not keeping 'Browse by last name: A B ...' on top of header 'Select all' 'Clear all' ... ? 3) Perform a search with some text in left form. Click on a letter of 'Browse by last name'. Note that search text is not removed in left form like in current master. We may also clear form in page header, but keeping it is the current behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #13)
Ahhh thanks, it works. Looks great :D
Some feedbacks :
1) When arriving in patrons home page without searching : /cgi-bin/koha/members/members-home.pl We see the header with 'Select all' 'Clear all' ... This fells odd. We may hide it like in current master.
I didn't manage to hide it. When it's hidden the "sticky" behaviour is broken (see patch "Fix sticky")
2) Why not keeping 'Browse by last name: A B ...' on top of header 'Select all' 'Clear all' ... ?
Because I had to rebuild a bit how the "blocks" are ordered. The header with actions (select/clear all, add to list, merge) is only available from the main patron search, when the "browse by" is available for all patron searches. It was easier to then in the "browse by" code into the include file. We can certainly change the order if there is a real need, but it will make the code a bit more complex then.
3) Perform a search with some text in left form. Click on a letter of 'Browse by last name'. Note that search text is not removed in left form like in current master.
Don't you think this behaviour is better?
We may also clear form in page header, but keeping it is the current behavior.
When? I wouldn't modify another form, that would feel weird. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- 1) 2) OK, this is minor. 3) OK we will see if other feed-backs see it. Keeping input terms allows to rerun search, it can be a feature not a bug ;) I sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #15)
1) 2) OK, this is minor.
3) OK we will see if other feed-backs see it. Keeping input terms allows to rerun search, it can be a feature not a bug ;)
I sign off.
Thanks Frido! Does it mean you signoff on the whole tree? This bug depends on several others that are not signed off yet :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Yep looks strong enough to sign. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ahhh the tree contains several bugs not yet signed, I revert -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 29125 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 26865 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132387&action=edit Bug 30063: Fix table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |arthur.suzuki@biblibre.com --- Comment #22 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- patch doesn't apply on master, although all dependencies do apply properly :) <pre> 132387 - Bug 30063: Fix table settings Application de Bug 30063: Fix table settings Utilisation de l'information de l'index pour reconstruire un arbre de base... M koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Retour à un patch de la base et fusion à 3 points... Fusion automatique de koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt CONFLIT (contenu) : Conflit de fusion dans koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt error: Échec d'intégration des modifications. l'application de la rustine a échoué à 0001 Bug 30063: Fix table settings astuce: Utilisez 'git am --show-current-patch=diff' pour visualiser le patch en échec When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-30063-Fix-table-settings-7voPZp.patch </pre> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #23 from Séverine Queune <severine.queune@bulac.fr> --- This is a first feedback about the member-home.pl page only, tested using the branch available on Joubu's GitLab. 1) About Frido's point 3, I completely agree with the new behaviour that keeps the search performs in the form and then filters the results. As an example, at BULAC, we have plenty of homonyms specifically for Asiatic short names that can be used as firstname or family name and it can be really difficult sometimes to find someone. Having a new way to refine the search is really useful. 2) Sorting by 'Name' isn't logical for a user like me : the table display surname then firstname but sorting uses firstname then surname 3) Some special signs need to be escaped to be search, like % or _ Probably not related to this patch, but searching for % searches for not NULL datas. On 'Notes' filter column e.g., it bring some unexpected results displaying patrons without any circulation notes just because the SQL field is not NULL. 4) I had some strange behaviours using the column filters or general search : many times, the search only applied when I kind of 'refresh' the table by sorting it (see https://snipboard.io/6EGyV8.jpg) To reproduce : enter your search very quickly in the search box or filter box ; see that many results are not supposed to be here. 5) Hiding a column in table setting introduces a bug : the filter doesn't search the data in the selected column but the data of the column just on the left : see screenshots - https://snipboard.io/JAdjup.jpg : column 'Card' hidden, filter 'Date' search for the name - https://snipboard.io/1gb9Kq.jpg : column 'Card' hidden, filter 'Name' search for the card - https://snipboard.io/RKB4ip.jpg : column 'Card' hidden, filter 'Checkouts' search for the expiration date - https://snipboard.io/DBX5Ve.jpg : column 'Name' hidden, filter 'Date' search for the name You can also notice on these screenshots that there is some wrong with filter for it's not supposed to exists for the 'Checkout' and 'Actions' columns, and there is no more filter for 'Notes'. 6) It's not possible to got back to the form search if the results bring a unique result : the form reloaded automatically and bring us back to the patron account. This is not the behaviour in master and I feel uncomfortable with that change. 7) On side search form, 'Search type' = 'Starts with' doesn't work for none of the 'Search field' I tried (cardnumber, address, firstname, surname). 8) The patch doesn't work for users with only 'edit_borrowers' or 'view_borrower_infos_from_any_libraries' permissions : the full 'borrowers' permission seems to be needed to display results All the other points (Length menu, query description, highlight of the current library) are ok expect for length menu displaying two times '20 results' but I'll fill another bug as it's already existing in master and 20.11.11). I'll feedback about the other tables in the dedicated bugs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132387|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30404 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 [Bug 30404] Enlarge all patron searches pop-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30405 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30405 [Bug 30405] Style of address in patron search result are 110% -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30393, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30394 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132552&action=edit Bug 30063: Sort by "Name" firstname,surname As it's how it's displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Séverine Queune from comment #23)
This is a first feedback about the member-home.pl page only, tested using the branch available on Joubu's GitLab.
1) About Frido's point 3, I completely agree with the new behaviour that keeps the search performs in the form and then filters the results. As an example, at BULAC, we have plenty of homonyms specifically for Asiatic short names that can be used as firstname or family name and it can be really difficult sometimes to find someone. Having a new way to refine the search is really useful.
Thanks for the feedback!
2) Sorting by 'Name' isn't logical for a user like me : the table display surname then firstname but sorting uses firstname then surname
Fixed! Bug 30063: Sort by "Name" firstname,surname
3) Some special signs need to be escaped to be search, like % or _ Probably not related to this patch, but searching for % searches for not NULL datas. On 'Notes' filter column e.g., it bring some unexpected results displaying patrons without any circulation notes just because the SQL field is not NULL.
Bug 30393.
4) I had some strange behaviours using the column filters or general search : many times, the search only applied when I kind of 'refresh' the table by sorting it (see https://snipboard.io/6EGyV8.jpg) To reproduce : enter your search very quickly in the search box or filter box ; see that many results are not supposed to be here.
Bug 30394.
5) Hiding a column in table setting introduces a bug : the filter doesn't search the data in the selected column but the data of the column just on the left : see screenshots - https://snipboard.io/JAdjup.jpg : column 'Card' hidden, filter 'Date' search for the name - https://snipboard.io/1gb9Kq.jpg : column 'Card' hidden, filter 'Name' search for the card - https://snipboard.io/RKB4ip.jpg : column 'Card' hidden, filter 'Checkouts' search for the expiration date - https://snipboard.io/DBX5Ve.jpg : column 'Name' hidden, filter 'Date' search for the name You can also notice on these screenshots that there is some wrong with filter for it's not supposed to exists for the 'Checkout' and 'Actions' columns, and there is no more filter for 'Notes'.
Opened bug 30406.
6) It's not possible to got back to the form search if the results bring a unique result : the form reloaded automatically and bring us back to the patron account. This is not the behaviour in master and I feel uncomfortable with that change.
Not sure it's fixed, I am getting an error on Firefox but it's working on Chromium. Bug 30063: Restore back behaviour
7) On side search form, 'Search type' = 'Starts with' doesn't work for none of the 'Search field' I tried (cardnumber, address, firstname, surname).
Fixed! Bug 30063: Fix start with
8) The patch doesn't work for users with only 'edit_borrowers' or 'view_borrower_infos_from_any_libraries' permissions : the full 'borrowers' permission seems to be needed to display results
Fixed! Bug 30063: Fix permission for GET /patrons
All the other points (Length menu, query description, highlight of the current library) are ok expect for length menu displaying two times '20 results' but I'll fill another bug as it's already existing in master and 20.11.11).
I'll feedback about the other tables in the dedicated bugs.
Thanks a lot! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132552|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #26 from Séverine Queune <severine.queune@bulac.fr> --- Thanks a lot Jonathan ! I fail the patch once again as the sorting by surname then firstname doesn't work. I've got the same problem on point 6 : it works with Chromium but not Firefox. Weird... All the other points related to this specific bugs are fixed :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #25)
(In reply to Séverine Queune from comment #23)
2) Sorting by 'Name' isn't logical for a user like me : the table display surname then firstname but sorting uses firstname then surname
Fixed! Bug 30063: Sort by "Name" firstname,surname
Replaced by Bug 30063: Sort by "Name" surname:firstname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Séverine Queune from comment #26)
Thanks a lot Jonathan !
I fail the patch once again as the sorting by surname then firstname doesn't work.
I've got the same problem on point 6 : it works with Chromium but not Firefox. Weird...
All the other points related to this specific bugs are fixed :)
Should be fixed now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #29 from Séverine Queune <severine.queune@bulac.fr> --- Tested using Joubu's branch, everything seems fixed ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132731&action=edit Bug 30063: Number of checkouts Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132732&action=edit Bug 30063: Overdues count Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132733&action=edit Bug 30063: Make the main patron search use the REST API To test: * Length menu (PatronsPerPage) * Query description * Highlight of the current library * sticky header - Does not work (?) If the table does not show when you submit the filter form, make sure you regenerated the compiled CSS. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132734&action=edit Bug 30063: Remove svc/members/search Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132735&action=edit Bug 30063: Remove occurrences of C4::Utils::DataTables::Members Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132736&action=edit Bug 30063: Fix address format Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132737&action=edit Bug 30063: Add kind of POD for the include file Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132738&action=edit Bug 30063: Display search description for main search only Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132739&action=edit Bug 30063: Fix selenium tests Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132740&action=edit Bug 30063: Fix sticky Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132741&action=edit Bug 30063: Add selenium tests Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132742&action=edit Bug 30063: Be more flexible for filters On later follow-ups (ERM) we need to filter columns that contain AVs, and so be more flexible. Here we are expecting a _id and _str keys we are gonna use to build the select's options Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132743&action=edit Bug 30063: Fix table settings Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132744&action=edit Bug 30063: Sort by "Name" firstname,surname As it's how it's displayed Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132745&action=edit Bug 30063: Restore back behaviour Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132746&action=edit Bug 30063: Fix start with It was doing "end with"... Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132747&action=edit Bug 30063: Fix permission for GET /patrons edit_borrowers should be enough, we don't need the whole borrowers module flag Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132748&action=edit Bug 30063: Sort by "Name" surname:firstname Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132749&action=edit Bug 30063: Fix QA issues Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've spoken to Severine and she tells me she's already highlighted one issue but we both agree it can be handled as a distinct bug.. I'll report it and add screenshots of before and after to highlight the issue Otherwise, this is great again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30416 [Bug 30416] Patron search results page UX fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132731|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132759&action=edit Bug 30063: Number of checkouts Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132732|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132760&action=edit Bug 30063: Overdues count Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132733|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132761&action=edit Bug 30063: Make the main patron search use the REST API To test: * Length menu (PatronsPerPage) * Query description * Highlight of the current library * sticky header - Does not work (?) If the table does not show when you submit the filter form, make sure you regenerated the compiled CSS. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132734|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132762&action=edit Bug 30063: Remove svc/members/search Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132735|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132763&action=edit Bug 30063: Remove occurrences of C4::Utils::DataTables::Members Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132736|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132764&action=edit Bug 30063: Fix address format Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132737|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132765&action=edit Bug 30063: Add kind of POD for the include file Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132738|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132766&action=edit Bug 30063: Display search description for main search only Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132739|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132767&action=edit Bug 30063: Fix selenium tests Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132740|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132768&action=edit Bug 30063: Fix sticky Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132741|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132769&action=edit Bug 30063: Add selenium tests Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132742|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132770&action=edit Bug 30063: Be more flexible for filters On later follow-ups (ERM) we need to filter columns that contain AVs, and so be more flexible. Here we are expecting a _id and _str keys we are gonna use to build the select's options Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132743|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132771&action=edit Bug 30063: Fix table settings Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132744|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132772&action=edit Bug 30063: Sort by "Name" firstname,surname As it's how it's displayed Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132745|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132773&action=edit Bug 30063: Restore back behaviour Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132746|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132774&action=edit Bug 30063: Fix start with It was doing "end with"... Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132747|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132775&action=edit Bug 30063: Fix permission for GET /patrons edit_borrowers should be enough, we don't need the whole borrowers module flag Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132748|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132776&action=edit Bug 30063: Sort by "Name" surname:firstname Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132749|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132777&action=edit Bug 30063: Fix QA issues Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I can't find any hard regressions.. minor UX changes and tweeks yes, but not real breakage. This gives us some great foundations to continue improving upon.. I'd like to see things like the 'overdues' alias for 'get_overdues' actually progress to just replace the 'get_overdues' method instead.. and I'd love to see that same method turned into a relationship at the dbic level to benefit from dbic query handling. But.. generally I'm more than happy to PQA on this... I'll add bugs to record my other thougths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30420 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420 [Bug 30420] We don't need Koha::Patron::get_overdues AND ::overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #70 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 | released in| | --- Comment #71 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks to everybody involved in this huge patch series! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455 [Bug 30455] Incorrect template filter breaks holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #72 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132958&action=edit Bug 30063: (follow-up) Fix missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30406 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #73 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Bug 30063: (follow-up) Fix missing TT filters Was also missing : $("#[% sticky_header | html %]").show(); I've added my commit : c636b39a89 Bug 30063: Fix missing TT filters Then yours : 5fdfed1ee5 Bug 30063: (follow-up) Fix missing TT filters
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485 [Bug 30485] Searching all patrons from the header does not display the patron search view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Bug 30063 depends on bug 30094, which changed state. Bug 30094 Summary: Rewrite the patron search when requesting an article with the REST API route https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576 [Bug 30576] DefaultPatronSearchFields no longer takes effect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- patrons_search.t selenium test is failing and I'm not entirely sure why :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30607 [Bug 30607] Enable 'Clear filter' option on DataTables Search for patron searches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 [Bug 30622] Search for cardnumber needs to go directly to patron record when placing a hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30626 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #75 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #74)
patrons_search.t selenium test is failing and I'm not entirely sure why :(
Fixed on bug 30626. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639 [Bug 30639] Patron search does not find patrons if passed first and last name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30578 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31229 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229 [Bug 31229] column visibility broken on patron search view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31530 [Bug 31530] HTML tags in TT comments in patron-search.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 [Bug 32491] Can no longer search patrons in format 'surname, firstname' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32770 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 [Bug 32770] Patron search field groups no longer exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk@ckls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33395 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|madamyk@ckls.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35629 [Bug 35629] Redundant code in includes/patron-search.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36302 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30639 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639 [Bug 30639] Patron search does not split search terms -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org