[Bug 37713] New: OAI-PMH - Honour OpacSuppression syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Bug ID: 37713 Summary: OAI-PMH - Honour OpacSuppression syspref Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Currently, records hidden with OpacSuppression still appear in the OAI-PMH output. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 [Bug 31161] OAI-PMH - Honour OpacHiddenItems sysprefs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |ASSIGNED Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I may as well mark myself as assignee for this too... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Bug 37713 depends on bug 31161, which changed state. Bug 31161 Summary: OAI-PMH - Honour OpacHiddenItems system preferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |koha-bugs@lists.koha-commun | |ity.org --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Going to reset Assignee for now, since this is very low on my list of priorities at the moment... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |dcook@prosentient.com.au |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 179090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179090&action=edit Bug 37713: Do not show record metadata if OPAC suppressed This change checks the 942$n if OpacSuppression is enabled, and does not return the record metadata if 942$n is true. See BZ 31161. Test plan: 0. Apply the patch 1. koha-plack --restart kohadev 2. Enable syspref "OAI-PMH" 3. Set syspref "OpacSuppression" to "Hide" 4. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 5. Note KOHA-OAI-TEST:2 metadata visible 6. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 7. Set 942$n to "Yes" 8. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 9. Note KOHA-OAI-TEST:2 metadata no longer visible and instead "Record Status: deleted" shows -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179090|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179091&action=edit Bug 37713: Do not show record metadata if OPAC suppressed This change checks the 942$n if OpacSuppression is enabled, and does not return the record metadata if 942$n is true. See BZ 31161. Test plan: 0. Apply the patch 1. koha-plack --restart kohadev 2. Enable syspref "OAI-PMH" 3. Set syspref "OpacSuppression" to "Hide" 4. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 5. Note KOHA-OAI-TEST:2 metadata visible 6. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 7. Set 942$n to "Yes" 8. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 9. Note KOHA-OAI-TEST:2 metadata no longer visible and instead "Record Status: deleted" shows Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39337 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39337 [Bug 39337] Use SQL field to apply OpacSuppression in OAI-PMH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38330 Status|Signed Off |Failed QA --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I'm going to fail this and make bug 38330 a dependency Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 [Bug 38330] Make bib-level suppression a biblio table field instead of part of a marc tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Yay.. bug 38330 is now pushed David :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179091|0 |1 is obsolete| | --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Created attachment 188184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188184&action=edit Bug 37713: Do not show record metadata if OPAC suppressed This change checks the 942$n if OpacSuppression is enabled, and does not return the record metadata if 942$n is true. See BZ 31161. Test plan: 0. Apply the patch 1. koha-plack --restart kohadev 2. Enable syspref "OAI-PMH" 3. Set syspref "OpacSuppression" to "Hide" 4. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 5. Note KOHA-OAI-TEST:2 metadata visible 6. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 7. Set 942$n to "Yes" 8. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 9. Note KOHA-OAI-TEST:2 metadata no longer visible and instead "Record Status: deleted" shows -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize (ashimema) from comment #6)
Yay.. bug 38330 is now pushed David :)
I'd totally forgotten that this was my patch... heh -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188184|0 |1 is obsolete| | --- Comment #9 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 190654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190654&action=edit Bug 37713: Do not show record metadata if OPAC suppressed This change checks the 942$n if OpacSuppression is enabled, and does not return the record metadata if 942$n is true. See BZ 31161. Test plan: 0. Apply the patch 1. koha-plack --restart kohadev 2. Enable syspref "OAI-PMH" 3. Set syspref "OpacSuppression" to "Hide" 4. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 5. Note KOHA-OAI-TEST:2 metadata visible 6. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 7. Set 942$n to "Yes" 8. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 9. Note KOHA-OAI-TEST:2 metadata no longer visible and instead "Record Status: deleted" shows Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- I keep forgetting this isn't in Koha yet O_O -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197482&action=edit Bug 37713: Do not show record metadata if OPAC suppressed This change checks the 942$n if OpacSuppression is enabled, and does not return the record metadata if 942$n is true. See BZ 31161. Test plan: 0. Apply the patch 1. koha-plack --restart kohadev 2. Enable syspref "OAI-PMH" 3. Set syspref "OpacSuppression" to "Hide" 4. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 5. Note KOHA-OAI-TEST:2 metadata visible 6. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 7. Set 942$n to "Yes" 8. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 9. Note KOHA-OAI-TEST:2 metadata no longer visible and instead "Record Status: deleted" shows Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197483&action=edit Bug 37713: (QA follow-up) Add unit tests Add tests for OpacSuppression handling in OAI-PMH get_biblio_marcxml(), covering the full preference/flag matrix: - Preference disabled, flag set: record returned - Preference enabled, flag unset: record returned - Preference enabled, flag set: record hidden - Preference disabled again: record returned Also cleans up stray 'use DDP' and extracts a _build_repository() helper to reduce duplication. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |OAI-PMH now respects the submission| |OpacSuppression system | |preference. Records marked | |as OPAC-suppressed are no | |longer exposed via | |OAI-PMH harvesting when | |OpacSuppression is enabled. | |Previously, only the | |OpacHiddenItems check was | |applied; the suppression | |flag wa -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Enhancement - not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org