[Bug 8890] New: Packages can't be built on master, db dependent test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Priority: P5 - low Change sponsored?: --- Bug ID: 8890 CC: robin@catalyst.net.nz Assignee: koha-bugs@lists.koha-community.org Summary: Packages can't be built on master, db dependent test Severity: blocker Classification: Unclassified OS: All Reporter: chris@bigballofwax.co.nz Hardware: All Status: NEW Version: master Component: Packaging Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12739&action=edit Bug 8890 - C4::Holdsqueue is db dependent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12843&action=edit Bug 8890: C4/HoldsQueue requires DB This counter-patch moves all database handling code into subroutines in C4::HoldsQueue. This fixes the test, and is required for persistent environments like Plack. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12844&action=edit Bug 8890: don't try to load DB-dependent modules Both C4::Members::Statistics and Koha::Borrower::Files use the database in their BEGIN {} blocks, which breaks the package build process. This patch causes them to be skipped in the 00-load test. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8924 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12844|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12846&action=edit Bug 8890: don't try to load DB-dependent modules C4::Members::Statistics uses the database in its BEGIN {} block, which breaks the package build process. This patch causes it to be skipped in the 00-load test. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12847&action=edit Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN This patch removes the usage of the database in Koha::Borrower::Files' BEGIN block. It also removes the export-related declarations, since they were unused, and unnecessary in a module called in an object-oriented fashion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12739|0 |1 is obsolete| | Attachment #12843|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12872&action=edit Bug 8890: C4/HoldsQueue requires DB This counter-patch moves all database handling code into subroutines in C4::HoldsQueue. This fixes the test, and is required for persistent environments like Plack. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12846|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12873&action=edit Bug 8890: don't try to load DB-dependent modules C4::Members::Statistics uses the database in its BEGIN {} block, which breaks the package build process. This patch causes it to be skipped in the 00-load test. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12847|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12874&action=edit Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN This patch removes the usage of the database in Koha::Borrower::Files' BEGIN block. It also removes the export-related declarations, since they were unused, and unnecessary in a module called in an object-oriented fashion. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 --- Comment #9 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 13014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13014&action=edit Bug 8890 - move two more db dependent tests * t/AuthoritiesMarc.t * t/SuggestionEngine_ExplodedTerms.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8846 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The patch for bug 8846 corrects the problem with t/SuggestionEngine_ExplodedTerms.t. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- These patchs fix the t/00-load.t test Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master The 1st patch ( Bug 8890: C4/HoldsQueue requires DB (2.19 KB, patch) ) could be pushed to 3.8 to improve Plack compatibility, I think others won't apply because related to 3.10 patches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Version|rel_3_10 |master --- Comment #13 from Robin Sheat <robin@catalyst.net.nz> --- I'll change my patch to give bug 8846 priority over it, as it fixes it properly (my goal is mostly to get things building.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 --- Comment #14 from Robin Sheat <robin@catalyst.net.nz> --- Oh, I see all patches were pushed to master. Disregard what I said there then. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8890 Bug 8890 depends on bug 8846, which changed state. Bug 8846 Summary: t/SuggestionEngine_ExplodedTerms.t sneakily uses database http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org