[Bug 38185] New: DT - replace dom with layout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Bug ID: 38185 Summary: DT - replace dom with layout Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 36640 https://datatables.net/upgrade/2#dom-property """ dom is still available in DataTables 2 (likely it will be dropped in v3 whenever that happens!), but the default CSS for DataTables has been updated for layout and does not include styling for dom. If you need to continue using dom, you will likely need to add some CSS to position the elements as you need. However, you are strongly encouraged to update to using layout. """ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36640 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38301 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Bug 38185 depends on bug 36640, which changed state. Bug 36640 Summary: Upgrade DataTables from 1.13.6 to 2.x https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184796&action=edit Bug 38185: wip -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184796|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184797&action=edit Bug 38185: wip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184805&action=edit Bug 38185: Reintroduce .top.pager, .table_entries and .table_controls -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184805|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184889&action=edit Bug 38185: Try to match current DataTable style using new layout option -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184889|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184906&action=edit Bug 38185: Try to match current DataTable style using new layout option -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #5)
Created attachment 184906 [details] [review] Bug 38185: Try to match current DataTable style using new layout option
We lost the border at the bottom: .pager.bottom { border-bottom: 1px solid #BCBCBC; And the First/Last buttons in the pagination. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184906|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184928&action=edit Bug 38185: Try to match current DataTable style using new layout option -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #6)
And the First/Last buttons in the pagination.
Paging type is now obsolete and the responsive rules for the pagination links are supposed to replace those options. The actual behavior seems a little inconsistent. https://datatables.net/reference/feature/paging.type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> ---
And the First/Last buttons in the pagination.
Correction: This was indeed a mistake in the updated CSS. We have a custom rule that hides the first and last buttons when the screen width is below a certain value. The CSS for showing the buttons was lost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197326&action=edit Bug 38185: Restore display of First/Last buttons Patch from commit a207db1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197327&action=edit Bug 38185: Remove pagingType and introduce tableType pagingType is deprecated and will be removed in DT v3 https://datatables.net/reference/option/pagingType `pagingType: full_numbers` was the default, and 'full' was used in several places full_numbers is: First, Previous, Pages numbers, Next, Last full is: First, Previous, Next, Last I don't think it makes sense to keep 'full', if there are many pages the user cannot navigate correctly. This patch remove full and makes full_numbers the default. tableType='simple' can be passed to have a simple paging. Further enhancement will be able to reuse this "tableType" for other DT's options and simplify the kohaTable option list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Trying to revive this one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197328&action=edit Bug 38185: Adjust holdings table Patch from commit 62cc34d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- This is not ready at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197329&action=edit Bug 38185: Fix the about page This is not as nice as it was before but the original implementation was wrong. If we need to restore the original display we need to move the button to a new layout function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197327|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197328|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197329|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197579&action=edit Bug 38185: Remove pagingType and introduce tableFeatures pagingType is deprecated and will be removed in DT v3 https://datatables.net/reference/option/pagingType `pagingType: full_numbers` was the default, and 'full' was used in several places full_numbers is: First, Previous, Pages numbers, Next, Last full is: First, Previous, Next, Last I don't think it makes sense to keep 'full', if there are many pages the user cannot navigate correctly. This patch removes full and makes full_numbers the default. tableFeatures can now be passed to the kohaTable constructor with a list of features to include: info, search, paging, buttons. If not passed, all features will be added. If passed but empty, none will be added. Note that the UI has slightly changed on 3 tables: admin/credit_types.tt admin/debit_types.tt members/boraccount.tt Where the filters are now above the table's wrapper container. We could restore this later, but more work is needed. It feels like a separate work where we will uniformize the filters for all tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- I think I've found a really nice way to deal with the different layouts. kohaTable now take in parameter a `tableFeatures` array that can contain the list of features to add: info, search, paging, buttons. Owen, what do you think? This is almost ready for testing. It's missing the OPAC but we can deal with it on a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 [Bug 42003] Upgrade DataTables from 2.3.4 to 2.3.7 (and FixedHeader to 4.0.6) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197645&action=edit Bug 38185: Remove pagingType and introduce tableFeatures pagingType is deprecated and will be removed in DT v3 https://datatables.net/reference/option/pagingType `pagingType: full_numbers` was the default, and 'full' was used in several places full_numbers is: First, Previous, Pages numbers, Next, Last full is: First, Previous, Next, Last I don't think it makes sense to keep 'full', if there are many pages the user cannot navigate correctly. This patch removes full and makes full_numbers the default. tableFeatures can now be passed to the kohaTable constructor with a list of features to include: info, search, paging, buttons. If not passed, all features will be added. If passed but empty, none will be added. Note that the UI has slightly changed on 3 tables: admin/credit_types.tt admin/debit_types.tt members/boraccount.tt Where the filters are now above the table's wrapper container. We could restore this later, but more work is needed. It feels like a separate work where we will uniformize the filters for all tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184797|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184928|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197326|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197645|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197646&action=edit Bug 38185: wip Patch from commit b629cb0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197647&action=edit Bug 38185: Try to match current DataTable style using new layout option Patch from commit 22c06bd -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197648&action=edit Bug 38185: Restore display of First/Last buttons Patch from commit 75be885 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197649&action=edit Bug 38185: Remove pagingType and introduce tableFeatures pagingType is deprecated and will be removed in DT v3 https://datatables.net/reference/option/pagingType `pagingType: full_numbers` was the default, and 'full' was used in several places full_numbers is: First, Previous, Pages numbers, Next, Last full is: First, Previous, Next, Last I don't think it makes sense to keep 'full', if there are many pages the user cannot navigate correctly. This patch removes full and makes full_numbers the default. tableFeatures can now be passed to the kohaTable constructor with a list of features to include: info, search, paging, buttons. If not passed, all features will be added. If passed but empty, none will be added. Note that the UI has slightly changed on 3 tables: admin/credit_types.tt admin/debit_types.tt members/boraccount.tt Where the filters are now above the table's wrapper container. We could restore this later, but more work is needed. It feels like a separate work where we will uniformize the filters for all tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197649|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199380&action=edit Bug 38185: Remove pagingType and introduce tableFeatures pagingType is deprecated and will be removed in DT v3 https://datatables.net/reference/option/pagingType `pagingType: full_numbers` was the default, and 'full' was used in several places full_numbers is: First, Previous, Pages numbers, Next, Last full is: First, Previous, Next, Last I don't think it makes sense to keep 'full', if there are many pages the user cannot navigate correctly. This patch removes full and makes full_numbers the default. tableFeatures can now be passed to the kohaTable constructor with a list of features to include: info, search, paging, buttons. If not passed, all features will be added. If passed but empty, none will be added. Note that the UI has slightly changed on 3 tables: admin/credit_types.tt admin/debit_types.tt members/boraccount.tt Where the filters are now above the table's wrapper container. We could restore this later, but more work is needed. It feels like a separate work where we will uniformize the filters for all tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Bug 38185 depends on bug 42003, which changed state. Bug 42003 Summary: Upgrade DataTables from 2.3.4 to 2.3.7 (and FixedHeader to 4.0.6) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42836 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42836 [Bug 42836] Improve our use of DataTables across the codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Strategic theme|--- |Modernisation CC| |martin.renvoize@openfifth.c | |o.uk Initiative type|--- |Epic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- The last patch doesn't apply, "error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/datatables.js)." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199380|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200906&action=edit Bug 38185: Remove pagingType and introduce tableFeatures pagingType is deprecated and will be removed in DT v3 https://datatables.net/reference/option/pagingType `pagingType: full_numbers` was the default, and 'full' was used in several places full_numbers is: First, Previous, Pages numbers, Next, Last full is: First, Previous, Next, Last I don't think it makes sense to keep 'full', if there are many pages the user cannot navigate correctly. This patch removes full and makes full_numbers the default. tableFeatures can now be passed to the kohaTable constructor with a list of features to include: info, search, paging, buttons. If not passed, all features will be added. If passed but empty, none will be added. Note that the UI has slightly changed on 3 tables: admin/credit_types.tt admin/debit_types.tt members/boraccount.tt Where the filters are now above the table's wrapper container. We could restore this later, but more work is needed. It feels like a separate work where we will uniformize the filters for all tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200923&action=edit Group filter clear button with filter field In order for the line breaks to work correctly I propose that we move the "Clear" button into the search field <div>. Unless there is a better way to do this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #26)
Created attachment 200923 [details] [review] Group filter clear button with filter field
In order for the line breaks to work correctly I propose that we move the "Clear" button into the search field <div>. Unless there is a better way to do this?
It could work, however it needs more work. The .dt-button is now outside of the .dt-buttons container and is missing some css rules (like the grey because disabled, the cursor: default vs hand) Why not adding a "x" inside the search box, like we do already in Vue forms for inputs? However it's worth noting that Chrome and Firefox does not behave identically (obviously!): Chrome already has a 'x' in the global search input when not empty (and has the focus), Firefox does not have it. So couldn't we simply add it for browsers that does not have it already? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200974&action=edit Bug 38185: Replace the 'clear' button with an icon inside the search box Patch from commit 9119c04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200975&action=edit Bug 38185: Move buttons to the right Patch from commit 6f72731 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200980&action=edit Bug 38185: (follow-up) Make clear button focusable Patch from commit 8ab2af8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 201012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201012&action=edit Bug 38185: (follow-up) Hide "First" and "Last" links at narrow widths Patch from commit 1134e9a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- I think this is looking good. Jonathan do you think we're ready to make it 'Needs signoff' ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- Owen, I've cleaned up a bit the changes: * Opened bug 42925 for the adjustment of the "clear" feature (it's not directly dependent on this dom=>layout change) * Squashed a couple of patches and adjusted commit messages * Pushed a backup version to https://gitlab.com/joubu/Koha/-/commits/old/20260626-bug_38185 Can you clarify why you removed 'justify-content' there: .dt-buttons { display: flex; flex-grow: 1; - justify-content: flex-end; - } Bug 38185: Try to match current DataTable style using new layout option I've added back in "Move buttons to the right", but maybe we do not need some other changes from the patch, like: + div.dt-layout-end { + &.dt-search-buttons { + .dt-buttons { + /* Override left margin to keep "Clear" button next to search field */ + margin-left: 0; + } + } + } + } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42925 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 [Bug 42925] Replace the 'clear' button with an icon inside the search box (global search for tables) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197646|0 |1 is obsolete| | Attachment #197647|0 |1 is obsolete| | Attachment #197648|0 |1 is obsolete| | Attachment #200906|0 |1 is obsolete| | Attachment #200923|0 |1 is obsolete| | Attachment #200974|0 |1 is obsolete| | Attachment #200975|0 |1 is obsolete| | Attachment #200980|0 |1 is obsolete| | Attachment #201012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201048&action=edit Bug 38185: DataTables - Replace 'dom' with 'layout' Patch from commit 674afff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201049&action=edit Bug 38185: Try to match current DataTable style using new layout option Patch from commit 177eaef -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201050&action=edit Bug 38185: Restore display of First/Last buttons Patch from commit 3102093 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201051&action=edit Bug 38185: Remove pagingType and introduce tableFeatures pagingType is deprecated and will be removed in DT v3 https://datatables.net/reference/option/pagingType `pagingType: full_numbers` was the default, and 'full' was used in several places full_numbers is: First, Previous, Pages numbers, Next, Last full is: First, Previous, Next, Last I don't think it makes sense to keep 'full', if there are many pages the user cannot navigate correctly. This patch removes full and makes full_numbers the default. tableFeatures can now be passed to the kohaTable constructor with a list of features to include: info, search, paging, buttons. If not passed, all features will be added. If passed but empty, none will be added. Note that the UI has slightly changed on 3 tables: admin/credit_types.tt admin/debit_types.tt members/boraccount.tt Where the filters are now above the table's wrapper container. We could restore this later, but more work is needed. It feels like a separate work where we will uniformize the filters for all tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201052&action=edit Bug 38185: Move buttons to the right Patch from commit 2f8b960 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #39 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201053&action=edit Bug 38185: (follow-up) Hide "First" and "Last" links at narrow widths Patch from commit f13458f -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 201082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201082&action=edit Bug 38185: (follow-up) Additional CSS cleanup Patch from commit 9a1b7f8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org