[Bug 41624] New: Improvements to Bug 35211
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Bug ID: 41624 Summary: Improvements to Bug 35211 Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 35211 has some problems. 1. This is hard to read/maintain: const branchcodes = { [% FOREACH key IN branchcodes.keys %] "[% key | html %]": [ [% FOREACH code IN branchcodes.$key %] "[% code | html %]"[% UNLESS loop.last %], [% END %] [% END %] ][% UNLESS loop.last %], [% END %] [% END %] }; 2. If you select Show/Hide filters on the group holdings table the table disappears. 3. other_holdings_count is counted over and over inside the loop, it isn't necessary to do so. 4. The code seems to unnecessarily touch colvis settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35211 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 [Bug 35211] Make it possible to split holdings tab using library groups in intranet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191470&action=edit Bug 41624: Improve how branchcodes are handled -This patch is an attempt to improve how we retrive branchcodes. Too much of this logic is unnesseary done in the template. -This also removed the unneeded "use Koha::Library::Group;" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191471&action=edit Bug 41624: Move other_holdings_count outside of loop so it is only calculated once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. If the pref is ON and nothing else is configured, you see that: https://snipboard.io/ZgGc7P.jpg Looks like no tab is active. 2. When a group is defined, you have the new tab. But the table on this tab has the pagination, it should not. 3. If you click "Show filters" on the new tab: "Uncaught TypeError: can't access property "DataTable", items_table is undefined" 4. ColVis on this tab uses the wrong localStorage key: DataTables_catalogue_detail_otherholdings_table So the state is not correctly restored. (ie. hide a column, reload the page: the column is visible) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improvements to Bug 35211 |Revert Bug 35211 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I'm changing the title here. We need to revert Bug 35211, there are too many problems with its implementation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191471|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192464&action=edit Bug 41624: Revert "Bug 35211: (QA follow-up) Fix counting" This reverts commit 97a022054db86f076844228e01e31e3aac045d9a. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192465&action=edit Bug 41624: Revert "Bug 35211: (QA follow-up) fix display of other results tab and move template toolkit logic outside of script array" This reverts commit c4c2a4b235ccefee0c54892c1ca1057465987918. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192466&action=edit Bug 41624: Revert "Bug 35211: Removed local items from group tabs and removed group items from other holdings tab" This reverts commit 124c6c867065d4230ffa5553ca2b629e05b269a0. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192467&action=edit Bug 41624: Revert "Bug 35211: Fixed group tab item building logic" This reverts commit 23eb2dbd39ab7f46c19b299cef3db435a9ed4b7e. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192468&action=edit Bug 41624: Revert "Bug 35211: Fix tab building" This reverts commit f438535b5cfe868784bb6881839c58242432da71. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192469&action=edit Bug 41624: Revert "Bug 35211: Set SeparateHoldingsByGroup to separate based on SeparateHoldingsBranch syspref" This reverts commit d2a0527d86e82ff1edf0c31035f5ac9da232b5fe. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192470&action=edit Bug 41624: Revert "Bug 35211: Fixed count on logged in holdings" This reverts commit 96c7eb3459770c354f59fcc1d4c22ebc4eb2a559. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192471&action=edit Bug 41624: Revert "Bug 35211: Reordered tabs in Holdings Table and fixed group tabnames" This reverts commit 5c2b0fd49689b4bdaa392fc165a8fc97c1fafa1e. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192472&action=edit Bug 41624: Revert "Bug 35211: Separate group holdings into individual tabs" This reverts commit 08045c8009c52596d8df83e5da12d9e4e9abb9ae. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192473&action=edit Bug 41624: DB update to remove the pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192464|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192466|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192468|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192469|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192472|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192724&action=edit Bug 41624: Revert bug 35211 Bug 41624: Revert "Bug 35211: (QA follow-up) Fix counting" This reverts commit 97a022054db86f076844228e01e31e3aac045d9a. Bug 41624: Revert "Bug 35211: (QA follow-up) fix display of other results tab and move template toolkit logic outside of script array" This reverts commit c4c2a4b235ccefee0c54892c1ca1057465987918. Bug 41624: Revert "Bug 35211: Removed local items from group tabs and removed group items from other holdings tab" This reverts commit 124c6c867065d4230ffa5553ca2b629e05b269a0. Bug 41624: Revert "Bug 35211: Fixed group tab item building logic" This reverts commit 23eb2dbd39ab7f46c19b299cef3db435a9ed4b7e. Bug 41624: Revert "Bug 35211: Fix tab building" This reverts commit f438535b5cfe868784bb6881839c58242432da71. Bug 41624: Revert "Bug 35211: Set SeparateHoldingsByGroup to separate based on SeparateHoldingsBranch syspref" This reverts commit d2a0527d86e82ff1edf0c31035f5ac9da232b5fe. Bug 41624: Revert "Bug 35211: Fixed count on logged in holdings" This reverts commit 96c7eb3459770c354f59fcc1d4c22ebc4eb2a559. Bug 41624: Revert "Bug 35211: Reordered tabs in Holdings Table and fixed group tabnames" This reverts commit 5c2b0fd49689b4bdaa392fc165a8fc97c1fafa1e. Bug 41624: Revert "Bug 35211: Separate group holdings into individual tabs" This reverts commit 08045c8009c52596d8df83e5da12d9e4e9abb9ae. Bug 41624: DB update to remove the pref Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192725&action=edit Bug 41624: Simplify db rev Also fix QA failures: [FAIL] installer/data/mysql/atomicupdate/bug_41624.pl FAIL file_permissions File must have the exec flag FAIL forbidden_patterns forbidden pattern: trailing space char (line 13) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Squashed the reverted commits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41566 [Bug 41566] Tidy kohaTable block - catalogue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192724|0 |1 is obsolete| | --- Comment #18 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192785&action=edit Bug 41624: Revert bug 35211 Bug 41624: Revert "Bug 35211: (QA follow-up) Fix counting" This reverts commit 97a022054db86f076844228e01e31e3aac045d9a. Bug 41624: Revert "Bug 35211: (QA follow-up) fix display of other results tab and move template toolkit logic outside of script array" This reverts commit c4c2a4b235ccefee0c54892c1ca1057465987918. Bug 41624: Revert "Bug 35211: Removed local items from group tabs and removed group items from other holdings tab" This reverts commit 124c6c867065d4230ffa5553ca2b629e05b269a0. Bug 41624: Revert "Bug 35211: Fixed group tab item building logic" This reverts commit 23eb2dbd39ab7f46c19b299cef3db435a9ed4b7e. Bug 41624: Revert "Bug 35211: Fix tab building" This reverts commit f438535b5cfe868784bb6881839c58242432da71. Bug 41624: Revert "Bug 35211: Set SeparateHoldingsByGroup to separate based on SeparateHoldingsBranch syspref" This reverts commit d2a0527d86e82ff1edf0c31035f5ac9da232b5fe. Bug 41624: Revert "Bug 35211: Fixed count on logged in holdings" This reverts commit 96c7eb3459770c354f59fcc1d4c22ebc4eb2a559. Bug 41624: Revert "Bug 35211: Reordered tabs in Holdings Table and fixed group tabnames" This reverts commit 5c2b0fd49689b4bdaa392fc165a8fc97c1fafa1e. Bug 41624: Revert "Bug 35211: Separate group holdings into individual tabs" This reverts commit 08045c8009c52596d8df83e5da12d9e4e9abb9ae. Bug 41624: DB update to remove the pref Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192725|0 |1 is obsolete| | --- Comment #19 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192786&action=edit Bug 41624: Simplify db rev Also fix QA failures: [FAIL] installer/data/mysql/atomicupdate/bug_41624.pl FAIL file_permissions File must have the exec flag FAIL forbidden_patterns forbidden pattern: trailing space char (line 13) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Push to main for 26.05.00. Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #21 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org