https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 Bug ID: 41624 Summary: Improvements to Bug 35211 Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 35211 has some problems. 1. This is hard to read/maintain: const branchcodes = { [% FOREACH key IN branchcodes.keys %] "[% key | html %]": [ [% FOREACH code IN branchcodes.$key %] "[% code | html %]"[% UNLESS loop.last %], [% END %] [% END %] ][% UNLESS loop.last %], [% END %] [% END %] }; 2. If you select Show/Hide filters on the group holdings table the table disappears. 3. other_holdings_count is counted over and over inside the loop, it isn't necessary to do so. 4. The code seems to unnecessarily touch colvis settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.