[Bug 33290] New: Incorrect variable used in http-client.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Bug ID: 33290 Summary: Incorrect variable used in http-client.js Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 32939 Blocks: 33289 Silly error from commit 821808ec31176d662e518418c9ff8a71948e1a4b Bug 32939: Use APIClient to replace PATCH requests + const body = params.body + ? typeof str === "string" + ? params.body + : JSON.stringify(params.body) + : undefined; typeof str === "string" must be typeof params.body === "string" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 [Bug 32939] Have generic fetch functions in vue modules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148441&action=edit Bug 33290: Fix incorrect variable in http-client.js Silly error from commit 821808ec31176d662e518418c9ff8a71948e1a4b Bug 32939: Use APIClient to replace PATCH requests + const body = params.body + ? typeof str === "string" + ? params.body + : JSON.stringify(params.body) + : undefined; typeof str === "string" must be typeof params.body === "string" Test plan: With this patch, bug 33289 is not working properly. The body contains "pref_var=value" instead of pref_var=value and the syspref `var` contains `value"` Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148441|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148595&action=edit Bug 33290: Fix incorrect variable in http-client.js Silly error from commit 821808ec31176d662e518418c9ff8a71948e1a4b Bug 32939: Use APIClient to replace PATCH requests + const body = params.body + ? typeof str === "string" + ? params.body + : JSON.stringify(params.body) + : undefined; typeof str === "string" must be typeof params.body === "string" Test plan: With this patch, bug 33289 is not working properly. The body contains "pref_var=value" instead of pref_var=value and the syspref `var` contains `value"` Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148595|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148630&action=edit Bug 33290: Fix incorrect variable in http-client.js Silly error from commit 821808ec31176d662e518418c9ff8a71948e1a4b Bug 32939: Use APIClient to replace PATCH requests + const body = params.body + ? typeof str === "string" + ? params.body + : JSON.stringify(params.body) + : undefined; typeof str === "string" must be typeof params.body === "string" Test plan: With this patch, bug 33289 is not working properly. The body contains "pref_var=value" instead of pref_var=value and the syspref `var` contains `value"` Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Matt Blenkinsop from comment #5)
Nice work everyone!
Pushed to stable for 22.11.x
Hi Matt, should it be 22.11.05 in the "Version(s) released in"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed in 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |ERM |and plumbing | CC| |jonathan.druart+koha@gmail. | |com, | |jonathan.field@ptfs-europe. | |com, | |martin.renvoize@ptfs-europe | |.com, | |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org