[Bug 34380] New: Inconsistencies in Item types page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Bug ID: 34380 Summary: Inconsistencies in Item types page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Item types page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Add item type' in page title to 'New item type' - Change "Delete item type 'Y'?" to "Confirm deletion of item type 'Y'" in page title Breadcrumb - Change 'Item types administration' in breadcrumb to 'Item types' - Change 'Add item type' in breadcrumb to 'New item type' - Change "Delete item type 'Y'?" to "Confirm deletion of item type 'Y'" in breadcrumb Page header - Change 'Item types administration' in page header to 'Item types' - Change 'Add item type' in page header to 'New item type' - Add item type code to Modify X in page header - Change "Delete item type 'Y'?" to "Are you sure you want to delete item type 'Y'" in page header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34344 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> ---
Breadcrumb - Change 'Item types administration' in breadcrumb to 'Item types'
Page header - Change 'Item types administration' in page header to 'Item types'
These two points are corrected in bug 34344. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155229&action=edit Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header This patch fixes inconsistencies in the item type administration page so that page titles, breadcrumb navigation, and page headers are consistent with each other and with other pages in Koha. To test, apply the patch and go to Administration -> Item types. Check each variation of the page to confirm that everything looks correct: - Item types list - New item type - Edit item type - Confirm deletion of item type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I think this patch creates an inconsistency on http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form where the title and breadcrumbs are saying "New item type" but the <h1> header is still saying "Add item type". -- I also noticed when I tried to delete the item type "Books" that it just says: "Cannot delete this item type. This record is in use. Deletion is not possible." That differs from the deletion message you see when you try to delete "Computer Files", which asks "Are you sure you want to delete item type 'CF'?" which is one of the updated deletion messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155229|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155405&action=edit Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header This patch fixes inconsistencies in the item type administration page so that page titles, breadcrumb navigation, and page headers are consistent with each other and with other pages in Koha. To test, apply the patch and go to Administration -> Item types. Check each variation of the page to confirm that everything looks correct: - Item types list - New item type - Edit item type - Confirm deletion of item type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Cook from comment #3)
"Cannot delete this item type. This record is in use. Deletion is not possible."
This message is displayed when the item type is in use.
That differs from the deletion message you see when you try to delete "Computer Files", which asks "Are you sure you want to delete item type 'CF'?"
This message is different because it's asking for confirmation before deleting an item type which is not in use. I think the differences in these messages is to be expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 emily-rose.francoeur@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 emily-rose.francoeur@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155405|0 |1 is obsolete| | --- Comment #6 from emily-rose.francoeur@inLibro.com --- Created attachment 155496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155496&action=edit Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header This patch fixes inconsistencies in the item type administration page so that page titles, breadcrumb navigation, and page headers are consistent with each other and with other pages in Koha. To test, apply the patch and go to Administration -> Item types. Check each variation of the page to confirm that everything looks correct: - Item types list - New item type - Edit item type - Confirm deletion of item type Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155496|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155742&action=edit Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header This patch fixes inconsistencies in the item type administration page so that page titles, breadcrumb navigation, and page headers are consistent with each other and with other pages in Koha. To test, apply the patch and go to Administration -> Item types. Check each variation of the page to confirm that everything looks correct: - Item types list - New item type - Edit item type - Confirm deletion of item type Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Like others, not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org