[Bug 34388] New: Inconsistencies in Patron restriction types page headers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Bug ID: 34388 Summary: Inconsistencies in Patron restriction types page headers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Patron restriction types page, here is what should be changed to make it consistent with the other pages in the module: Page header - Add single quotes around the type name in Modify X The styling of the page Confirm deletion of X is inconsistent with other pages of the same type. It is usually presented as a warning (yellow background) and the buttons are 'Yes, delete X' and 'No, don't delete'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154682&action=edit Bug 34388: Fix inconsistencies in Patron restriction types page headers This patch fixes a couple of inconsistencies in the style of the patron restriction types administration screen, making sure the restriction type name is consistently in single quotes in headings and formatting the deletion confirmation page like other administration interfaces. Note: This patch contains indentation spaces, so ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Patron restriction types. - If necessary, add a custom restriction type. - After saving it, edit it. - The page title, breadcrumb, and page heading should match: "Modify restriction type 'X' - From the list of restriction types, click "Delete" on one of your custom restriction types. - On the deletion confirmation page you should see a standard alert-style dialog box and two button options: "Yes, delete" and "No, do not delete." Both should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154682|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 154908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154908&action=edit Bug 34388: Fix inconsistencies in Patron restriction types page headers This patch fixes a couple of inconsistencies in the style of the patron restriction types administration screen, making sure the restriction type name is consistently in single quotes in headings and formatting the deletion confirmation page like other administration interfaces. Note: This patch contains indentation spaces, so ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Patron restriction types. - If necessary, add a custom restriction type. - After saving it, edit it. - The page title, breadcrumb, and page heading should match: "Modify restriction type 'X' - From the list of restriction types, click "Delete" on one of your custom restriction types. - On the deletion confirmation page you should see a standard alert-style dialog box and two button options: "Yes, delete" and "No, do not delete." Both should work correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154908|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155055&action=edit Bug 34388: Fix inconsistencies in Patron restriction types page headers This patch fixes a couple of inconsistencies in the style of the patron restriction types administration screen, making sure the restriction type name is consistently in single quotes in headings and formatting the deletion confirmation page like other administration interfaces. Note: This patch contains indentation spaces, so ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Patron restriction types. - If necessary, add a custom restriction type. - After saving it, edit it. - The page title, breadcrumb, and page heading should match: "Modify restriction type 'X' - From the list of restriction types, click "Delete" on one of your custom restriction types. - On the deletion confirmation page you should see a standard alert-style dialog box and two button options: "Yes, delete" and "No, do not delete." Both should work correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Like Bug 33909, I prefer not to backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34388 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org