[Bug 13357] New: Untranslatable strings on itemsearch.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Bug ID: 13357 Summary: Untranslatable strings on itemsearch.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr A TT block construct on itemsearch.tt makes impossible to translate some strings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #1 from paxed <pasi.kallinen@pttk.fi> --- To clarify, these label strings are not picked up by the translation toolchain: [% INCLUDE form_field_select_option value='barcode' label='Barcode' %] Perhaps the TT should have a dummy _() marker function, similar to javascript. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to paxed from comment #1)
To clarify, these label strings are not picked up by the translation toolchain: [% INCLUDE form_field_select_option value='barcode' label='Barcode' %]
Perhaps the TT should have a dummy _() marker function, similar to javascript.
Perhaps that could be the best solution. For now I will add a TT block with all labels to translate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 34015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34015&action=edit Bug 13357: Untranslatable strings on itemsearch.tt This patch enable translation of labels on itemsearch.tt To test: 1) Translate for a fairly complete language (es-ES de-DE) 2) On staff, go to Search > Item search 3) Check there are many untranslated strings e.g. Text before pulldowns on first and second box All options on third box 4) Apply the patch 5) Repeat 1 & 2 6) Check there are now some strings translated 7) Update translation file, check there are some new strings to translate (may be they are fuzzy) e.g. "All statuses", "All collection codes" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 34666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34666&action=edit [Signed-off] Bug 13357: Untranslatable strings on itemsearch.tt This patch enable translation of labels on itemsearch.tt To test: 1) Translate for a fairly complete language (es-ES de-DE) 2) On staff, go to Search > Item search 3) Check there are many untranslated strings e.g. Text before pulldowns on first and second box All options on third box 4) Apply the patch 5) Repeat 1 & 2 6) Check there are now some strings translated 7) Update translation file, check there are some new strings to translate (may be they are fuzzy) e.g. "All statuses", "All collection codes" Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34015|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34681&action=edit Bug 13357: Untranslatable strings on itemsearch.tt This patch enable translation of labels on itemsearch.tt To test: 1) Translate for a fairly complete language (es-ES de-DE) 2) On staff, go to Search > Item search 3) Check there are many untranslated strings e.g. Text before pulldowns on first and second box All options on third box 4) Apply the patch 5) Repeat 1 & 2 6) Check there are now some strings translated 7) Update translation file, check there are some new strings to translate (may be they are fuzzy) e.g. "All statuses", "All collection codes" Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34666|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Great improvement! All looks good. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|3.16 |3.18 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mason, item search is new in 3.18, so you should not need this :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org