[Bug 42521] New: Cannot login from suggestion.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 Bug ID: 42521 Summary: Cannot login from suggestion.pl Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 39055 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'login_op' in 'WHERE' at /kohadevbox/koha/Koha/Objects.pm line 401 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39055 [Bug 39055] Unauthenticated are not redirected properly in reports module after login -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198517&action=edit Bug 42521: (bug 39055 follow-up) Fix login from suggestion.pl If you try to login from suggestion/suggestion.pl you get a 500 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'login_op' in 'WHERE' at /kohadevbox/koha/Koha/Objects.pm line 401 Test plan: Logout hit /cgi-bin/koha/suggestion/suggestion.pl login => Without this patch you get a 500 => With this patch applied you get the suggestion list view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate, | |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198553&action=edit Bug 42521: (bug 39055 follow-up) Fix login from suggestion.pl If you try to login from suggestion/suggestion.pl you get a 500 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'login_op' in 'WHERE' at /kohadevbox/koha/Koha/Objects.pm line 401 Test plan: Logout hit /cgi-bin/koha/suggestion/suggestion.pl login => Without this patch you get a 500 => With this patch applied you get the suggestion list view Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I don't know how we didn't notice this before, but I think the solution is actually to move "get_template_and_user" higher up in the code. One: that cleans up a lot of things. Two: we really shouldn't be doing anything before we do the authentication check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Ah wait... I see we've already talked about this a bit: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39055#c4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #5 from David Cook <dcook@prosentient.com.au> --- What we should do for this one is prefix the suggestion inputs with "suggestion_" I think. We should also still move the "get_template_and_user" up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #4)
Ah wait... I see we've already talked about this a bit: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39055#c4
That's explain why I had the feeling we fixed it already! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #4)
Ah wait... I see we've already talked about this a bit: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39055#c4
That explains why I had the feeling we fixed it already! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #5)
What we should do for this one is prefix the suggestion inputs with "suggestion_" I think.
This is way too complicated IMO and might cause regressions. It will require to adjust both the controller and template, that are very messy. I am not confident doing it when we can have a one-line patch that fixes the login issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #8)
(In reply to David Cook from comment #5)
What we should do for this one is prefix the suggestion inputs with "suggestion_" I think.
This is way too complicated IMO and might cause regressions. It will require to adjust both the controller and template, that are very messy. I am not confident doing it when we can have a one-line patch that fixes the login issue.
Yeah, it would definitely take a bit of work. Could always do it as two separate things. Happy for the one line patch to fix the login issue and then have a separate report to refactor suggestion.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #5)
We should also still move the "get_template_and_user" up.
Yes, we should. But we did that naively in cataloguing/addbooks.pl (iirc) and we introduced side-effects... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #10)
(In reply to David Cook from comment #5)
We should also still move the "get_template_and_user" up.
Yes, we should. But we did that naively in cataloguing/addbooks.pl (iirc) and we introduced side-effects...
I do recall Frido pointing out a similar problem elsewhere for sure. Can't recall much other than that. But yeah it could be like that for a reason. Good to be careful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42561 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42561 [Bug 42561] Refactor suggestions.pl so that it doesn't do any work before authenticating -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42561 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42561 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42561 [Bug 42561] Refactor suggestions.pl so that it doesn't do any work before authenticating -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198553|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Created attachment 198803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198803&action=edit Bug 42521: (bug 39055 follow-up) Fix login from suggestion.pl If you try to login from suggestion/suggestion.pl you get a 500 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'login_op' in 'WHERE' at /kohadevbox/koha/Koha/Objects.pm line 401 Test plan: Logout hit /cgi-bin/koha/suggestion/suggestion.pl login => Without this patch you get a 500 => With this patch applied you get the suggestion list view Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42521 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Dependency not in 25.05 - not backporting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org