[Bug 39088] New: If OPACURLOpenInNewWindow is enabled, URLs without http are broken in OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Bug ID: 39088 Summary: If OPACURLOpenInNewWindow is enabled, URLs without http are broken in OPAC results Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org Created attachment 177713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177713&action=edit Record to test A client reported this and I was able to recreate on main. They have 800+ records with URLs in 856$u without the https:// at the beginning. The URLs open fine everywhere *except* the OPAC results, where the OPACBaseURL is somehow prepended to the URL in 856. If we turn off OPACURLOpenInNewWindow, the links work fine in OPAC results. I attached one of their records as an example. To test: 1. Import the attached record 1.1. Go to Cataloging > Stage records for import 1.2. Choose the file 1.3. Click on 'Upload file' 1.4. Click on 'Stage for import' 1.5. Click 'View batch' 1.6. Click 'Import this batch into the catalog' 2. In the staff interface, search for 'Statistics' 3. In the search results, hover over 'View Document - English' under the title 'Technology adoption by women-owned businesses in Canada' --> URL is publication.gc.ca... (OK) 4. Click on the title to access the detailed record 5. Hover over 'View Document - English' --> URL is publication.gc.ca... (OK) 6. In the OPAC, search for 'Statistics' 7. In the search results, hover over 'View Document - English' under the title 'Technology adoption by women-owned businesses in Canada' --> URL is publication.gc.ca... (OK) 8. Click on the title to access the detailed record 9. Hover over 'View Document - English' --> URL is publication.gc.ca... (OK) 10. Enable OPACURLOpenInNewWindow 10.1. Go to Administration > System preferences 10.2. Search for OPACURLOpenInNewWindow 10.3. Change the value to 'do' 10.4. Click 'Save all OPAC preferences' 11. Redo steps 2-9 staff interface search results = OK staff interface detailed record = OK OPAC search results = URL is localhost:8080/cgi-bin/koha/publications.gc.ca (NOT OK) OPAC detailed record = OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177729&action=edit Bug 39088: Correctly prefix url with protocol when OPACURLOpenInNewWindow on the OPAC result page There is certainly something better to do as the xsl for the OPACDetail is calling it only once, but it needs more work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177729|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 177734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177734&action=edit Bug 39088: Correctly prefix url with protocol when OPACURLOpenInNewWindow on the OPAC result page There is certainly something better to do as the xsl for the OPACDetail is calling it only once, but it needs more work. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177734|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178089&action=edit Bug 39088: Correctly prefix url with protocol when OPACURLOpenInNewWindow on the OPAC result page There is certainly something better to do as the xsl for the OPACDetail is calling it only once, but it needs more work. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to main |Pushed to stable --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- I believe this was fixed by the first patch in bug 38096 but that was stalled for a while. I've now rebased that bug. Joubu I've added you as QA there, can you please have a look when you have the chance? Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39088 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org