[Bug 7457] New: basket.pl makes a lot of noise in the logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7457 Bug #: 7457 Summary: basket.pl makes a lot of noise in the logs Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha.sekjal@gmail.com basket.pl throws lots of warns, we should fix it. [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $line{"left_holds"} in numeric eq (==) at /home/katrin/kohaclone/acqui/basket.pl line 285., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_rrp_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_rrp_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_rrp in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_rrp in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7457 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adrien.saurat@biblibre.com AssignedTo|gmcharlt@gmail.com |adrien.saurat@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7457 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-01-31 14:29:46 UTC --- Created attachment 7399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7399 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7457 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7457 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7399|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2012-02-07 19:57:53 UTC --- Created attachment 7493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7493 [SIGNED-OFF] Bug 7457: log cleaning on basket.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7457 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2012-02-07 20:00:24 UTC --- I confirmed that basket.pl was leaving errors in the log. After the patch I tried opening, modifying, and closing a basket and saw no errors. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7457 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> 2012-02-07 20:01:26 UTC --- Sets default values of zero to various fields (rather than leaving them undefined). Easy change, simple to read, marking Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7457 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7457 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7457 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org