[Bug 41328] New: All KohaTable table broken in Vue components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Bug ID: 41328 Summary: All KohaTable table broken in Vue components Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 38426 See the current cypress failures on Jenkins
JS Warning detected: "[Vue warn]: Unhandled error during execution of mounted hook" "\n" " at <KohaTable" "ref=\"table\"" "url=\"/api/v1/preservation/waiting-list/items\"" "options=" {"embed":"biblio","orderCe
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 [Bug 38426] Node.js v18 EOL around 25.05 release time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190011&action=edit Bug 41328: Fix incorrect use of ref in KohaTable.vue This patch fixes DataTables instantiation in Vue components. There was an error in the console Uncaught (in promise) TypeError: table.value.dt is not a function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|All KohaTable table broken |All KohaTable tables broken |in Vue components |in Vue components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Should I see the error for tables in Vue enabled modules? I enabled ERM and created an agreement. I didn't get an error in the console using the developer tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Yes you should have noticed the error. Did you have the latest ktd images? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #3)
Yes you should have noticed the error. Did you have the latest ktd images?
Everything is the latest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I do confirm I get the error with the latest images. Maybe try to remove your local node_modules (/kohadevbox/koha/node_modules) before starting ktd up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, | |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 --- Comment #6 from David Nind <david@davidnind.com> --- I can confirm that I get the warnings and error by deleting the node_modules directory in my Koha git clone directory. However, there are now lots of Vue Router warnings, that I didn't get before I deleted the directory. After starting up KTD and enabling preservation and ERM modules, is there anything else I need to do? 1. Before starting up KTD, in my koha git clone directory: sudo rm -R node_modules 2. KTD: git pull (was one git change - Issue #517: Wipe possible residual directories from previous engine), removed all images, ktd pull 3. Acquisitions: - Acquisition > Vendors > Search (table shown with one vendor, My Vendor) - Warnings and errors: . ResourceList.vue:318 [Vue warn]: Unhandled error during execution of mounted hook . KohaTable.vue:228 Uncaught (in promise) TypeError: table.value.dt is not a function 4. ERM: - Several warnings: . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings/local" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eusage" - ResourceList.vue:314 [Vue warn]: Unhandled error during execution of mounted hook - Uncaught (in promise) TypeError: table.value.dt is not a function 5. Preservation: - Add a new processing: . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" - Add a new train: . ResourceList.vue:318 [Vue warn]: Unhandled error during execution of mounted hook . KohaTable.vue:228 Uncaught (in promise) TypeError: table.value.dt is not a function 6. Apply patch 7. yarn build (note: get lots of 'Deprecation warnings') (is something else required here?) 8. restart_all 9. Browser history/cache deleted 10. Acquisitions: - No warnings, but noticable delay loading table of vendors (with only two vendors, "Processing..." is shown as well) 11. ERM: - Noticable delay in loading ERM home page . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings/local" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eusage" - Loading agreements page (no noticable delay in loading): Same warnings as for home page - Loading licenses page: Same warnings as for home page - Loading packages and titles pages: . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings/local" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings/local" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eusage" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings/local" - Loading data providers and reports page: . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eusage" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings/local" . [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eusage" 12. Preservation: - Noticable delay in loading preservation home page - No warnings or errors 13. I used Chromium with the developer tools. Got similar warnings using Firefox developer edition, but the pages loaded noticably faster. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Yes, I have noticed them as well, they should be reported separately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41336 CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This fixed the problem described so I am adding my sign-off here. For the warns that David mentioned I filed a separate issue: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190011|0 |1 is obsolete| | --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190048&action=edit Bug 41328: Fix incorrect use of ref in KohaTable.vue This patch fixes DataTables instantiation in Vue components. There was an error in the console Uncaught (in promise) TypeError: table.value.dt is not a function Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190048|0 |1 is obsolete| | --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 190059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190059&action=edit Bug 41328: Fix incorrect use of ref in KohaTable.vue This patch fixes DataTables instantiation in Vue components. There was an error in the console Uncaught (in promise) TypeError: table.value.dt is not a function Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199722&action=edit Bug 41328: [25.05.x] Fix incorrect use of ref in KohaTable.vue Patch from commit abbbd5b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38426 not in 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #14 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org