[Bug 39600] New: Paginate (and modernize) OPAC ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Bug ID: 39600 Summary: Paginate (and modernize) OPAC ILL requests table Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: tadeusz@sosnierz.com QA Contact: testopia@bugs.koha-community.org CC: pedro.amorim@openfifth.co.uk, tomascohen@gmail.com OPAC ILL table, as opposed to the Staff ILL table is using server-side rendering with no pagination. This proposes bringing it in line with its Staff equivalent, porting it to API+datatables and getting all the associated goodies along with it. Patch incoming. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #1 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180758&action=edit Switch OPAC ILL request listing to server-side rendering This brings it technologically closer to intranet's ILL table and also enables pagination. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #2 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180759&action=edit Implment public_read_lists for ILL::Request and ::Attribute -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #3 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- A drawback of this approach is that it's not longer possible to order on extended attributes (author, title etc). This is a flaw shared by the Staff ILL table, where it's also the case that only the "simple" (not x-koha-embedded) values can be used for ordering. Sponsored-by: Wiko (https://www.wiko-berlin.de/) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We currently have a lot of ILL work in the queue for 25.05 - I totally love the idea about a modernization as I think it's needed, but it might need some work to fit on top of the other changes once they are pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- *** Bug 38339 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #6 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180760&action=edit Bug 39460: Fix koha-upgrade-schema when no DB change needed This patch fixes koha-upgrade-schema so that it returns an exit code of 0 whether or not a DB change is needed. This is important so that koha-common.postinst proceeds correctly even when there is no DB change needed (e.g. for 24.11.03-2) Test plan: 0. Apply the patch 1. cp debian/scripts/koha-upgrade-schema /usr/sbin/koha-upgrade-schema 2. dpkg-reconfigure koha-common 3. Note the process completes correctly 4. koha-upgrade-schema kohadev 5. Note following text appears very quickly: Upgrading database schema for kohadev No database change required 6. koha-mysql kohadev update systempreferences set value = '24.1102000' where variable = 'Version'; 7. Clear memcached 8. koha-upgrade-schema kohadev 9. Note that it applies the 24.11.03 database upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #7 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- ^ Added accidentally, ignore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |magnus@libriotech.no --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- I've closed bug 38339 as the work here implicitly fixes the issue described there. I understand this is an enhancement but could also be somewhat considered a bug fix as it's a big performance improvement for scenarios when a big a list of ILL requests are to be displayed. Please rebase on main when possible (if you haven't already) and let's try to move this quickly through QA! =D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180758|0 |1 is obsolete| | --- Comment #9 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180761&action=edit Switch OPAC ILL request listing to server-side rendering This brings it technologically closer to intranet's ILL table and also enables pagination. Rebased on top of main. Sponsored-by: Wiko (https://www.wiko-berlin.de/) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180759|0 |1 is obsolete| | --- Comment #10 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180762&action=edit Implment public_read_lists for ILL::Request and ::Attribute -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #11 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180763&action=edit Bug 39600: Switch OPAC ILL request listing to server-side rendering This brings it technologically closer to intranet's ILL table and also enables pagination. Sponsored-by: Wiko (https://www.wiko-berlin.de/) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #12 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180764&action=edit Bug 39600: Implement public_read_lists for ILL::Request and ::Attribute Sponsored-by: Wiko (https://www.wiko-berlin.de/) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180761|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #13 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- *** Bug 39450 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |andrew.auld@openfifth.co.uk | |, | |martin.renvoize@openfifth.c | |o.uk --- Comment #14 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Marked bug 39450 as a duplicate of this for the same reason as bug 38339: The patches here implicitly fix the issue there (and do more). Putting this to "Needs Sign-off" as I believe the patches are ready to be looked at. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- This is great work and greatly appreciated. I'm failing QA, to encourage quick follow-up, for the following reasons: 1) The new endpoint method patron_list needs a test in t/db_dependent/api/v1/ill_requests.t e.g. proving that requests cannot be retrieved for a different patron. 2) This needs a proper test plan (possibly on the main patch's commit message) e.g.: - Enable ILLModule - Create 50 requests for koha patron, run (if k-t-d): perl -Mt::lib::TestBuilder -e ' my $builder = t::lib::TestBuilder->new; do { $builder->build_sample_ill_request({borrowernumber => 51}); } for (1..50); ' - Access the OPAC ILL requests page: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl - Notice the requests are shown, paginated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #16 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180778&action=edit Bug 39600: Add tests for patron_list Sponsored-by: Wiko (https://www.wiko-berlin.de/) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180763|0 |1 is obsolete| | --- Comment #17 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180781&action=edit Bug 39600: Switch OPAC ILL request listing to server-side rendering This brings it technologically closer to intranet's ILL table and also enables pagination. Test plan: 1. In KTD, go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=master+switch and enable the ILL module 2. Run the following in koha-shell to populate the request list for user `koha`: perl -Mt::lib::TestBuilder -e ' my $builder = t::lib::TestBuilder->new; do { $builder->build_sample_ill_request({borrowernumber => 51}); } for (1..50); ' 3. Navigate to http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, log in as `koha` as needed 4. Observe the new request list being paginated and server-side-sortable Sponsored-by: Wiko (https://www.wiko-berlin.de/) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 [Bug 38339] Standard backend _get_core_fields are not translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180781|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180785&action=edit Bug 39600: Switch OPAC ILL request listing to server-side rendering This brings it technologically closer to intranet's ILL table and also enables pagination. Test plan: 1. In KTD, go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=master+switch and enable the ILL module 2. Run the following in koha-shell to populate the request list for user `koha`: perl -Mt::lib::TestBuilder -e ' my $builder = t::lib::TestBuilder->new; do { $builder->build_sample_ill_request({borrowernumber => 51}); } for (1..50); ' 3. Navigate to http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, log in as `koha` as needed 4. Observe the new request list being paginated and server-side-sortable Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180764|0 |1 is obsolete| | --- Comment #19 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180786&action=edit Bug 39600: Implement public_read_lists for ILL::Request and ::Attribute Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180778|0 |1 is obsolete| | --- Comment #20 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180787&action=edit Bug 39600: Add tests for patron_list Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #21 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Putting this as "Signed-off". Thank you Tadeusz. I had to reorder the patches to have them apply nicely (please always submit the whole patchset when re-submiting a patch other than the last one, or they'll fall out of order). The QA script is complaining about the following: FAIL Koha/ILL/Request.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/ILL/Request.pm` FAIL Koha/ILL/Request/Attribute.pm FAIL pod coverage POD is missing for 'public_read_list' FAIL Koha/REST/V1/ILL/Requests.pm FAIL pod coverage POD is missing for 'patron_list' FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/REST/V1/ILL/Requests.pm` OK api/v1/swagger/paths/patrons.yaml OK api/v1/swagger/swagger.yaml OK koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt FAIL filters missing_filter at line 413 ( "url": '/api/v1/patrons/[% logged_in_user.borrowernumber %]/ill/requests',) FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt` FAIL opac/opac-illrequests.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl opac/opac-illrequests.pl` FAIL t/db_dependent/api/v1/ill_requests.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/api/v1/ill_requests.t` Processing additional checks OK! Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/api/v1/ill_requests.t OK! --------------- To have the code automatically tidied for you on commit, consider using the pre commit hook: https://gitlab.com/koha-community/koha-testing-docker/-/blob/main/files/git_... This comes built-in with k-t-d. These should be easy fixes, once we have these fixed I think we should be able to move this to "Passed QA". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #22 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180821&action=edit Bug 39600: Cleanup the changes -- tidy, document, add a missing TT filter Sponsored-by: Wiko (https://www.wiko-berlin.de/) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tadeusz@sosnierz.com |ity.org | QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 [Bug 39610] Allow for customizing the metadata shown on OPAC ILL request table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #23 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Moving this to PQA to help move along as it's quite valuable work. Thanks for following up with the feedback Tadeusz! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 [Bug 39446] ILL request status shows empty in OPAC if status_alias used and lib_opac empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180785|0 |1 is obsolete| | Attachment #180786|0 |1 is obsolete| | Attachment #180787|0 |1 is obsolete| | Attachment #180821|0 |1 is obsolete| | --- Comment #24 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181132&action=edit Bug 39600: Switch OPAC ILL request listing to server-side rendering This brings it technologically closer to intranet's ILL table and also enables pagination. Test plan: 1. In KTD, go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=master+switch and enable the ILL module 2. Run the following in koha-shell to populate the request list for user `koha`: perl -Mt::lib::TestBuilder -e ' my $builder = t::lib::TestBuilder->new; do { $builder->build_sample_ill_request({borrowernumber => 51}); } for (1..50); ' 3. Navigate to http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, log in as `koha` as needed 4. Observe the new request list being paginated and server-side-sortable Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #25 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181133&action=edit Bug 39600: Implement public_read_lists for ILL::Request and ::Attribute Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #26 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181134&action=edit Bug 39600: Add tests for patron_list Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #27 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181135&action=edit Bug 39600: Cleanup the changes -- tidy, document, add a missing TT filter Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA Version|24.11 |Main --- Comment #28 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- On trying to rebase, I noticed this is using `datatable()` and manually crafting everything. Some more work is needed here. Tadeusz, can you take care of it? Happy to assist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #29 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- A few QA remarks. 1) It is great that you add a staff side endpoint for patron ILL requests 2) The OPAC should be using endpoints in the /public namespace (i.e. /public/patrons/:patron_id/ill/requests) 3) The /public namespace automatically stashes `is_public` (see V1/Auth.pm). That's why I noticed the problem with your patchset, as you manually stashed things. 4) You are using plain datatables. We use our wrapper instead. That's what should be used. If you cannot fix this, I'll give it a try. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|pedro.amorim@openfifth.co.u |tomascohen@gmail.com |k | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181132|0 |1 is obsolete| | Attachment #181133|0 |1 is obsolete| | Attachment #181134|0 |1 is obsolete| | Attachment #181135|0 |1 is obsolete| | --- Comment #30 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181437&action=edit Bug 39600: Switch OPAC ILL request listing to server-side rendering This brings it technologically closer to intranet's ILL table and also enables pagination. Test plan: 1. In KTD, go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=master+switch and enable the ILL module 2. Run the following in koha-shell to populate the request list for user `koha`: perl -Mt::lib::TestBuilder -e ' my $builder = t::lib::TestBuilder->new; do { $builder->build_sample_ill_request({borrowernumber => 51}); } for (1..50); ' 3. Navigate to http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, log in as `koha` as needed 4. Observe the new request list being paginated and server-side-sortable Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #31 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181438&action=edit Bug 39600: Implement public_read_lists for ILL::Request and ::Attribute Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #32 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181439&action=edit Bug 39600: Add tests for patron_list Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #33 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181440&action=edit Bug 39600: Cleanup the changes -- tidy, document, add a missing TT filter Sponsored-by: Wiko (https://www.wiko-berlin.de/) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #34 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181441&action=edit Bug 39600: Add Koha::Patron->ill_requests() accessor Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #35 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181442&action=edit Bug 39600: Rewrite API controllers This patch splits the controller in two: * A controller for staff users use * An unprivileged access controller A new endpoint is added for publi access: * `/public/patrons/:patron_id/ill/requests` The public one makes use of the state-of-the-art in Koha for public endpoints, using the `$c->auth->public` validation helper and leaving the (newly added) public path spec with no special permissions requirements. The staff-oriented endpoint gets the right permissions added (at least those used in the main `/ill/requests` endpoint. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/api/v1/ill_requests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #36 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181443&action=edit Bug 39600: Adapt template and use kohaTable This patch makes changes to the table introduced in the original patch: * It gets rendered using `kohaTable` instead of manually crafting the datatable * Embeds are parameters for `kohaTable` thus no need to build the headers manually * A default render method is introduced, which HTML-escapes the data for safety, and also deals with `null` values which could cause problems. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39739 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 [Bug 39739] OPAC's datatables.js out of sync with staff's -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #37 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Tadeusz and all. I finally made some bigger changes than expected. My motivation was to make this through the finish line of course. And also show you how we introduce new controllers. Hope you like it and we can chat about this if you want to. You should re-test it too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch modernizes the release notes| |ILL requests page in the | |OPAC, by making it render | |using the API. | | | |New API | |endpoints are added for | |this purpose. | | | |The result | |is the table gets | |pagination and search | |features previously not | |available. Summary|Paginate (and modernize) |Use the API to render the |OPAC ILL requests table |OPAC ILL requests table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38339 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 [Bug 38339] Standard backend _get_core_fields are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181441|0 |1 is obsolete| | --- Comment #38 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 181524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181524&action=edit Bug 39600: Add Koha::Patron->ill_requests() accessor Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181442|0 |1 is obsolete| | --- Comment #39 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 181525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181525&action=edit Bug 39600: Rewrite API controllers This patch splits the controller in two: * A controller for staff users use * An unprivileged access controller A new endpoint is added for publi access: * `/public/patrons/:patron_id/ill/requests` The public one makes use of the state-of-the-art in Koha for public endpoints, using the `$c->auth->public` validation helper and leaving the (newly added) public path spec with no special permissions requirements. The staff-oriented endpoint gets the right permissions added (at least those used in the main `/ill/requests` endpoint. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/api/v1/ill_requests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181443|0 |1 is obsolete| | --- Comment #40 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 181526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181526&action=edit Bug 39600: Adapt template and use kohaTable This patch makes changes to the table introduced in the original patch: * It gets rendered using `kohaTable` instead of manually crafting the datatable * Embeds are parameters for `kohaTable` thus no need to build the headers manually * A default render method is introduced, which HTML-escapes the data for safety, and also deals with `null` values which could cause problems. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181437|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181532&action=edit Bug 39600: Switch OPAC ILL request listing to server-side rendering This brings it technologically closer to intranet's ILL table and also enables pagination. Test plan: 1. In KTD, go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=master+switch and enable the ILL module 2. Run the following in koha-shell to populate the request list for user `koha`: perl -Mt::lib::TestBuilder -e ' my $builder = t::lib::TestBuilder->new; do { $builder->build_sample_ill_request({borrowernumber => 51}); } for (1..50); ' 3. Navigate to http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, log in as `koha` as needed 4. Observe the new request list being paginated and server-side-sortable Sponsored-by: Wiko <https://www.wiko-berlin.de/> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181438|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181533&action=edit Bug 39600: Implement public_read_lists for ILL::Request and ::Attribute Sponsored-by: Wiko <https://www.wiko-berlin.de/> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181439|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181534&action=edit Bug 39600: Add tests for patron_list Sponsored-by: Wiko <https://www.wiko-berlin.de/> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181440|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181535&action=edit Bug 39600: Cleanup the changes -- tidy, document, add a missing TT filter Sponsored-by: Wiko <https://www.wiko-berlin.de/> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181524|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181536&action=edit Bug 39600: Add Koha::Patron->ill_requests() accessor Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181525|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181537&action=edit Bug 39600: Rewrite API controllers This patch splits the controller in two: * A controller for staff users use * An unprivileged access controller A new endpoint is added for publi access: * `/public/patrons/:patron_id/ill/requests` The public one makes use of the state-of-the-art in Koha for public endpoints, using the `$c->auth->public` validation helper and leaving the (newly added) public path spec with no special permissions requirements. The staff-oriented endpoint gets the right permissions added (at least those used in the main `/ill/requests` endpoint. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/api/v1/ill_requests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181526|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181538&action=edit Bug 39600: Adapt template and use kohaTable This patch makes changes to the table introduced in the original patch: * It gets rendered using `kohaTable` instead of manually crafting the datatable * Embeds are parameters for `kohaTable` thus no need to build the headers manually * A default render method is introduced, which HTML-escapes the data for safety, and also deals with `null` values which could cause problems. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #48 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This is great work and it's great to see such a team effort. Passing QA, thanks all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #49 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- PS: I updated the Sponsored-by line.. the URL needs to be within <> rather than () got the scripts to properly pick it up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch modernizes the |This patch modernizes the release notes|ILL requests page in the |ILL requests page in the |OPAC, by making it render |OPAC by making it render |using the API. |using the API. | | |New API |New API |endpoints are added for |endpoints are added for |this purpose. |this purpose. | | |The result |This |is the table gets |includes adding pagination |pagination and search |and search features to the |features previously not |table previously not |available. |available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39761 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 [Bug 39761] OPAC DataTables responsive table controls style broken by Bug 39600 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #51 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181608&action=edit Bug 39600: Add server-side rendering to OPAC datatables If commit 03dd9efb72d06dee6dc256b8d2e138ed7fc7b3ca gets reverted, we will still need to implement the server-side rendering feature from Staff. This patch does that. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181608|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39762 [Bug 39762] Add datatables server-side rendering to OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart@gmail.com --- Comment #52 from Jonathan Druart <jonathan.druart@gmail.com> --- xt/api.t .. 3/6 # Failed test 'No errors in 400 definitions in the spec' # at xt/api.t line 168. # got: '2' # expected: '0' get /patrons/{patron_id}/ill/requests -> 'description' does not include '* `invalid_query`': (Bad request) get /public/patrons/{patron_id}/ill/requests -> 'description' does not include '* `invalid_query`': (Bad request) # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #53 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181652&action=edit Bug 39600: Fix spec to include invalid query handling Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|39761 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 [Bug 39761] OPAC DataTables responsive table controls style broken by Bug 39600 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #53)
Created attachment 181652 [details] [review] Bug 39600: Fix spec to include invalid query handling
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to main (very soon). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #55 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Aude Charillon contact| | CC| |aude.charillon@openfifth.co | |.uk Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1199 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #56 from Aude Charillon <aude.charillon@openfifth.co.uk> --- New screenshot added to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 Bug 39600 depends on bug 39739, which changed state. Bug 39739 Summary: OPAC's datatables.js out of sync with staff's https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org