https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 62339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62339&action=edit Bug 18450 - Implemented a check to determine if the 'Override and renew' button is displayed based on the setting of the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences. This will display the 'Override and renew' button only if both preferences are set to 'Allow'. Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' 5. Click the 'Override and renew' button and notice that although you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is still not being displayed. 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable to 'Allow' 11. Try renewing the item again and notice that now both of these preferences are allowed the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62339|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 62447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62447&action=edit Bug 18450 - Implemented a check to determine if the 'Override and renew' button is displayed based on the setting of the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences. This will display the 'Override and renew' button only if both preferences are set to 'Allow'. Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' 5. Click the 'Override and renew' button and notice that although you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is still not being displayed. 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable to 'Allow' 11. Try renewing the item again and notice that now both of these preferences are allowed the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. Folloed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Sorry, found a wrinkle. With AllowRenewalLimitOverride set to Don't allow and AllowRenewalIfOtherItemsAvailable set to Allow and you haven't hit the renewal limit, you are still blocked with the hold in place. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 62811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62811&action=edit Bug 18450 - Implemented check if either AllowRenewLimitOverride or AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only blocked if both of these sysprefs are set to 'Dont allow' Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' warning 5. Click the 'Override and renew' button and notice that you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is displayed 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and renew' button is displayed 11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 63226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63226&action=edit Bug 18450 - Implemented check if either AllowRenewLimitOverride or AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only blocked if both of these sysprefs are set to 'Dont allow' Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' warning 5. Click the 'Override and renew' button and notice that you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is displayed 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and renew' button is displayed 11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62447|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63292&action=edit [SIGNED-OFF] Bug 18450 - Implemented a check to determine if the 'Override and renew' button is displayed based on the setting of the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences. This will display the 'Override and renew' button only if both preferences are set to 'Allow'. Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' 5. Click the 'Override and renew' button and notice that although you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is still not being displayed. 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable to 'Allow' 11. Try renewing the item again and notice that now both of these preferences are allowed the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. Folloed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63226|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63293&action=edit [SIGNED-OFF] Bug 18450 - Implemented check if either AllowRenewLimitOverride or AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only blocked if both of these sysprefs are set to 'Dont allow' Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' warning 5. Click the 'Override and renew' button and notice that you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is displayed 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and renew' button is displayed 11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 63377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63377&action=edit Bug 18450 - Implemented check if either AllowRenewLimitOverride or AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only blocked if both of these sysprefs are set to 'Dont allow' Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' warning 5. Click the 'Override and renew' button and notice that you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is displayed 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and renew' button is displayed 11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63377|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Two things here: 1 - 'AllowRenewalIfOtherItemsAvailable' - we need to check if other items are available - a record with 1 item with a hold and checked out should not be renewable (it is currently) 2 - As Jonathan mentioned in comment #11 - if we are doing the same stuff we can do "IF A OR B OR C { stuff }" - no need for if/elsif -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #21 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 69489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69489&action=edit Bug 18450 - Followup - Implemented a conditional checking if the item that the patron is trying to renew has more than 1 copy available which can be renewed. This means the AllowRebnewalIfOtherItemsAvailable system preference is now appropriately impleme In order to make the conditional statement work correctly checking three conditions each time (two system preferences and the value of the can_renew variable I had to implement a elsif statement. I spent a large amount of time trying to get a single IF statement to check the three conditions in three different combinations but it ignored the value of the can_renew variable each time and so I was forced to split it out into an If and ELSIF Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' warning 5. Click the 'Override and renew' button and notice that you can bypass the hold 6. Apply patch 7. Try to renew an item (with item level hold on it) which belongs to a biblio with either only one item or a biblio with multiple items all of which have holds on them. Notice the only button in the yellow message box displayed is 'Continue without renewing' 8. Repeat step 7 but change the hold to a 'Next available' hold rather than an item level hold. Again notice only the 'Continue without renewing' button is displayed 9. Try to renew an item (with item level hold on it) which belongs to a biblio with mutliple aviable items of it in the catalogue. Notice only the 'Continue without renewing' button is displayed 10. Repeat step 9 but change the hold to a 'Next available' hold rather than an item level hold. Notice only the 'Continue without renewing' button is displayed 11. Set both AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable systempreferences to 'Allow' and repeat step 7 notice only the 'Continue without renewing' button is displayed in the yellow message box 12. Repeat step 8 and notice only the 'Continue without renewing' button is displayed 13. Repeat step 9 and notice only the 'Continue without renewing' button is displayed 14. Repeat step 10 and notice the item is immediately renewed and the yellow message box is not displayed 15. Set the AllowRenewalIfOtheritemsAvailable to 'Dont' Allow' and repeat step 7 and notice that both the 'Override and renew' and 'Continue without renewal' buttons are displayed 16. Repeat step 8 and notice both buttons are displayed 17. Repeat step 9 and notice both buttons are displayed 18. Repeat step 10 and notice both buttons are displayed 19. Set AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and AllowRenewalLimitOverride syspref to 'Dont' Allow' and repeat step 7 and notice only the 'Continue without renewal' button is displayed 20. Repeat step 8 and notice only 'Continue without renewal' button is displayed 21. Repeat step 9 and notice only the 'Continue without renewal' button is displayed 22. Repeat step 10 and notice both buttons are displayed Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #22 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #24 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72836&action=edit Bug 18450 - Followup - Implemented a conditional checking if the item that the patron is trying to renew has more than 1 copy available which can be renewed. This means the AllowRebnewalIfOtherItemsAvailable system preference is now appropriately implemen In order to make the conditional statement work correctly checking three conditions each time (two system preferences and the value of the can_renew variable I had to implement a elsif statement. I spent a large amount of time trying to get a single IF statement to check the three conditions in three different combinations but it ignored the value of the can_renew variable each time and so I was forced to split it out into an If and ELSIF Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' warning 5. Click the 'Override and renew' button and notice that you can bypass the hold 6. Apply patch 7. Try to renew an item (with item level hold on it) which belongs to a biblio with either only one item or a biblio with multiple items all of which have holds on them. Notice the only button in the yellow message box displayed is 'Continue without renewing' 8. Repeat step 7 but change the hold to a 'Next available' hold rather than an item level hold. Again notice only the 'Continue without renewing' button is displayed 9. Try to renew an item (with item level hold on it) which belongs to a biblio with mutliple aviable items of it in the catalogue. Notice only the 'Continue without renewing' button is displayed 10. Repeat step 9 but change the hold to a 'Next available' hold rather than an item level hold. Notice only the 'Continue without renewing' button is displayed 11. Set both AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable systempreferences to 'Allow' and repeat step 7 notice only the 'Continue without renewing' button is displayed in the yellow message box 12. Repeat step 8 and notice only the 'Continue without renewing' button is displayed 13. Repeat step 9 and notice only the 'Continue without renewing' button is displayed 14. Repeat step 10 and notice the item is immediately renewed and the yellow message box is not displayed 15. Set the AllowRenewalIfOtheritemsAvailable to 'Dont' Allow' and repeat step 7 and notice that both the 'Override and renew' and 'Continue without renewal' buttons are displayed 16. Repeat step 8 and notice both buttons are displayed 17. Repeat step 9 and notice both buttons are displayed 18. Repeat step 10 and notice both buttons are displayed 19. Set AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and AllowRenewalLimitOverride syspref to 'Dont' Allow' and repeat step 7 and notice only the 'Continue without renewal' button is displayed 20. Repeat step 8 and notice only 'Continue without renewal' button is displayed 21. Repeat step 9 and notice only the 'Continue without renewal' button is displayed 22. Repeat step 10 and notice both buttons are displayed Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #26 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86587&action=edit Bug 18450: Mades changes for QA test tool and old code missed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72835|0 |1 is obsolete| | Attachment #72836|0 |1 is obsolete| | --- Comment #27 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86588&action=edit Bug 18450: (Follow up) Only show Override button for renewals according to relevant sysprefs This patch is a follow up which corrects the conditional that uses the system preferences AllowRenewalIfOtherItemsAvailable and AllowRenewalLimitOverridecontrols to control the display of the 'Override and renew' button, in addition to the 'Continue without renewing' button, when renewing an item that has been placed on hold. This patch also adjusts the expected results for each step in the test plan outlined in the previous patches to align better with the system preferences. Test plan: --NOTE-- The following renewals must be completed in Circulation->Renew 1) Apply the patch, and ensure the following steps work as described 2) In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Don't allow' 3) Item Level/Only one available item: Try to renew an item (with item level hold on it) which belongs to a biblio with only one item. Note the only button in the yellow message box displayed is 'Continue without renewing' 4) Record Level/Only one available item: Try to renew an item (this time with a 'Next Available' hold on the record) which belongs to a biblio with only one item. Note the only button in the yellow message box displayed is 'Continue without renewing' 5) Item Level/Multiple available items: Try to renew an item (with item level hold on it) which belongs to a biblio with multiple available items of it in the catalogue. Note only the 'Continue without renewing' button is displayed 6) Record Level/Multiple available items: Try to renew an item (this time with a 'Next Available' hold on the record) which belongs to a biblio with multiple available items of it in the catalogue. Note only the 'Continue without renewing' button is displayed 7) Set both AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable system preferences to 'Allow' 8) Repeat step 3, and note only the 'Continue without renewing' button is displayed in the yellow message box 9) Repeat step 4, and note the only button in the yellow message box displayed is 'Continue without renewing' 10) Repeat step 5, note only the 'Continue without renewing' button is displayed (because the hold is for that specific item) 11) Repeat step 6, note the item is immediately renewed and the yellow message box is not displayed 12) Set the AllowRenewalIfOtheritemsAvailable to 'Don't Allow' and repeat steps 3-6, and note that only the 'Continue without renewing' button is displayed 13) Set the AllowRenewalIfOtherItemsAvailable system preference back to 'Allow' and AllowRenewalLimitOverride syspref to 'Don't Allow', and repeat steps 3-5 and note only the 'Continue without renewal' button is displayed. 14) Repeat step 6 and note that the item is immediately renewed with no yellow warning box. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Attachment #86587|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #30 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86591&action=edit Bug 18450: Mades changes for QA test tool and old code missed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |martin.renvoize@ptfs-europe | |.com --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Did this get fixed somewhere else already.. looks like both patches are applied but I can't seen any reference to them in the git logs. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #34 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 87338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87338&action=edit Bug 18450: (follow up) Fixed forbidden patterns for qa tool Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87337|0 |1 is obsolete| | Attachment #87338|0 |1 is obsolete| | --- Comment #35 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87528&action=edit Bug 18450: Only allow Override for renewals according to relevant sysprefs This patch adds a conditional which refers to the system preferences AllowRenewalIfOtherItemsAvailable and AllowRenewalLimitOverride to control the display of the 'Override and renew' button, in addition to the 'Continue without renewing', when renewing an item that has been placed on hold. Test plan: --NOTE-- The following renewals must be completedd in Circulation->Renew 1) Apply the patch, and ensure the following steps work as described 2) In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvailable preferences are both set to 'Don't allow' 3) Item levelOnly one available item: Try to renew an item (with item level hold on it) which belongs to a biblio with only one item. Note the only button in the yellow alert box displayed is 'Continue without renewing' 4) Record level/Only one available item: Try to renew an item (this time with a 'Next Available' hold on the record) which belongs to a biblio with only one item. Note the only button in the yellow alert box displayed is 'Continue without renewing' 5) Item level/Multiple available items: Try to renew an item (with item level hold on it) which belongs to a biblio with multiple available items of it in the catalogue. Note only the 'Continue without renewing' button is displayed 6) Record level/Multiple available items: Try to renew an item (with item level hold on it) which belongs to a biblio with multiple available items of it in the catalogue. Note only the 'Continue without renewing' button is displayed 7) Set both AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvailable system preferences to 'Allow' 8) Repeat step 3, and note only the 'Continue without renewing' button is displayed in the yellow alert box 9) Repeat step 4, and note the only button in the yellow alert box displayed is 'Continue without renewing' 10) Repeat step 5, not only the 'Continue without renewing' button is displayed (because the hold is for that specific item) 11) Repeat step 6, note the item is immediately renewed and the yellow alert box is not displayed 12) Set the AllowRenewalIfOtherItemsAvailable to 'Don't Allow' and repeat steps 3-6, and note that only the 'Continue without renewing' button is displayed 13) Set the AllowRenewalIfOtherItemsAvailable system preference back to 'Allow' and AllowRenewalLimitOverride syspref to 'Don't Allow', and repeat steps 3-5 and note only the 'Continue without renewal' button is displayed. 14) Repeat step 6 and note that the item is immediately renewed with no yellow warning box. Sponsored-by: Catalyst IT Signed-off-by: Liz Rea <wizzyrea@gmail.com> that is a well thorough test plan. All went as expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Hayley, looking at the conditions I noticed the check on AllowRenewalLimitOverride. I fear things are even a bit more complicated :( AllowRenewalLimitOverride works only, if the patron also is superlibrarian or has the override_renewals permission. Could you take a look? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is still relevant? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slott@duncanville.com --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 22676 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #42 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 202738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202738&action=edit Bug 18450: Make renew module respect the syspref AllowRenewalOnHoldOverride TEST PLAN 1 - Checkout a book to Henry Acevedo 2 - Place a hold for Edna Acosta on the book 3 - Go to /cgi-bin/koha/circ/renew.pl and try to renew the book 4 - APPLY PATCH 5 - Repeat 3 and notice you are not prompted anymore -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Keywords| |release-notes-needed Status|Needs Signoff |Failed QA --- Comment #44 from David Nind <david@davidnind.com> --- This seems to work as expected for me. However, I've set the status to Failed QA because there is some extra text before the "Override and renew" button when AllowRenewalOnHoldOverride is set to "Allow": "PLOP:" (see step 6 of my testing notes). Testing notes (using KTD): 1. Make sure these system preferences as set: - AllowRenewalOnHoldOverride = Don't allow - AllowRenewalIfOtherItemsAvailable = Don't allow 2. Get message when attempting to renew before the patch (issue as described for the bug): Cannot renew: Programming Perl / ( 39999000011418 ): This item is on hold for another patron. Renewal due date: _____________ X Override and renew Continue without renewing 3. Apply the patch. 4. With the patch, the message is (as expected): Cannot renew: Programming Perl / ( 39999000011418 ): This item is on hold for another patron. Continue without renewing 5. Set the system preferences to: - AllowRenewalOnHoldOverride = Allow (changed) - AllowRenewalIfOtherItemsAvailable = Don't allow (not changed) 6. The message is the same as in step 2, however there is some extra text before the "Override and renew" button: PLOP 7. Set the system preferences to: - AllowRenewalOnHoldOverride = Allow (unchanged) - AllowRenewalIfOtherItemsAvailable = Allow (changed) 8. Same message as before with the extra text ("PLOP"). Additional testing (after patch applied) - AllowRenewalIfOtherItemsAvailable: 1. I'm not sure if I understand AllowRenewalIfOtherItemsAvailable correctly, but I tested with a record that has multiple items available: - Perl template toolkit (255), item 39999000011111 2. With the system preferences set to: - AllowRenewalOnHoldOverride = Don't allow - AllowRenewalIfOtherItemsAvailable = Don't allow Get the message (seems as expected): Cannot renew: Perl template toolkit / ( 39999000011111 ): This item is on hold for another patron. Continue without renewing 3. With the system preferences set to: - AllowRenewalOnHoldOverride = Allow (changed) - AllowRenewalIfOtherItemsAvailable = Don't allow (unchanged) Get the message (seems as expected): Cannot renew: Perl template toolkit / ( 39999000011111 ): This item is on hold for another patron. Renewal due date: _____________ X Override and renew Continue without renewing 4. With the system preferences set to: - AllowRenewalOnHoldOverride = Allow (unchanged) - AllowRenewalIfOtherItemsAvailable = Allow (changed) Get the message (as expected, other items are available so renewed without any override required messages): Item renewed: Perl template toolkit / ( 39999000011111 ) renewed for Henry Acevedo ( 23529000035676 ) now due on 08/14/2026 -- You are receiving this mail because: You are watching all bug changes.