[Bug 11859] New: Add edition and publication year to PDF templates in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Bug ID: 11859 Summary: Add edition and publication year to PDF templates in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Add edition and publication year to the order information in PDF templates sent to the vendor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7267 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 25703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25703&action=edit Bug 11856: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 25704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25704&action=edit Bug 11856: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 25705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25705&action=edit Bug 11856: Add publiction year and edition to French acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout3pagesfr. Additional change: Translates 'published by' to 'publié par' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr --- Comment #4 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- jeudi 13 mars 2014 10:46 The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11859: <h1>Something went wrong !</h1>Applying: Bug 11856: Add publication year and edition to English acq PDF templates Applying: Bug 11856: Add publiction year and edition to German acq PDF template fatal: sha1 information is lacking or useless (acqui/pdfformat/layout2pagesde.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11856: Add publiction year and edition to German acq PDF template When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11859 - Add edition and publication year to PDF templates in acquisitions 25703 - Bug 11856: Add publication year and edition to English acq PDF templates 25704 - Bug 11856: Add publiction year and edition to German acq PDF template 25705 - Bug 11856: Add publiction year and edition to French acq PDF template Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11856-Add-publiction-year-and-edition-to-Germa-_p7StB.patch . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, this needs to be applied on top of a few other patches indicated in the dependencies :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25703|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27470&action=edit [SIGNED-OFF] Bug 11856: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25704|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27471&action=edit [SIGNED-OFF] Bug 11856: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27474&action=edit [SIGNED-OFF] Bug 11856: Add publiction year and edition to French acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout3pagesfr. Additional change: Translates 'published by' to 'publié par' http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25705|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27470|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27723&action=edit [PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27471|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27724&action=edit [PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27474|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27725&action=edit [PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27723|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27726&action=edit [PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Apart from some issues getting this to apply (just git issues with encoding).. once I did manage then we're good. Passes qa scritps and causes no regressions. A simple enhancement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27724|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27725|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27726|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27471|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27474|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27723|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27727&action=edit [PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27471|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27728&action=edit [PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27470|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27471|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27727|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27470|0 |1 is obsolete| | Attachment #27471|0 |1 is obsolete| | Attachment #27474|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27730&action=edit [PASSED QA] Bug 11856: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27731&action=edit [PASSED QA] Bug 11856: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27732&action=edit [PASSED QA] Bug 11856: Add publiction year and edition to French acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout3pagesfr. Additional change: Translates 'published by' to 'publie par' http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11859 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #19 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org