[Bug 11724] New: Make Funds/Status on suggestions page sortable/searchable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 Bug ID: 11724 Summary: Make Funds/Status on suggestions page sortable/searchable Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All URL: /cgi-bin/koha/suggestion/suggestion.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The 2 last columns in the suggestions table in staff are not sortable. Also, if you enter the fund name in the datatable search box on top of the table, it will not match. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26363&action=edit Bug 11724 - Make Funds/Status on suggestions page sortable/searchable The fund and status columns on the suggestions page are not sortable or searchable. This patch makes them so. This patch also amends the DataTables configuration to use class-based targeting for sorting types as was decided on the koha-devel list. The table markup has been modified accordingly. To test you must have existing suggestions. Apply the patch and go to Acquisitions -> Suggestions. View the table of existing suggestions and confirm that the funds and status columns are sortable and searchable. Confirm that the title column correctly ignores articles when sorting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 27515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27515&action=edit [Signed off] Bug 11724 - Make Funds/Status on suggestions page sortable/searchable The fund and status columns on the suggestions page are not sortable or searchable. This patch makes them so. This patch also amends the DataTables configuration to use class-based targeting for sorting types as was decided on the koha-devel list. The table markup has been modified accordingly. To test you must have existing suggestions. Apply the patch and go to Acquisitions -> Suggestions. View the table of existing suggestions and confirm that the funds and status columns are sortable and searchable. Confirm that the title column correctly ignores articles when sorting. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26363|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 26363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26363 Bug 11724 - Make Funds/Status on suggestions page sortable/searchable Please remember to obsolete the original patch when signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27515|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27651&action=edit [PASSED QA] Bug 11724 - Make Funds/Status on suggestions page sortable/searchable The fund and status columns on the suggestions page are not sortable or searchable. This patch makes them so. This patch also amends the DataTables configuration to use class-based targeting for sorting types as was decided on the koha-devel list. The table markup has been modified accordingly. To test you must have existing suggestions. Apply the patch and go to Acquisitions -> Suggestions. View the table of existing suggestions and confirm that the funds and status columns are sortable and searchable. Confirm that the title column correctly ignores articles when sorting. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, template change only. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11724 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org