[Bug 43034] New: t/db_dependent/Koha/EDI.t fails when SearchEngine is Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 Bug ID: 43034 Summary: t/db_dependent/Koha/EDI.t fails when SearchEngine is Elasticsearch Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Depends on| |21820 Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21820 [Bug 21820] Zebraqueue should not be added to when only Elasticsearch is used -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201739&action=edit Bug 43034: Fix t/db_dependent/Koha/EDI.t failure when SearchEngine is Elasticsearch Bug 21820 made the Zebra queue update conditional on the new ElasticsearchEnableZebraQueue system preference, which defaults to off. The 'basic_quote_processing' subtest in t/db_dependent/Koha/EDI.t counts the log lines process_quote emits, and two of those are the "specialUpdate biblioserver" traces that ModZebra logs only when the Zebra queue path runs. When the SearchEngine preference is set to Elasticsearch, that path no longer runs by default, so the subtest now records 6 log lines instead of 8 and fails: # Failed test '8 log lines recorded for passed quote file' # got: '6' # expected: '8' # Failed test 'Trace recorded biblioserver index' Test Plan: 1) Set the SearchEngine system preference to 'Elasticsearch' 2) prove t/db_dependent/Koha/EDI.t 3) Note the basic_quote_processing subtest fails with "got: '6', expected: '8'" 4) Apply this patch 5) prove t/db_dependent/Koha/EDI.t 6) Note the tests pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201849|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201990&action=edit Bug 43034: Fix t/db_dependent/Koha/EDI.t failure when SearchEngine is Elasticsearch Bug 21820 made the Zebra queue update conditional on the new ElasticsearchEnableZebraQueue system preference, which defaults to off. The 'basic_quote_processing' subtest in t/db_dependent/Koha/EDI.t counts the log lines process_quote emits, and two of those are the "specialUpdate biblioserver" traces that ModZebra logs only when the Zebra queue path runs. When the SearchEngine preference is set to Elasticsearch, that path no longer runs by default, so the subtest now records 6 log lines instead of 8 and fails: # Failed test '8 log lines recorded for passed quote file' # got: '6' # expected: '8' # Failed test 'Trace recorded biblioserver index' Test Plan: 1) Set the SearchEngine system preference to 'Elasticsearch' 2) prove t/db_dependent/Koha/EDI.t 3) Note the basic_quote_processing subtest fails with "got: '6', expected: '8'" 4) Apply this patch 5) prove t/db_dependent/Koha/EDI.t 6) Note the tests pass! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 --- Comment #4 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Not reproduced on 25.11.x, not backporting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43034 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org