[Bug 22521] New: Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Bug ID: 22521 Summary: Convert fines handling to use 'status' instead of two accounttypes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Bug 22512 introduces a new field for tracking the 'state' of various accounttypes; We should convert the current fine handling from using `FU` (denoting "fine unreturned/updating") in combination with `F` (denoting fine "fixed"). This will clarify the logic and also pave the way to having a more user definable accounttype configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22512 Blocks| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14390 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 [Bug 22547] C4::Overdues - UpdateFine is untested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86808&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Not ready for testing yet.. UI side still needs a patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86808|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86890&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86891&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86892&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86890|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86893&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86891|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86894&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86892|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86895&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86893|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86896&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86894|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86897&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86898&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test Plan 1) Apply patch and ensure updated tests still pass 2) Run DB updates and ensure the display of status's makes sense on all pages that display accountline details (account summary, print and payment pages on staff and the user account fines page on the opac) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86895|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86899&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86896|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86900&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86897|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86901&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86898|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86902&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22564 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86899|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86918&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86900|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86919&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86901|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86920&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86902|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86921&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 86919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86919 Bug 22521: Update fines handling to use accountline.status Review of attachment 86919: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22521&attachment=86919) ----------------------------------------------------------------- ::: Koha/Account.pm @@ +471,4 @@
itemnumber => $item_id, issue_id => $issue_id, branchcode => $library_id, + ( $type eq 'overdue' ? ( lastincrement => $amount ) : ()),
Does it make sense to you to make this dependent also on 22516, which removes lastincrement column? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Josef Moravec <josef.moravec@gmail.com> --- And the tests are not passing: t/db_dependent/Circulation.t .. 36/126 Type of debit not recognised# Looks like your test exited with 255 just after 37. t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 89/126 subtests t/db_dependent/Overdues.t ..... 4/17 # Looks like you planned 25 tests but ran 1. t/db_dependent/Overdues.t ..... 17/17 # Failed test 'UpdateFine tests' # at t/db_dependent/Overdues.t line 307. Type of debit not recognised# Looks like your test exited with 255 just after 17. t/db_dependent/Overdues.t ..... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/17 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- git grep "fine_update" returns: C4/Overdues.pm: $accountline->adjust({ amount => $amount, type => 'fine_update' }); t/db_dependent/Koha/Account/Lines.t: throws_ok { $debit_1->adjust( { amount => 50, type => 'fine_update' } ) } t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 150, type => 'fine_update' } )->discard_changes; t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 160, type => 'fine_update' } )->discard_changes; t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 50, type => 'fine_update' } )->discard_changes; t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 30, type => 'fine_update' } )->discard_changes; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87063&action=edit Bug 22521: (QA follow-up) Corrections to tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86918|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87083&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86919|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87084&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86920|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87085&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86921|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87086&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87063|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87087&action=edit Bug 22521: (QA follow-up) Corrections to tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87083|0 |1 is obsolete| | Attachment #87084|0 |1 is obsolete| | Attachment #87085|0 |1 is obsolete| | Attachment #87086|0 |1 is obsolete| | Attachment #87087|0 |1 is obsolete| | --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87097&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87098&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87099&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87100&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87101&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Josef Moravec from comment #21)
Comment on attachment 86919 [details] [review] Bug 22521: Update fines handling to use accountline.status
Review of attachment 86919 [details] [review]: -----------------------------------------------------------------
::: Koha/Account.pm @@ +471,4 @@
itemnumber => $item_id, issue_id => $issue_id, branchcode => $library_id, + ( $type eq 'overdue' ? ( lastincrement => $amount ) : ()),
Does it make sense to you to make this dependent also on 22516, which removes lastincrement column?
Thanks for the quick testing and signoff. Can't believe I let those tests slip through in that state. As for the dependency on bug 22516.. Isort of agree but didn't want to make the tree look too complicated.. hopefully it'll be pushed imminently and it should be a trivial rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22518 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22564 Depends on|22564 |22600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22511 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87097|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87209&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87098|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87210&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87099|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87211&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87100|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87212&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87101|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87213&action=edit Bug 22521: (QA follow-up) Corrections to tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87214&action=edit Bug 22521: (follow-up) Update 'Offsets' test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87209|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87215&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87210|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87216&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87211|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87217&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87212|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87218&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87213|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87219&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87214|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87220&action=edit Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 22519 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87215|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87619&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87216|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87620&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87217|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87621&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87218|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87622&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87219|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87623&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87220|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87624&action=edit Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Freshly re-based and ready for QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87619|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87678&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87620|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87679&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87621|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87680&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87622|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87681&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87623|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87682&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87624|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87683&action=edit Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21953 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 [Bug 21953] Term "Lost item" is untranslatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87678|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87787&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87679|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87788&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87680|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87789&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87681|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87790&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87682|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87791&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87683|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87792&action=edit Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Freshly rebased on new dependancies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Looks good! I only have a one issue: Shouldn't VOID be in these blocks on the staff and opac side? [%- BLOCK account_status_description -%] [%- SWITCH account.status -%] [%- CASE 'UNRETURNED' -%]<span> (Accruing)</span> [%- CASE 'RETURNED' -%]<span> (Returned)</span> [%- CASE 'FORGIVEN' -%]<span> (Forgiven)</span> [%- CASE -%] [%- END -%] [%- END -%] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- See the dependency tree.. the VOID state is added further down the tree and as such it's introduced as you suggest there.. my brain couldn't keep it all in my head for one massive bug.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- Excellent! I was reading the tree backwards! My Bad ;) (In reply to Martin Renvoize from comment #70)
See the dependency tree.. the VOID state is added further down the tree and as such it's introduced as you suggest there.. my brain couldn't keep it all in my head for one massive bug..
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87787|0 |1 is obsolete| | Attachment #87788|0 |1 is obsolete| | Attachment #87789|0 |1 is obsolete| | Attachment #87790|0 |1 is obsolete| | Attachment #87791|0 |1 is obsolete| | Attachment #87792|0 |1 is obsolete| | --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87808&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87809&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87810&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87811&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87812&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87813&action=edit Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87814&action=edit Bug 22521: (QA Followup) Update number of tests in Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oh, this needs a quick follow-up which I'll post tomorrow.. FFOR got reintroduced in the last rebase, just needs re-removing from the UI display patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Passed QA |Patch doesn't apply --- Comment #80 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 22521: Increase varchar size for accounttype Applying: Bug 22521: Update fines handling to use accountline.status error: sha1 information is lacking or useless (C4/Circulation.pm). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87808|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87850&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87809|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87851&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87810|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87852&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87811|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87853&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87812|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87854&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87813|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87855&action=edit Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87814|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87856&action=edit Bug 22521: (QA Followup) Update number of tests in Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87857&action=edit Bug 22521: (QA follow-up) remove FFOR from display A rebase re-introduced the FFOR accounttype in the display list. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87850|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87858&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87851|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87859&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87852|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87860&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87853|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87861&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87854|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87862&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87863&action=edit Bug 22521: (QA follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87864&action=edit Bug 22521: (QA follow-up) Update number of tests in Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87857|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87865&action=edit Bug 22521: (QA follow-up) remove FFOR from display A rebase re-introduced the FFOR accounttype in the display list. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #97 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Following this trail, it still does not apply. Can we wait for some things to get pushed btw ? 22628 21953 22547 22521 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Bug 22521 depends on bug 22600, which changed state. Bug 22600 Summary: We should add an 'interface' field to accountlines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87855|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87858|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88064&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87859|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88065&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87860|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88066&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87861|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88067&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87862|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88068&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87863|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88069&action=edit Bug 22521: (QA follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87864|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88070&action=edit Bug 22521: (QA follow-up) Update number of tests in Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87865|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88071&action=edit Bug 22521: (QA follow-up) remove FFOR from display A rebase re-introduced the FFOR accounttype in the display list. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88067|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88068|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88069|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88070|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88071|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #106 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88149&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88150&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88151&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88152&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88153&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #111 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88154&action=edit Bug 22521: (QA follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88155&action=edit Bug 22521: (QA follow-up) remove FFOR from display A rebase re-introduced the FFOR accounttype in the display list. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88156&action=edit Bug 22521: (QA follow-up) Update number of tests in Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #114 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #115 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88286&action=edit Bug 22521: (RM follow-up) Adjust tests to use new accounttype -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #116 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #115)
Created attachment 88286 [details] [review] Bug 22521: (RM follow-up) Adjust tests to use new accounttype
Followup pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Bug 22521 depends on bug 21953, which changed state. Bug 21953 Summary: Term "Lost item" is untranslatable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Bug 22521 depends on bug 22547, which changed state. Bug 22547 Summary: C4::Overdues - UpdateFine is barely tested https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Text to go in the| |WARNING: You will need to release notes| |update your reports to | |account for the introduced | |use of 'status' in | |accountlines for fines. | | | |"accounttype = 'FU'" needs | |changing to "accounttype = | |'FINE' AND status = | |'UNRETURNED'" | | | |"accounttype | |= 'F'" needs changing to | |"accounttype = 'FINE' AND | |status != 'UNRETURNED'" Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|WARNING: You will need to |This patch clarifies the release notes|update your reports to |intended purpose of the |account for the introduced |various accounttypes used |use of 'status' in |for fines calculations in |accountlines for fines. |the accounttline table. | | |"accounttype = 'FU'" needs |WARNING: You will need to |changing to "accounttype = |update your reports to |'FINE' AND status = |account for the introduced |'UNRETURNED'" |use of 'status' in | |accountlines for fines. |"accounttype | |= 'F'" needs changing to |"accounttype = 'FU'" needs |"accounttype = 'FINE' AND |changing to "accounttype = |status != 'UNRETURNED'" |'FINE' AND status = | |'UNRETURNED'" | | | |"accounttype | |= 'F'" needs changing to | |"accounttype = 'FINE' AND | |status != 'UNRETURNED'" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23316 [Bug 23316] GetFine needs updating for bug 22521 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 [Bug 23827] Cash register statistics uses old accounttype values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 [Bug 23826] Manual Invoice does not use new accounttype and status for fines -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org