[Bug 21000] New: debian/build-git-snapshot script ignores --distribution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Bug ID: 21000 Summary: debian/build-git-snapshot script ignores --distribution Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: jcharaoui@cmaisonneuve.qc.ca QA Contact: testopia@bugs.koha-community.org CC: mirko@abunchofthings.net Calling debian/build-git-snapshot with the --distribution switch has no effect. It seems that the variable isn't passed to the adjust_debian_changelog() function. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is a colision with debug: 41 'distribution|D=s' => \$distribution, 46 'debug|d' => \$debug, It works with the long option name (--distribution) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|debian/build-git-snapshot |debian/build-git-snapshot |script ignores |script ignores -D |--distribution | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Reading the code it seems like debug is better called verbose. Anyone object to a change to verbose? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Because of the whole --version/-v fixing case sensitivity seemed best. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 91056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91056&action=edit Bug 21000: Force case sensitivity on Getopt::Long Before patch: -D and -d are mistaken for --debug $ sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -r ~/debian -v 19.06~git --autoversion -d -D="stretch" Option d does not take an argument git status --porcelain -unormal git rev-parse --short=8 HEAD dch --force-distribution -D "squeeze-dev" -v "19.06~git+20190627205913.466f99e4-1" "Building git snapshot." dch warning: Recognised distributions are: experimental, unstable, testing, stable, oldstable, oldoldstable, {bullseye,buster,stretch,jessie,wheezy}-proposed-updates, {testing,stable,oldstable,oldoldstable}-proposed-updates, {bullseye,buster,stretch,jessie,wheezy}-security, {testing,stable,oldstable,oldoldstable}}-security, jessie-backports, stretch-backports and UNRELEASED. Using your request anyway. NOTE: squeeze-dev in the first dch line and warning about Option d. Apply patch: -D and -d are differentiated correctly. $ sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -r ~/debian -v 19.06~git --autoversion -d -D="stretch" git status --porcelain -unormal git rev-parse --short=8 HEAD dch --force-distribution -D "stretch" -v "19.06~git+20190627210316.b3f919a7-1" "Building git snapshot." dch warning: Previous package version was Debian native whilst new version is not dch -r "Building git snapshot." NOTE: No more 'Option d' error, and "stretch" in the first dch line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91056|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91294&action=edit Bug 21000: Force case sensitivity on Getopt::Long Before patch: -D and -d are mistaken for --debug $ sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -r ~/debian -v 19.06~git --autoversion -d -D="stretch" Option d does not take an argument git status --porcelain -unormal git rev-parse --short=8 HEAD dch --force-distribution -D "squeeze-dev" -v "19.06~git+20190627205913.466f99e4-1" "Building git snapshot." dch warning: Recognised distributions are: experimental, unstable, testing, stable, oldstable, oldoldstable, {bullseye,buster,stretch,jessie,wheezy}-proposed-updates, {testing,stable,oldstable,oldoldstable}-proposed-updates, {bullseye,buster,stretch,jessie,wheezy}-security, {testing,stable,oldstable,oldoldstable}}-security, jessie-backports, stretch-backports and UNRELEASED. Using your request anyway. NOTE: squeeze-dev in the first dch line and warning about Option d. Apply patch: -D and -d are differentiated correctly. $ sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -r ~/debian -v 19.06~git --autoversion -d -D="stretch" git status --porcelain -unormal git rev-parse --short=8 HEAD dch --force-distribution -D "stretch" -v "19.06~git+20190627210316.b3f919a7-1" "Building git snapshot." dch warning: Previous package version was Debian native whilst new version is not dch -r "Building git snapshot." NOTE: No more 'Option d' error, and "stretch" in the first dch line. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Good catch, Mark. This always bothered me and didn't find the time to dig into the solution. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91294|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 91332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91332&action=edit Bug 21000: Force case sensitivity on Getopt::Long Before patch: -D and -d are mistaken for --debug $ sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -r ~/debian -v 19.06~git --autoversion -d -D="stretch" Option d does not take an argument git status --porcelain -unormal git rev-parse --short=8 HEAD dch --force-distribution -D "squeeze-dev" -v "19.06~git+20190627205913.466f99e4-1" "Building git snapshot." dch warning: Recognised distributions are: experimental, unstable, testing, stable, oldstable, oldoldstable, {bullseye,buster,stretch,jessie,wheezy}-proposed-updates, {testing,stable,oldstable,oldoldstable}-proposed-updates, {bullseye,buster,stretch,jessie,wheezy}-security, {testing,stable,oldstable,oldoldstable}}-security, jessie-backports, stretch-backports and UNRELEASED. Using your request anyway. NOTE: squeeze-dev in the first dch line and warning about Option d. Apply patch: -D and -d are differentiated correctly. $ sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -r ~/debian -v 19.06~git --autoversion -d -D="stretch" git status --porcelain -unormal git rev-parse --short=8 HEAD dch --force-distribution -D "stretch" -v "19.06~git+20190627210316.b3f919a7-1" "Building git snapshot." dch warning: Previous package version was Debian native whilst new version is not dch -r "Building git snapshot." NOTE: No more 'Option d' error, and "stretch" in the first dch line. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Very sensible fix, thanks.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org